[PATCH v2 0/2] dt-bindings: yaml conversions of some simple ADC bindings.

[PATCH v2 0/2] dt-bindings: yaml conversions of some simple ADC bindings.

[Jonathan Cameron]

From: Jonathan Cameron <Jonathan.Cameron@huawei.com>

Remaining binding conversions for which changes were needed based on v1
reviews.

Jonathan Cameron (2):
  dt-bindings: iio: adc: ti,adc12138 yaml conversion.
  dt-bindings: iio: adc: ti,ads7950 binding conversion

 .../bindings/iio/adc/ti,adc12138.yaml         | 86 +++++++++++++++++++
 .../bindings/iio/adc/ti,ads7950.yaml          | 65 ++++++++++++++
 .../bindings/iio/adc/ti-adc12138.txt          | 37 --------
 .../bindings/iio/adc/ti-ads7950.txt           | 23 -----
 4 files changed, 151 insertions(+), 60 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/iio/adc/ti,adc12138.yaml
 create mode 100644 Documentation/devicetree/bindings/iio/adc/ti,ads7950.yaml
 delete mode 100644 Documentation/devicetree/bindings/iio/adc/ti-adc12138.txt
 delete mode 100644 Documentation/devicetree/bindings/iio/adc/ti-ads7950.txt

-- 
2.28.0

[PATCH v2 1/2] dt-bindings: iio: adc: ti,adc12138 yaml conversion.

[Jonathan Cameron]

From: Jonathan Cameron <Jonathan.Cameron@huawei.com>

Simple binding conversion from txt to yaml.
Only addition was #io-channel-cells to allow for potential consumers
of the channels on this device.

Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Cc: Akinobu Mita <akinobu.mita@gmail.com>
---

Changes:
* Fix missing include.
* Fix typo in one of the supplies.
* Fix spacing wrt to brackets.

 .../bindings/iio/adc/ti,adc12138.yaml         | 86 +++++++++++++++++++
 .../bindings/iio/adc/ti-adc12138.txt          | 37 --------
 2 files changed, 86 insertions(+), 37 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/iio/adc/ti,adc12138.yaml
 delete mode 100644 Documentation/devicetree/bindings/iio/adc/ti-adc12138.txt

diff --git a/Documentation/devicetree/bindings/iio/adc/ti,adc12138.yaml b/Documentation/devicetree/bindings/iio/adc/ti,adc12138.yaml
new file mode 100644
index 000000000000..ec3b2edf1fb7
--- /dev/null
+++ b/Documentation/devicetree/bindings/iio/adc/ti,adc12138.yaml
@@ -0,0 +1,86 @@
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/iio/adc/ti,adc12138.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Texas Instruments ADC12138 and similar self-calibrating ADCs
+
+maintainers:
+  - Akinobu Mita <akinobu.mita@gmail.com>
+
+description: |
+  13 bit ADCs with 1, 2 or 8 inputs and self calibrating circuitry to
+  correct for linearity, zero and full scale errors.
+
+properties:
+  compatible:
+    enum:
+      - ti,adc12130
+      - ti,adc12132
+      - ti,adc12138
+
+  reg:
+    maxItems: 1
+
+  interrupts:
+    maxItems: 1
+    description: End of Conversion (EOC) interrupt
+
+  clocks:
+    maxItems: 1
+    description: Conversion clock input.
+
+  spi-max-frequency: true
+
+  vref-p-supply:
+    description: The regulator supply for positive analog voltage reference
+
+  vref-n-supply:
+    description: |
+      The regulator supply for negative analog voltage reference
+      (Note that this must not go below GND or exceed vref-p)
+      If not specified, this is assumed to be analog ground.
+
+  ti,acquisition-time:
+    $ref: /schemas/types.yaml#/definitions/uint32
+    enum: [ 6, 10, 18, 34 ]
+    description: |
+      The number of conversion clock periods for the S/H's acquisition time.
+      For high source impedances, this value can be increased to 18 or 34.
+      For less ADC accuracy and/or slower CCLK frequencies this value may be
+      decreased to 6.  See section 6.0 INPUT SOURCE RESISTANCE in the
+      datasheet for details.
+
+  "#io-channel-cells":
+    const: 1
+
+required:
+  - compatible
+  - reg
+  - interrupts
+  - clocks
+  - vref-p-supply
+
+additionalProperties: false
+
+examples:
+  - |
+    #include <dt-bindings/interrupt-controller/irq.h>
+    spi {
+        #address-cells = <1>;
+        #size-cells = <0>;
+
+        adc@0 {
+            compatible = "ti,adc12138";
+            reg = <0>;
+            interrupts = <28 IRQ_TYPE_EDGE_RISING>;
+            interrupt-parent = <&gpio1>;
+            clocks = <&cclk>;
+            vref-p-supply = <&ldo4_reg>;
+            spi-max-frequency = <5000000>;
+            ti,acquisition-time = <6>;
+            #io-channel-cells = <1>;
+        };
+    };
+...
diff --git a/Documentation/devicetree/bindings/iio/adc/ti-adc12138.txt b/Documentation/devicetree/bindings/iio/adc/ti-adc12138.txt
deleted file mode 100644
index 049a1d36f013..000000000000
--- a/Documentation/devicetree/bindings/iio/adc/ti-adc12138.txt
+++ /dev/null
@@ -1,37 +0,0 @@
-* Texas Instruments' ADC12130/ADC12132/ADC12138
-
-Required properties:
- - compatible: Should be one of
-	* "ti,adc12130"
-	* "ti,adc12132"
-	* "ti,adc12138"
- - reg: SPI chip select number for the device
- - interrupts: Should contain interrupt for EOC (end of conversion)
- - clocks: phandle to conversion clock input
- - spi-max-frequency: Definision as per
-	Documentation/devicetree/bindings/spi/spi-bus.txt
- - vref-p-supply: The regulator supply for positive analog voltage reference
-
-Optional properties:
- - vref-n-supply: The regulator supply for negative analog voltage reference
-	(Note that this must not go below GND or exceed vref-p)
-	If not specified, this is assumed to be analog ground.
- - ti,acquisition-time: The number of conversion clock periods for the S/H's
-	acquisition time.  Should be one of 6, 10, 18, 34.  If not specified,
-	default value of 10 is used.
-	For high source impedances, this value can be increased to 18 or 34.
-	For less ADC accuracy and/or slower CCLK frequencies this value may be
-	decreased to 6.  See section 6.0 INPUT SOURCE RESISTANCE in the
-	datasheet for details.
-
-Example:
-adc@0 {
-	compatible = "ti,adc12138";
-	reg = <0>;
-	interrupts = <28 IRQ_TYPE_EDGE_RISING>;
-	interrupt-parent = <&gpio1>;
-	clocks = <&cclk>;
-	vref-p-supply = <&ldo4_reg>;
-	spi-max-frequency = <5000000>;
-	ti,acquisition-time = <6>;
-};
-- 
2.28.0

[PATCH v2 2/2] dt-bindings: iio: adc: ti,ads7950 binding conversion

[Jonathan Cameron]

From: Jonathan Cameron <Jonathan.Cameron@huawei.com>

Conversion from txt to yaml.  The binding documents that
as not all boards will make use of the ADC channels via a consumer
driver.  It does no harm however, so we will leave it as required.

Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Cc: David Lechner <david@lechnology.com>
---

Changes:
* Fix patch description to make sense.
* Fix a supplies instead of supply.
* Add maximum value for spi-bus-frequency

 .../bindings/iio/adc/ti,ads7950.yaml          | 65 +++++++++++++++++++
 .../bindings/iio/adc/ti-ads7950.txt           | 23 -------
 2 files changed, 65 insertions(+), 23 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/iio/adc/ti,ads7950.yaml
 delete mode 100644 Documentation/devicetree/bindings/iio/adc/ti-ads7950.txt

diff --git a/Documentation/devicetree/bindings/iio/adc/ti,ads7950.yaml b/Documentation/devicetree/bindings/iio/adc/ti,ads7950.yaml
new file mode 100644
index 000000000000..5ab5027be97e
--- /dev/null
+++ b/Documentation/devicetree/bindings/iio/adc/ti,ads7950.yaml
@@ -0,0 +1,65 @@
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/iio/adc/ti,ads7950.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Texas Instruments ADS7950 and similar ADCs
+
+maintainers:
+  - David Lechner <david@lechnology.com>
+
+description: |
+  Family of 4-16 channel, 8-12 bit ADCs with SPI interface.
+
+properties:
+  compatible:
+    enum:
+      - ti,ads7950
+      - ti,ads7951
+      - ti,ads7952
+      - ti,ads7953
+      - ti,ads7954
+      - ti,ads7955
+      - ti,ads7956
+      - ti,ads7957
+      - ti,ads7958
+      - ti,ads7959
+      - ti,ads7960
+      - ti,ads7961
+
+  reg:
+    maxItems: 1
+
+  spi-max-frequency:
+    maximum: 20000000
+
+  vref-supply:
+    description: Supplies the 2.5V or 5V reference voltage
+
+  "#io-channel-cells":
+    const: 1
+
+required:
+  - compatible
+  - reg
+  - vref-supply
+  - "#io-channel-cells"
+
+additionalProperties: false
+
+examples:
+  - |
+    spi {
+        #address-cells = <1>;
+        #size-cells = <0>;
+
+        adc@0 {
+            compatible = "ti,ads7957";
+            reg = <0>;
+            vref-supply = <&refin_supply>;
+            spi-max-frequency = <10000000>;
+            #io-channel-cells = <1>;
+        };
+    };
+...
diff --git a/Documentation/devicetree/bindings/iio/adc/ti-ads7950.txt b/Documentation/devicetree/bindings/iio/adc/ti-ads7950.txt
deleted file mode 100644
index e77a6f7e1001..000000000000
--- a/Documentation/devicetree/bindings/iio/adc/ti-ads7950.txt
+++ /dev/null
@@ -1,23 +0,0 @@
-* Texas Instruments ADS7950 family of A/DC chips
-
-Required properties:
- - compatible: Must be one of "ti,ads7950", "ti,ads7951", "ti,ads7952",
-   "ti,ads7953", "ti,ads7954", "ti,ads7955", "ti,ads7956", "ti,ads7957",
-   "ti,ads7958", "ti,ads7959", "ti,ads7960", or "ti,ads7961"
- - reg: SPI chip select number for the device
- - #io-channel-cells: Must be 1 as per ../iio-bindings.txt
- - vref-supply: phandle to a regulator node that supplies the 2.5V or 5V
-   reference voltage
-
-Recommended properties:
- - spi-max-frequency: Definition as per
-		Documentation/devicetree/bindings/spi/spi-bus.txt
-
-Example:
-adc@0 {
-	compatible = "ti,ads7957";
-	reg = <0>;
-	#io-channel-cells = <1>;
-	vref-supply = <&refin_supply>;
-	spi-max-frequency = <10000000>;
-};
-- 
2.28.0

Re: [PATCH v2 2/2] dt-bindings: iio: adc: ti,ads7950 binding conversion

[David Lechner]

On 8/30/20 11:11 AM, Jonathan Cameron wrote:
> From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> 
> Conversion from txt to yaml.  The binding documents that
> as not all boards will make use of the ADC channels via a consumer
> driver.  It does no harm however, so we will leave it as required.
> 
> Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> Cc: David Lechner <david@lechnology.com>
> ---

Reviewed-by: David Lechner <david@lechnology.com>

Re: [PATCH v2 1/2] dt-bindings: iio: adc: ti,adc12138 yaml conversion.

[Rob Herring]

On Sun, 30 Aug 2020 17:11:53 +0100, Jonathan Cameron wrote:
> From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> 
> Simple binding conversion from txt to yaml.
> Only addition was #io-channel-cells to allow for potential consumers
> of the channels on this device.
> 
> Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> Cc: Akinobu Mita <akinobu.mita@gmail.com>
> ---
> 
> Changes:
> * Fix missing include.
> * Fix typo in one of the supplies.
> * Fix spacing wrt to brackets.
> 
>  .../bindings/iio/adc/ti,adc12138.yaml         | 86 +++++++++++++++++++
>  .../bindings/iio/adc/ti-adc12138.txt          | 37 --------
>  2 files changed, 86 insertions(+), 37 deletions(-)
>  create mode 100644 Documentation/devicetree/bindings/iio/adc/ti,adc12138.yaml
>  delete mode 100644 Documentation/devicetree/bindings/iio/adc/ti-adc12138.txt
> 

Reviewed-by: Rob Herring <robh@kernel.org>

Re: [PATCH v2 2/2] dt-bindings: iio: adc: ti,ads7950 binding conversion

[Rob Herring]

On Sun, 30 Aug 2020 17:11:54 +0100, Jonathan Cameron wrote:
> From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> 
> Conversion from txt to yaml.  The binding documents that
> as not all boards will make use of the ADC channels via a consumer
> driver.  It does no harm however, so we will leave it as required.
> 
> Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> Cc: David Lechner <david@lechnology.com>
> ---
> 
> Changes:
> * Fix patch description to make sense.
> * Fix a supplies instead of supply.
> * Add maximum value for spi-bus-frequency
> 
>  .../bindings/iio/adc/ti,ads7950.yaml          | 65 +++++++++++++++++++
>  .../bindings/iio/adc/ti-ads7950.txt           | 23 -------
>  2 files changed, 65 insertions(+), 23 deletions(-)
>  create mode 100644 Documentation/devicetree/bindings/iio/adc/ti,ads7950.yaml
>  delete mode 100644 Documentation/devicetree/bindings/iio/adc/ti-ads7950.txt
> 

Reviewed-by: Rob Herring <robh@kernel.org>

Re: [PATCH v2 0/2] dt-bindings: yaml conversions of some simple ADC bindings.

[Jonathan Cameron]

On Sun, 30 Aug 2020 17:11:52 +0100
Jonathan Cameron <jic23@kernel.org> wrote:

> From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> 
> Remaining binding conversions for which changes were needed based on v1
> reviews.
Series applied.

Thanks,

Jonathan

> 
> Jonathan Cameron (2):
>   dt-bindings: iio: adc: ti,adc12138 yaml conversion.
>   dt-bindings: iio: adc: ti,ads7950 binding conversion
> 
>  .../bindings/iio/adc/ti,adc12138.yaml         | 86 +++++++++++++++++++
>  .../bindings/iio/adc/ti,ads7950.yaml          | 65 ++++++++++++++
>  .../bindings/iio/adc/ti-adc12138.txt          | 37 --------
>  .../bindings/iio/adc/ti-ads7950.txt           | 23 -----
>  4 files changed, 151 insertions(+), 60 deletions(-)
>  create mode 100644 Documentation/devicetree/bindings/iio/adc/ti,adc12138.yaml
>  create mode 100644 Documentation/devicetree/bindings/iio/adc/ti,ads7950.yaml
>  delete mode 100644 Documentation/devicetree/bindings/iio/adc/ti-adc12138.txt
>  delete mode 100644 Documentation/devicetree/bindings/iio/adc/ti-ads7950.txt
>