From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E609BC43464 for ; Sat, 19 Sep 2020 13:47:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 83B7620773 for ; Sat, 19 Sep 2020 13:47:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1600523230; bh=A9noJQM4YHomXTCTgIvOe4XmtphNBlCKniiGyha2nws=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=rjofRWE4KV02bi2sbGRPXPnTOIRYVdZOKtm3K+Gx8tjnQLkogORYeqQXZ4+vJu8t/ NtVQt2cUBF2+0PEh2gWHQM+0flOMss9uvQU8DvetGfzgmrJBg8fUz2QvYdMCVw0p4G SMyVU5rp7sNgclIFYEa2QoJquiVcHM4PNtciwSFU= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726400AbgISNrK (ORCPT ); Sat, 19 Sep 2020 09:47:10 -0400 Received: from mail.kernel.org ([198.145.29.99]:44538 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726159AbgISNrJ (ORCPT ); Sat, 19 Sep 2020 09:47:09 -0400 Received: from archlinux (cpc149474-cmbg20-2-0-cust94.5-4.cable.virginm.net [82.4.196.95]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id DE55B206B8; Sat, 19 Sep 2020 13:47:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1600523229; bh=A9noJQM4YHomXTCTgIvOe4XmtphNBlCKniiGyha2nws=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=egT71fylmm2erLHXC6dPwBKl3vmGsqIFAqZ8w/U+DnC1rC1brAD71HBA6EvU37jZQ tW8R756d8UVXXBrY68VUs5WMoPsxh97Os2eSIY3O9U1oNeb5IBTMSr2RWrnTtJHWiD Qxh8ikJAxdpgpQ2pkZCcUNL6kHxLXL46zk7cggPE= Date: Sat, 19 Sep 2020 14:47:04 +0100 From: Jonathan Cameron To: Jonathan Cameron Cc: Joel Stanley , , "Rob Herring" , devicetree , "Rick Altherr" , Andrew Jeffery Subject: Re: [PATCH v2 04/20] dt-bindings:iio:adc: aspeed,ast2400 yaml conversion Message-ID: <20200919144704.3b7ca5dd@archlinux> In-Reply-To: <20200916151751.00001947@Huawei.com> References: <20200909175946.395313-1-jic23@kernel.org> <20200909175946.395313-5-jic23@kernel.org> <20200916113625.0000641e@Huawei.com> <20200916151751.00001947@Huawei.com> X-Mailer: Claws Mail 3.17.6 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org On Wed, 16 Sep 2020 15:17:51 +0100 Jonathan Cameron wrote: > On Wed, 16 Sep 2020 12:39:36 +0000 > Joel Stanley wrote: > > > On Wed, 16 Sep 2020 at 10:38, Jonathan Cameron > > wrote: > > > > > > On Thu, 10 Sep 2020 02:32:19 +0000 > > > Joel Stanley wrote: > > > > > > > On Wed, 9 Sep 2020 at 18:02, Jonathan Cameron wrote: > > > > > > > > > > From: Jonathan Cameron > > > > > > > > > > Simple txt to yaml conversion. Part of a general move to convert > > > > > all the IIO bindings over to yaml. > > > > > > > > > > Signed-off-by: Jonathan Cameron > > > > > Cc: Rick Altherr > > > > > Cc: Joel Stanley > > > > > Cc: Andrew Jeffery > > > > > > > > Acked-by: Joel Stanley > > > > > > > > > > > > > --- > > > > > .../bindings/iio/adc/aspeed,ast2400-adc.yaml | 54 +++++++++++++++++++ > > > > > .../bindings/iio/adc/aspeed_adc.txt | 22 -------- > > > > > 2 files changed, 54 insertions(+), 22 deletions(-) > > > > > > > > > > diff --git a/Documentation/devicetree/bindings/iio/adc/aspeed,ast2400-adc.yaml b/Documentation/devicetree/bindings/iio/adc/aspeed,ast2400-adc.yaml > > > > > new file mode 100644 > > > > > index 000000000000..09018487d690 > > > > > --- /dev/null > > > > > +++ b/Documentation/devicetree/bindings/iio/adc/aspeed,ast2400-adc.yaml > > > > > > > > This naming doesn't make sense, as the bindings are for the ast2500 > > > > too (and they also apply for the ast2600). > > > > > > Convention is to name after a supported device and not use > > > wild cards or generic names because the chances of it going > > > wrong in future is far too high. Will every aspeed adc look the same? > > > Seems impossible to predict so best we can do safely is to pick a > > > part number. > > > > It already supports three different generations of SoC, which I was > > bringing to your attention. Therefore having the name '2400' is > > already incorrect. > > I'm happy to change it to a specific part number of your choice but you > have to chose one. The file name is not a list of all the parts supported. > > There are bindings that attach to hundreds of different part numbers but the > file is named after a specific one. Normally the first part supported > is the one chosen (because the binding is normally written at that time). > If we later decide to rename this then fair enough, but for now I've applied the patch as it stands to the togreg branch of iio.git and pushed out as testing for the autobuilders to possibly poke at it. Note I made the change Rob pointed out whilst applying. Thanks, Jonathan > Jonathan > > > > > > > > > There are enormous numbers of examples of this in dt bindings and > > > for that matter driver naming. > > > > > > Thanks, > > > > > > Jonathan > > > > > > > > > > > > > > > @@ -0,0 +1,54 @@ > > > > > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > > > > > +%YAML 1.2 > > > > > +--- > > > > > +$id: http://devicetree.org/schemas/iio/adc/aspeed,ast2400-adc.yaml# > > > > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > > > > + > > > > > +title: ADC that forms part of an ASPEED server management processor. > > > > > + > > > > > +maintainers: > > > > > + - Rick Altherr > > > > > + > > > > > +description: > > > > > + This device is a 10-bit converter for 16 voltage channels. All inputs are > > > > > + single ended. > > > > > + > > > > > +properties: > > > > > + compatible: > > > > > + enum: > > > > > + - aspeed,ast2400-adc > > > > > + - aspeed,ast2500-adc > > > > > + > > > > > + reg: > > > > > + maxItems: 1 > > > > > + > > > > > + clocks: > > > > > + description: > > > > > + Input clock used to derive the sample clock. Expected to be the > > > > > + SoC's APB clock. > > > > > + > > > > > + resets: true > > > > > + > > > > > + "#io-channel-cells": > > > > > + const: 1 > > > > > + > > > > > +required: > > > > > + - compatible > > > > > + - reg > > > > > + - clocks > > > > > + - resets > > > > > + - "#io-channel-cells" > > > > > + > > > > > +additionalProperties: false > > > > > + > > > > > +examples: > > > > > + - | > > > > > + #include > > > > > + adc@1e6e9000 { > > > > > + compatible = "aspeed,ast2400-adc"; > > > > > + reg = <0x1e6e9000 0xb0>; > > > > > + clocks = <&syscon ASPEED_CLK_APB>; > > > > > + resets = <&syscon ASPEED_RESET_ADC>; > > > > > + #io-channel-cells = <1>; > > > > > + }; > > > > > +... > > > > > diff --git a/Documentation/devicetree/bindings/iio/adc/aspeed_adc.txt b/Documentation/devicetree/bindings/iio/adc/aspeed_adc.txt > > > > > deleted file mode 100644 > > > > > index 034fc2ba100e..000000000000 > > > > > --- a/Documentation/devicetree/bindings/iio/adc/aspeed_adc.txt > > > > > +++ /dev/null > > > > > @@ -1,22 +0,0 @@ > > > > > -Aspeed ADC > > > > > - > > > > > -This device is a 10-bit converter for 16 voltage channels. All inputs are > > > > > -single ended. > > > > > - > > > > > -Required properties: > > > > > -- compatible: Should be "aspeed,ast2400-adc" or "aspeed,ast2500-adc" > > > > > -- reg: memory window mapping address and length > > > > > -- clocks: Input clock used to derive the sample clock. Expected to be the > > > > > - SoC's APB clock. > > > > > -- resets: Reset controller phandle > > > > > -- #io-channel-cells: Must be set to <1> to indicate channels are selected > > > > > - by index. > > > > > - > > > > > -Example: > > > > > - adc@1e6e9000 { > > > > > - compatible = "aspeed,ast2400-adc"; > > > > > - reg = <0x1e6e9000 0xb0>; > > > > > - clocks = <&syscon ASPEED_CLK_APB>; > > > > > - resets = <&syscon ASPEED_RESET_ADC>; > > > > > - #io-channel-cells = <1>; > > > > > - }; > > > > > -- > > > > > 2.28.0 > > > > > > > > > > > > >