From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B30C5C43464 for ; Mon, 21 Sep 2020 09:58:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7B26B21BE5 for ; Mon, 21 Sep 2020 09:58:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726384AbgIUJ6o (ORCPT ); Mon, 21 Sep 2020 05:58:44 -0400 Received: from lhrrgout.huawei.com ([185.176.76.210]:2897 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726326AbgIUJ6n (ORCPT ); Mon, 21 Sep 2020 05:58:43 -0400 Received: from lhreml710-chm.china.huawei.com (unknown [172.18.7.106]) by Forcepoint Email with ESMTP id 7B239BE51E25D89791C6; Mon, 21 Sep 2020 10:58:42 +0100 (IST) Received: from localhost (10.52.121.13) by lhreml710-chm.china.huawei.com (10.201.108.61) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1913.5; Mon, 21 Sep 2020 10:58:42 +0100 Date: Mon, 21 Sep 2020 10:57:03 +0100 From: Jonathan Cameron To: Christian Eggers CC: Jonathan Cameron , Lars-Peter Clausen , Thomas Gleixner , "Sebastian Andrzej Siewior" , Hartmut Knaack , "Peter Meerwald-Stadler" , Subject: Re: [PATCH 1/2] iio: hrtimer-trigger: Mark hrtimer to expire in hard interrupt context Message-ID: <20200921105703.000048b3@Huawei.com> In-Reply-To: <5007153.c9bsiqU2ZW@n95hx1g2> References: <20200813075358.13310-1-lars@metafoo.de> <20200814113008.00002733@Huawei.com> <20200920191545.4ed79276@archlinux> <5007153.c9bsiqU2ZW@n95hx1g2> Organization: Huawei Technologies Research and Development (UK) Ltd. X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; i686-w64-mingw32) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.52.121.13] X-ClientProxiedBy: lhreml744-chm.china.huawei.com (10.201.108.194) To lhreml710-chm.china.huawei.com (10.201.108.61) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org On Mon, 21 Sep 2020 09:17:26 +0200 Christian Eggers wrote: > Tested together with > > - iio: Fix: Do not poll the driver again if try_reenable() callback returns non 0. > and > - iio:trigger: rename try_reenable() to reenable() plus return void > > on latest mainline (without PREEMPT_RT). The original WARN_ONCE() in > kernel/irq/handle.c:159 was not raised anymore. But even without the current > patches, this warning is not shown (as this problem only applies to -RT). > > Currently I haven't ported a RT kernel > 5.4 for my board, so I cannot check > with current RT. On 5.4. there the patches seem not to work fully as > kernel/timer/hrtimer.c is not up to date enough. > > Sorry for being not very helpful... Thanks for at least trying! So looking at this the other way, are there any significant risks associated with this change? If not I'm tempted to queue them up and we have the rcX time to fix anything we've missed (just like every other patch!) Jonathan > > Best regards > Christian > > On Sunday, 20 September 2020, 20:15:45 CEST, Jonathan Cameron wrote: > > From: Jonathan Cameron > > > > As we no longer support a try again if we cannot reenable the trigger > > rename the function to reflect this. Also we don't do anything with > > the value returned so stop it returning anything. For the few drivers > > that didn't already print an error message in this patch, add such > > a print. > > > > Signed-off-by: Jonathan Cameron > > Cc: Linus Walleij > > Cc: Srinivas Pandruvada > > Cc: Christian Oder > > Cc: Eugen Hristev > > Cc: Nishant Malpani > > Cc: Daniel Baluta > > --- > > >