From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0856FC43468 for ; Mon, 21 Sep 2020 14:40:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C45382311D for ; Mon, 21 Sep 2020 14:40:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727338AbgIUOkS (ORCPT ); Mon, 21 Sep 2020 10:40:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43124 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727365AbgIUOkP (ORCPT ); Mon, 21 Sep 2020 10:40:15 -0400 X-Greylist: delayed 923 seconds by postgrey-1.37 at lindbergh.monkeyblade.net; Mon, 21 Sep 2020 07:40:15 PDT Received: from viti.kaiser.cx (viti.kaiser.cx [IPv6:2a01:238:43fe:e600:cd0c:bd4a:7a3:8e9f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3FAFCC061755 for ; Mon, 21 Sep 2020 07:40:15 -0700 (PDT) Received: from martin by viti.kaiser.cx with local (Exim 4.89) (envelope-from ) id 1kKMkI-0001QY-7F; Mon, 21 Sep 2020 16:24:46 +0200 Date: Mon, 21 Sep 2020 16:24:46 +0200 From: Martin Kaiser To: Jonathan Cameron Cc: linux-iio@vger.kernel.org, Andy Shevchenko , Jonathan Cameron Subject: Re: [PATCH 03/38] iio:potentiometer:max5432: Drop of_match_ptr and use generic fw accessors Message-ID: <20200921142446.qejv2uroxwcjfmxe@viti.kaiser.cx> References: <20200910173242.621168-1-jic23@kernel.org> <20200910173242.621168-4-jic23@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200910173242.621168-4-jic23@kernel.org> User-Agent: NeoMutt/20170113 (1.7.2) Sender: Martin Kaiser Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org Thus wrote Jonathan Cameron (jic23@kernel.org): > From: Jonathan Cameron > These prevent use of this driver with ACPI via PRP0001 and are > an example of an anti pattern I'm trying to remove from IIO. > Drop them to remove this restriction. > Also switch headers to reflect this change. > Signed-off-by: Jonathan Cameron > Cc: Martin Kaiser > --- > drivers/iio/potentiometer/max5432.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > diff --git a/drivers/iio/potentiometer/max5432.c b/drivers/iio/potentiometer/max5432.c > index 280de9c54471..aed3b6ab82a2 100644 > --- a/drivers/iio/potentiometer/max5432.c > +++ b/drivers/iio/potentiometer/max5432.c > @@ -11,8 +11,8 @@ > #include > #include > #include > -#include > -#include > +#include > +#include > /* All chip variants have 32 wiper positions. */ > #define MAX5432_MAX_POS 31 > @@ -100,7 +100,7 @@ static int max5432_probe(struct i2c_client *client, > data = iio_priv(indio_dev); > data->client = client; > - data->ohm = (unsigned long)of_device_get_match_data(dev); > + data->ohm = (unsigned long)device_get_match_data(dev); > indio_dev->info = &max5432_info; > indio_dev->channels = max5432_channels; > @@ -122,7 +122,7 @@ MODULE_DEVICE_TABLE(of, max5432_dt_ids); > static struct i2c_driver max5432_driver = { > .driver = { > .name = "max5432", > - .of_match_table = of_match_ptr(max5432_dt_ids), > + .of_match_table = max5432_dt_ids, > }, > .probe = max5432_probe, > }; > -- > 2.28.0 Looks good to me. Reviewed-by: Martin Kaiser