From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 96DA9C2D0A8 for ; Wed, 23 Sep 2020 20:54:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3609E2376E for ; Wed, 23 Sep 2020 20:54:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1600894458; bh=4W8tkVEnVbxByODEUPomYSterl2xwqTlOxfLZTbwLt0=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=swh8tww4oODflt+avtKcimpMR7dxSVzUSShzDcEhSDGZtTXO+7300Doq4S68H7GSv jQ3jVaAgR9pQZdnmO3w8eIn6CEA97LA+udZLsGkEsGYIwJNDutWdL+r6oxhMQZEcuW XLBy+k6bY54jDaUR6y8KLbAvkD/UizyM24lS2M3s= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726515AbgIWUyR (ORCPT ); Wed, 23 Sep 2020 16:54:17 -0400 Received: from mail.kernel.org ([198.145.29.99]:41812 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726265AbgIWUyR (ORCPT ); Wed, 23 Sep 2020 16:54:17 -0400 Received: from archlinux (cpc149474-cmbg20-2-0-cust94.5-4.cable.virginm.net [82.4.196.95]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 0FEFE214F1; Wed, 23 Sep 2020 20:54:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1600894456; bh=4W8tkVEnVbxByODEUPomYSterl2xwqTlOxfLZTbwLt0=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=bpKhHnhjyQreXsGYfaJ5ArX8UDxNgxTCpzvBIGlT6fcSULxC+13epxTa19yMiz7dk KoTinHrYH2aztpNLmskjxsSYucKSLpvVRmGbw9HXCOhoyq35Pr1kgGa2eMPtIzpIgn LpoX4sLVR15oFiAlxSdXYzEQ8OVgc7xarT8UHqD8= Date: Wed, 23 Sep 2020 21:54:12 +0100 From: Jonathan Cameron To: Wang ShaoBo Cc: , , , , , , , Subject: Re: [PATCH -next] iio: adc: stm32-dfsdm: Use devm_platform_get_and_ioremap_resource() Message-ID: <20200923215357.26f8959d@archlinux> In-Reply-To: <20200918083142.32816-1-bobo.shaobowang@huawei.com> References: <20200918083142.32816-1-bobo.shaobowang@huawei.com> X-Mailer: Claws Mail 3.17.6 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org On Fri, 18 Sep 2020 16:31:42 +0800 Wang ShaoBo wrote: > Make use of devm_platform_get_and_ioremap_resource() provided by > driver core platform instead of duplicated analogue, dev_err() is > removed because it has been done in devm_ioremap_resource(). > > Signed-off-by: Wang ShaoBo Applied to the togreg branch of iio.git and pushed out as testing for the autobuilders to see if they can find any problems. Thanks, Jonathan > --- > drivers/iio/adc/stm32-dfsdm-core.c | 11 ++++------- > 1 file changed, 4 insertions(+), 7 deletions(-) > > diff --git a/drivers/iio/adc/stm32-dfsdm-core.c b/drivers/iio/adc/stm32-dfsdm-core.c > index 0b8bea88b011..42a7377704a4 100644 > --- a/drivers/iio/adc/stm32-dfsdm-core.c > +++ b/drivers/iio/adc/stm32-dfsdm-core.c > @@ -226,16 +226,13 @@ static int stm32_dfsdm_parse_of(struct platform_device *pdev, > if (!node) > return -EINVAL; > > - res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > - if (!res) { > - dev_err(&pdev->dev, "Failed to get memory resource\n"); > - return -ENODEV; > - } > - priv->dfsdm.phys_base = res->start; > - priv->dfsdm.base = devm_ioremap_resource(&pdev->dev, res); > + priv->dfsdm.base = devm_platform_get_and_ioremap_resource(pdev, 0, > + &res); > if (IS_ERR(priv->dfsdm.base)) > return PTR_ERR(priv->dfsdm.base); > > + priv->dfsdm.phys_base = res->start; > + > /* > * "dfsdm" clock is mandatory for DFSDM peripheral clocking. > * "dfsdm" or "audio" clocks can be used as source clock for