Linux-IIO Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH] iio: dac: ad7303: remove platform data header
@ 2020-10-01 14:10 Alexandru Ardelean
  2020-10-10 17:04 ` Jonathan Cameron
  0 siblings, 1 reply; 2+ messages in thread
From: Alexandru Ardelean @ 2020-10-01 14:10 UTC (permalink / raw)
  To: linux-kernel, linux-iio; +Cc: jic23, Alexandru Ardelean

The information in the ad7303 platform_data header is unused, so it's dead
code.
This change removes it and it's inclusion from the driver.

Signed-off-by: Alexandru Ardelean <alexandru.ardelean@analog.com>
---
 drivers/iio/dac/ad7303.c             |  2 --
 include/linux/platform_data/ad7303.h | 20 --------------------
 2 files changed, 22 deletions(-)
 delete mode 100644 include/linux/platform_data/ad7303.h

diff --git a/drivers/iio/dac/ad7303.c b/drivers/iio/dac/ad7303.c
index 2e46def9d8ee..dbb4645ab6b1 100644
--- a/drivers/iio/dac/ad7303.c
+++ b/drivers/iio/dac/ad7303.c
@@ -17,8 +17,6 @@
 #include <linux/iio/iio.h>
 #include <linux/iio/sysfs.h>
 
-#include <linux/platform_data/ad7303.h>
-
 #define AD7303_CFG_EXTERNAL_VREF BIT(15)
 #define AD7303_CFG_POWER_DOWN(ch) BIT(11 + (ch))
 #define AD7303_CFG_ADDR_OFFSET	10
diff --git a/include/linux/platform_data/ad7303.h b/include/linux/platform_data/ad7303.h
deleted file mode 100644
index c2bd0a13bea1..000000000000
--- a/include/linux/platform_data/ad7303.h
+++ /dev/null
@@ -1,20 +0,0 @@
-/* SPDX-License-Identifier: GPL-2.0-only */
-/*
- * Analog Devices AD7303 DAC driver
- *
- * Copyright 2013 Analog Devices Inc.
- */
-
-#ifndef __IIO_ADC_AD7303_H__
-#define __IIO_ADC_AD7303_H__
-
-/**
- * struct ad7303_platform_data - AD7303 platform data
- * @use_external_ref: If set to true use an external voltage reference connected
- * to the REF pin, otherwise use the internal reference derived from Vdd.
- */
-struct ad7303_platform_data {
-	bool use_external_ref;
-};
-
-#endif
-- 
2.17.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] iio: dac: ad7303: remove platform data header
  2020-10-01 14:10 [PATCH] iio: dac: ad7303: remove platform data header Alexandru Ardelean
@ 2020-10-10 17:04 ` Jonathan Cameron
  0 siblings, 0 replies; 2+ messages in thread
From: Jonathan Cameron @ 2020-10-10 17:04 UTC (permalink / raw)
  To: Alexandru Ardelean; +Cc: linux-kernel, linux-iio

On Thu, 1 Oct 2020 17:10:04 +0300
Alexandru Ardelean <alexandru.ardelean@analog.com> wrote:

> The information in the ad7303 platform_data header is unused, so it's dead
> code.
> This change removes it and it's inclusion from the driver.
> 
> Signed-off-by: Alexandru Ardelean <alexandru.ardelean@analog.com>
Applied.

Thanks,

Jonathan
> ---
>  drivers/iio/dac/ad7303.c             |  2 --
>  include/linux/platform_data/ad7303.h | 20 --------------------
>  2 files changed, 22 deletions(-)
>  delete mode 100644 include/linux/platform_data/ad7303.h
> 
> diff --git a/drivers/iio/dac/ad7303.c b/drivers/iio/dac/ad7303.c
> index 2e46def9d8ee..dbb4645ab6b1 100644
> --- a/drivers/iio/dac/ad7303.c
> +++ b/drivers/iio/dac/ad7303.c
> @@ -17,8 +17,6 @@
>  #include <linux/iio/iio.h>
>  #include <linux/iio/sysfs.h>
>  
> -#include <linux/platform_data/ad7303.h>
> -
>  #define AD7303_CFG_EXTERNAL_VREF BIT(15)
>  #define AD7303_CFG_POWER_DOWN(ch) BIT(11 + (ch))
>  #define AD7303_CFG_ADDR_OFFSET	10
> diff --git a/include/linux/platform_data/ad7303.h b/include/linux/platform_data/ad7303.h
> deleted file mode 100644
> index c2bd0a13bea1..000000000000
> --- a/include/linux/platform_data/ad7303.h
> +++ /dev/null
> @@ -1,20 +0,0 @@
> -/* SPDX-License-Identifier: GPL-2.0-only */
> -/*
> - * Analog Devices AD7303 DAC driver
> - *
> - * Copyright 2013 Analog Devices Inc.
> - */
> -
> -#ifndef __IIO_ADC_AD7303_H__
> -#define __IIO_ADC_AD7303_H__
> -
> -/**
> - * struct ad7303_platform_data - AD7303 platform data
> - * @use_external_ref: If set to true use an external voltage reference connected
> - * to the REF pin, otherwise use the internal reference derived from Vdd.
> - */
> -struct ad7303_platform_data {
> -	bool use_external_ref;
> -};
> -
> -#endif


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, back to index

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-01 14:10 [PATCH] iio: dac: ad7303: remove platform data header Alexandru Ardelean
2020-10-10 17:04 ` Jonathan Cameron

Linux-IIO Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-iio/0 linux-iio/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-iio linux-iio/ https://lore.kernel.org/linux-iio \
		linux-iio@vger.kernel.org
	public-inbox-index linux-iio

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-iio


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git