From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DE4D2C433DF for ; Sat, 10 Oct 2020 23:08:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id ACA0F2075E for ; Sat, 10 Oct 2020 23:08:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1602371329; bh=s083QnhbFPBYesVOpB+LThFjG2NY4u/5rmNI7PXW9MY=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=OsanwU49BirsnU+pt9gwx/D5MZeIOaLKEtMyY5PPiE2q6r0NtkYmV1LFyFX+Xel1s MOeFyvlzG6OVYi23ayKJRP12LH7qlNNTJRktmXJ6WRvARGfqgVWAhe3RhHNVldCZcM iZpOoY+59NuOLPniiBRBv5GhhMforhQxDHTlvxTE= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390365AbgJJW5G (ORCPT ); Sat, 10 Oct 2020 18:57:06 -0400 Received: from mail.kernel.org ([198.145.29.99]:53940 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731820AbgJJTh1 (ORCPT ); Sat, 10 Oct 2020 15:37:27 -0400 Received: from archlinux (cpc149474-cmbg20-2-0-cust94.5-4.cable.virginm.net [82.4.196.95]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 43BC822228; Sat, 10 Oct 2020 17:04:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1602349445; bh=s083QnhbFPBYesVOpB+LThFjG2NY4u/5rmNI7PXW9MY=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=O9hA6G3nCtxHz/jKYKu9PGVC9m4pvcLZCbb7lTdJgOJAgA7ntjd98+TlSxODIrSgX veE4QHsJRTm3cqlmwrPAo1r41Wr+Pii4gz/85aaDC+gsuZpqqaJCF1a/ELDKomW4M7 0Qyzh8NFsFAzNssfMqtsLv0hL2MYnAM9hdpMKKgo= Date: Sat, 10 Oct 2020 18:04:00 +0100 From: Jonathan Cameron To: Alexandru Ardelean Cc: , Subject: Re: [PATCH] iio: dac: ad7303: remove platform data header Message-ID: <20201010180400.09658b3c@archlinux> In-Reply-To: <20201001141004.53846-1-alexandru.ardelean@analog.com> References: <20201001141004.53846-1-alexandru.ardelean@analog.com> X-Mailer: Claws Mail 3.17.7 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org On Thu, 1 Oct 2020 17:10:04 +0300 Alexandru Ardelean wrote: > The information in the ad7303 platform_data header is unused, so it's dead > code. > This change removes it and it's inclusion from the driver. > > Signed-off-by: Alexandru Ardelean Applied. Thanks, Jonathan > --- > drivers/iio/dac/ad7303.c | 2 -- > include/linux/platform_data/ad7303.h | 20 -------------------- > 2 files changed, 22 deletions(-) > delete mode 100644 include/linux/platform_data/ad7303.h > > diff --git a/drivers/iio/dac/ad7303.c b/drivers/iio/dac/ad7303.c > index 2e46def9d8ee..dbb4645ab6b1 100644 > --- a/drivers/iio/dac/ad7303.c > +++ b/drivers/iio/dac/ad7303.c > @@ -17,8 +17,6 @@ > #include > #include > > -#include > - > #define AD7303_CFG_EXTERNAL_VREF BIT(15) > #define AD7303_CFG_POWER_DOWN(ch) BIT(11 + (ch)) > #define AD7303_CFG_ADDR_OFFSET 10 > diff --git a/include/linux/platform_data/ad7303.h b/include/linux/platform_data/ad7303.h > deleted file mode 100644 > index c2bd0a13bea1..000000000000 > --- a/include/linux/platform_data/ad7303.h > +++ /dev/null > @@ -1,20 +0,0 @@ > -/* SPDX-License-Identifier: GPL-2.0-only */ > -/* > - * Analog Devices AD7303 DAC driver > - * > - * Copyright 2013 Analog Devices Inc. > - */ > - > -#ifndef __IIO_ADC_AD7303_H__ > -#define __IIO_ADC_AD7303_H__ > - > -/** > - * struct ad7303_platform_data - AD7303 platform data > - * @use_external_ref: If set to true use an external voltage reference connected > - * to the REF pin, otherwise use the internal reference derived from Vdd. > - */ > -struct ad7303_platform_data { > - bool use_external_ref; > -}; > - > -#endif