Linux-IIO Archive on lore.kernel.org
 help / color / Atom feed
From: Tomas Novotny <tomas@novotny.cz>
To: Jonathan Cameron <jic23@kernel.org>
Cc: linux-iio@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
	Jonathan Cameron <Jonathan.Cameron@huawei.com>
Subject: Re: [PATCH 20/29] dt-bindings:iio:dac:microchip,mcp4725 yaml conversion
Date: Mon, 12 Oct 2020 16:02:30 +0200
Message-ID: <20201012160230.7a0c5eb8@tomas.local.tbs-biometrics.cz> (raw)
In-Reply-To: <20201011170749.243680-21-jic23@kernel.org>

Hi Jonathan,

On Sun, 11 Oct 2020 18:07:40 +0100
Jonathan Cameron <jic23@kernel.org> wrote:

> From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> 
> I'm not sure vdd-supply absolutely has to be provided if vref-supply
> is, but as the previous binding docs stated it was required it seems
> reasonable to leave it as such.

Good catch. Vdd is useless on MCP4726 if Vref is specified. The driver
requires Vdd...

How to proceed there?

Thanks,

Tomas

> Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> Cc:  Tomas Novotny <tomas@novotny.cz>
> ---
>  .../devicetree/bindings/iio/dac/mcp4725.txt   | 35 ---------
>  .../bindings/iio/dac/microchip,mcp4725.yaml   | 71 +++++++++++++++++++
>  2 files changed, 71 insertions(+), 35 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/iio/dac/mcp4725.txt b/Documentation/devicetree/bindings/iio/dac/mcp4725.txt
> deleted file mode 100644
> index 1bc6c093fbfe..000000000000
> --- a/Documentation/devicetree/bindings/iio/dac/mcp4725.txt
> +++ /dev/null
> @@ -1,35 +0,0 @@
> -Microchip mcp4725 and mcp4726 DAC device driver
> -
> -Required properties:
> -	- compatible: Must be "microchip,mcp4725" or "microchip,mcp4726"
> -	- reg: Should contain the DAC I2C address
> -	- vdd-supply: Phandle to the Vdd power supply. This supply is used as a
> -	  voltage reference on mcp4725. It is used as a voltage reference on
> -	  mcp4726 if there is no vref-supply specified.
> -
> -Optional properties (valid only for mcp4726):
> -	- vref-supply: Optional phandle to the Vref power supply. Vref pin is
> -	  used as a voltage reference when this supply is specified.
> -	- microchip,vref-buffered: Boolean to enable buffering of the external
> -	  Vref pin. This boolean is not valid without the vref-supply. Quoting
> -	  the datasheet: This is offered in cases where the reference voltage
> -	  does not have the current capability not to drop its voltage when
> -	  connected to the internal resistor ladder circuit.
> -
> -Examples:
> -
> -	/* simple mcp4725 */
> -	mcp4725@60 {
> -		compatible = "microchip,mcp4725";
> -		reg = <0x60>;
> -		vdd-supply = <&vdac_vdd>;
> -	};
> -
> -	/* mcp4726 with the buffered external reference voltage */
> -	mcp4726@60 {
> -		compatible = "microchip,mcp4726";
> -		reg = <0x60>;
> -		vdd-supply = <&vdac_vdd>;
> -		vref-supply = <&vdac_vref>;
> -		microchip,vref-buffered;
> -	};
> diff --git a/Documentation/devicetree/bindings/iio/dac/microchip,mcp4725.yaml b/Documentation/devicetree/bindings/iio/dac/microchip,mcp4725.yaml
> new file mode 100644
> index 000000000000..271998610ceb
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/dac/microchip,mcp4725.yaml
> @@ -0,0 +1,71 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/iio/dac/microchip,mcp4725.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Microchip mcp4725 and mcp4726 DAC
> +
> +maintainers:
> +  - Tomas Novotny <tomas@novotny.cz>
> +
> +properties:
> +  compatible:
> +    enum:
> +      - microchip,mcp4725
> +      - microchip,mcp4726
> +
> +  reg:
> +    maxItems: 1
> +
> +  vdd-supply:
> +    description: |
> +      Provides both power and acts as the reference supply on the mcp4725.
> +      For the mcp4726 it will be used as the reference voltage if vref-supply
> +      is not provided.
> +
> +  vref-supply:
> +    description:
> +      Vref pin is used as a voltage reference when this supply is specified.
> +
> +  microchip,vref-buffered:
> +    type: boolean
> +    description: |
> +      Enable buffering of the external Vref pin. This boolean is not valid
> +      without the vref-supply. Quoting the datasheet: This is offered in
> +      cases where the reference voltage does not have the current
> +      capability not to drop its voltage when connected to the internal
> +      resistor ladder circuit.
> +
> +allOf:
> +  - if:
> +      not:
> +        properties:
> +          compatible:
> +            contains:
> +              const: microchip,mcp4726
> +    then:
> +      properties:
> +        vref-supply: false
> +        microchip,vref-buffered: false
> +
> +required:
> +  - compatible
> +  - reg
> +  - vdd-supply
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    i2c {
> +        #address-cells = <1>;
> +        #size-cells = <0>;
> +
> +        mcp4725@60 {
> +            compatible = "microchip,mcp4725";
> +            reg = <0x60>;
> +            vdd-supply = <&vdac_vdd>;
> +        };
> +    };
> +...

  reply index

Thread overview: 62+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-11 17:07 [PATCH 00/29] dt-bindings:iio: Another set of yaml conversions Jonathan Cameron
2020-10-11 17:07 ` [PATCH 01/29] dt-bindings:iio:humidity:hdc100x Drop separate doc + add to trivial-devices Jonathan Cameron
2020-10-12 16:29   ` Matt Ranostay
2020-10-11 17:07 ` [PATCH 02/29] dt-bindings:iio:humidity:htu21 " Jonathan Cameron
2020-10-11 17:07 ` [PATCH 03/29] dt-bindings:iio:humidity:st,hts221 yaml conversion Jonathan Cameron
2020-10-11 17:07 ` [PATCH 04/29] dt-bindings:iio:humidity:dht11 " Jonathan Cameron
2020-10-11 17:52   ` Harald Geyer
2020-10-12 14:29     ` Jonathan Cameron
2020-10-11 17:07 ` [PATCH 05/29] dt-bindings:iio:pressure:ms5637 Drop separate doc + add to trivial-devices Jonathan Cameron
2020-10-11 17:07 ` [PATCH 06/29] dt-bindings:iio:pressure:murata,zpa2326 yaml conversion Jonathan Cameron
2020-10-11 17:07 ` [PATCH 07/29] dt-bindings:iio:pressure:meas,ms5611 " Jonathan Cameron
2020-10-11 17:07 ` [PATCH 08/29] dt-bindings:iio:pressure:hoperf,hp03 " Jonathan Cameron
2020-10-12 13:06   ` Rob Herring
2020-10-12 14:31     ` Jonathan Cameron
2020-10-11 17:07 ` [PATCH 09/29] dt-bindings:iio:proximity:semtech,sx9500 " Jonathan Cameron
2020-10-11 17:07 ` [PATCH 10/29] dt-bindings:iio:proximity:st,vl53l0x " Jonathan Cameron
2020-10-11 17:07 ` [PATCH 11/29] dt-bindings:iio:proximity:ams,as3935 " Jonathan Cameron
2020-10-12 16:37   ` Matt Ranostay
2020-10-11 17:07 ` [PATCH 12/29] dt-bindings:iio:dac:ti,dac5571 " Jonathan Cameron
2020-10-11 17:47   ` Sean Nyekjaer
2020-10-18  9:58     ` Jonathan Cameron
2020-10-18 15:06       ` Sean Nyekjaer
2020-10-11 17:07 ` [PATCH 13/29] dt-bindings:iio:dac:ti,dac7311 " Jonathan Cameron
2020-10-11 17:07 ` [PATCH 14/29] dt-bindings:iio:dac:ti,dac7512 " Jonathan Cameron
2020-10-11 17:07 ` [PATCH 15/29] dt-bindings:iio:dac:ti,dac7612 " Jonathan Cameron
2020-10-15  8:49   ` Ricardo Ribalda Delgado
2020-10-18 17:41     ` Jonathan Cameron
2020-10-11 17:07 ` [PATCH 16/29] dt-bindings:iio:dac:ti,dac082s085 " Jonathan Cameron
2020-10-28 20:31   ` Lukas Wunner
2020-10-29 15:50     ` Jonathan Cameron
2020-10-29 19:10       ` Lukas Wunner
2020-10-31 11:02         ` Jonathan Cameron
2020-10-31 13:07       ` Jonathan Cameron
2020-10-11 17:07 ` [PATCH 17/29] dt-bindings:iio:dac:adi,ad7303 " Jonathan Cameron
2020-10-11 17:13   ` Lars-Peter Clausen
2020-10-18 17:43     ` Jonathan Cameron
2020-10-11 17:07 ` [PATCH 18/29] dt-bindings:iio:dac:maxim,ds4424 " Jonathan Cameron
2020-10-18 17:47   ` Jonathan Cameron
2020-10-11 17:07 ` [PATCH 19/29] dt-bindings:iio:dac:fsl,vf610-dac " Jonathan Cameron
2020-10-11 17:07 ` [PATCH 20/29] dt-bindings:iio:dac:microchip,mcp4725 " Jonathan Cameron
2020-10-12 14:02   ` Tomas Novotny [this message]
2020-10-12 14:39     ` Jonathan Cameron
2020-10-14  8:57       ` Tomas Novotny
2020-10-11 17:07 ` [PATCH 21/29] dt-bindings:iio:dac:maxim,max5821 " Jonathan Cameron
2020-10-11 17:07 ` [PATCH 22/29] dt-bindings:iio:dac:nxp,lpc1850-dac " Jonathan Cameron
2020-10-18 17:52   ` Jonathan Cameron
2020-10-18 18:44   ` Vladimir Zapolskiy
2020-10-11 17:07 ` [PATCH 23/29] dt-bindings:iio:dac:adi,ad5758 " Jonathan Cameron
2020-10-11 17:07 ` [PATCH 24/29] dt-bindings:iio:temperature:melexis,mlx90614 " Jonathan Cameron
2020-10-11 21:00   ` Crt Mori
2020-10-12  8:00     ` Crt Mori
2020-10-12 14:25       ` Jonathan Cameron
2020-10-11 17:07 ` [PATCH 25/29] dt-bindings:iio:temperature:melexis,mlx90632 conversion to yaml Jonathan Cameron
2020-10-11 21:01   ` Crt Mori
2020-10-11 17:07 ` [PATCH 26/29] dt-bindings:iio:temperature:meas,tsys01 move to trivial-devices.yaml Jonathan Cameron
2020-10-11 17:07 ` [PATCH 27/29] dt-bindings:iio:temperature:maxim,max31856 yaml conversion Jonathan Cameron
2020-10-11 17:07 ` [PATCH 28/29] dt-bindings:iio:temperature:maxim_thermocouple.txt to maxim,max31855k.yaml Jonathan Cameron
2020-10-12 16:40   ` Matt Ranostay
2020-10-11 17:07 ` [PATCH 29/29] dt-bindings:iio:temperature:ti,tmp07 yaml conversion Jonathan Cameron
2020-10-13  8:22   ` Manivannan Sadhasivam
2020-10-12 13:20 ` [PATCH 00/29] dt-bindings:iio: Another set of yaml conversions Rob Herring
2020-10-12 14:33   ` Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201012160230.7a0c5eb8@tomas.local.tbs-biometrics.cz \
    --to=tomas@novotny.cz \
    --cc=Jonathan.Cameron@huawei.com \
    --cc=jic23@kernel.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-IIO Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-iio/0 linux-iio/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-iio linux-iio/ https://lore.kernel.org/linux-iio \
		linux-iio@vger.kernel.org
	public-inbox-index linux-iio

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-iio


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git