From: Matthew Wilcox <willy@infradead.org>
To: trix@redhat.com
Cc: linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org,
clang-built-linux@googlegroups.com, linux-iio@vger.kernel.org,
nouveau@lists.freedesktop.org, storagedev@microchip.com,
dri-devel@lists.freedesktop.org,
virtualization@lists.linux-foundation.org,
keyrings@vger.kernel.org, linux-mtd@lists.infradead.org,
ath10k@lists.infradead.org, MPT-FusionLinux.pdl@broadcom.com,
linux-stm32@st-md-mailman.stormreply.com,
usb-storage@lists.one-eyed-alien.net,
linux-watchdog@vger.kernel.org, devel@driverdev.osuosl.org,
linux-samsung-soc@vger.kernel.org, linux-scsi@vger.kernel.org,
linux-nvdimm@lists.01.org, amd-gfx@lists.freedesktop.org,
linux-acpi@vger.kernel.org, intel-wired-lan@lists.osuosl.org,
industrypack-devel@lists.sourceforge.net,
linux-pci@vger.kernel.org, spice-devel@lists.freedesktop.org,
linux-media@vger.kernel.org, linux-serial@vger.kernel.org,
linux-nfc@lists.01.org, linux-pm@vger.kernel.org,
linux-can@vger.kernel.org, linux-block@vger.kernel.org,
linux-gpio@vger.kernel.org, xen-devel@lists.xenproject.org,
linux-amlogic@lists.infradead.org,
openipmi-developer@lists.sourceforge.net,
platform-driver-x86@vger.kernel.org,
linux-integrity@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linux-edac@vger.kernel.org,
netdev@vger.kernel.org, linux-usb@vger.kernel.org,
linux-wireless@vger.kernel.org,
linux-security-module@vger.kernel.org,
linux-crypto@vger.kernel.org, patches@opensource.cirrus.com,
bpf@vger.kernel.org, ocfs2-devel@oss.oracle.com,
linux-power@fi.rohmeurope.com
Subject: Re: [Ocfs2-devel] [RFC] treewide: cleanup unreachable breaks
Date: Sun, 18 Oct 2020 19:59:43 +0100 [thread overview]
Message-ID: <20201018185943.GM20115@casper.infradead.org> (raw)
In-Reply-To: <20201017160928.12698-1-trix@redhat.com>
On Sat, Oct 17, 2020 at 09:09:28AM -0700, trix@redhat.com wrote:
> clang has a number of useful, new warnings see
> https://urldefense.com/v3/__https://clang.llvm.org/docs/DiagnosticsReference.html__;!!GqivPVa7Brio!Krxz78O3RKcB9JBMVo_F98FupVhj_jxX60ddN6tKGEbv_cnooXc1nnBmchm-e_O9ieGnyQ$
Please get your IT department to remove that stupidity. If you can't,
please send email from a non-Red Hat email address.
I don't understand why this is a useful warning to fix. What actual
problem is caused by the code below?
> return and break
>
> switch (c->x86_vendor) {
> case X86_VENDOR_INTEL:
> intel_p5_mcheck_init(c);
> return 1;
> - break;
Sure, it's unnecessary, but it's not masking a bug. It's not unclear.
Why do we want to enable this warning?
next prev parent reply other threads:[~2020-10-18 19:00 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-17 16:09 [RFC] treewide: cleanup unreachable breaks trix
2020-10-17 16:24 ` Martin Blumenstingl
2020-10-17 16:24 ` Joe Perches
2020-10-17 18:21 ` [Cocci] " Julia Lawall
2020-10-17 19:00 ` Joe Perches
2020-10-17 21:01 ` Dan Williams
2020-10-18 5:43 ` Greg KH
2020-10-18 14:04 ` Tom Rix
2020-10-19 19:42 ` Nick Desaulniers
2020-10-19 23:05 ` Jason Gunthorpe
2020-10-20 14:09 ` Tom Rix
2020-10-20 8:47 ` [Ocfs2-devel] " John Haxby
2020-10-20 13:55 ` Tom Rix
2020-10-20 18:42 ` Joe Perches
2020-10-18 9:29 ` Hans de Goede
2020-10-18 18:59 ` Matthew Wilcox [this message]
2020-10-18 19:06 ` [Ocfs2-devel] " Joe Perches
2020-10-18 19:13 ` James Bottomley
2020-10-18 19:16 ` Matthew Wilcox
2020-10-18 19:17 ` James Bottomley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201018185943.GM20115@casper.infradead.org \
--to=willy@infradead.org \
--cc=MPT-FusionLinux.pdl@broadcom.com \
--cc=alsa-devel@alsa-project.org \
--cc=amd-gfx@lists.freedesktop.org \
--cc=ath10k@lists.infradead.org \
--cc=bpf@vger.kernel.org \
--cc=clang-built-linux@googlegroups.com \
--cc=devel@driverdev.osuosl.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=industrypack-devel@lists.sourceforge.net \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=keyrings@vger.kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-can@vger.kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-edac@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-nfc@lists.01.org \
--cc=linux-nvdimm@lists.01.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-power@fi.rohmeurope.com \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=linux-usb@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nouveau@lists.freedesktop.org \
--cc=ocfs2-devel@oss.oracle.com \
--cc=openipmi-developer@lists.sourceforge.net \
--cc=patches@opensource.cirrus.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=spice-devel@lists.freedesktop.org \
--cc=storagedev@microchip.com \
--cc=trix@redhat.com \
--cc=usb-storage@lists.one-eyed-alien.net \
--cc=virtualization@lists.linux-foundation.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).