From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.5 required=3.0 tests=BAYES_00,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EC391C4167B for ; Sun, 13 Dec 2020 13:21:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C22B622EBE for ; Sun, 13 Dec 2020 13:21:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2406773AbgLMNVT (ORCPT ); Sun, 13 Dec 2020 08:21:19 -0500 Received: from mail.kernel.org ([198.145.29.99]:51424 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2406755AbgLMNVK (ORCPT ); Sun, 13 Dec 2020 08:21:10 -0500 Received: from archlinux (cpc108967-cmbg20-2-0-cust86.5-4.cable.virginm.net [81.101.6.87]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 4482823105; Sun, 13 Dec 2020 13:20:28 +0000 (UTC) Date: Sun, 13 Dec 2020 13:20:24 +0000 From: Jonathan Cameron To: linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-i2c@vger.kernel.org Cc: Rob Herring , Wolfram Sang , Peter Rosin , Jonathan Cameron , Linus Walleij , Rob Herring Subject: Re: [PATCH v2 3/3] dt-bindings:iio:gyro:invensense,mpu3050: txt to yaml format conversion. Message-ID: <20201213132024.24cddc1a@archlinux> In-Reply-To: <20201128173343.390165-4-jic23@kernel.org> References: <20201128173343.390165-1-jic23@kernel.org> <20201128173343.390165-4-jic23@kernel.org> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org On Sat, 28 Nov 2020 17:33:43 +0000 Jonathan Cameron wrote: > From: Jonathan Cameron > > Very similar to the mpu6050 binding. > Only unusual element is the i2c-gate section. > Example tweaked a little to include a real device behind the gate. > > As Rob Herring suggested, dropped use of explicit i2c-gate yaml > binding in favour of just using the i2c-controller.yaml binding > directly. > > Signed-off-by: Jonathan Cameron > Reviewed-by: Linus Walleij > Reviewed-by: Rob Herring > Link: https://lore.kernel.org/r/20201031181801.742585-4-jic23@kernel.org Applied. Thanks, Jonathan > --- > .../iio/gyroscope/invensense,mpu3050.txt | 45 ------------ > .../iio/gyroscope/invensense,mpu3050.yaml | 70 +++++++++++++++++++ > 2 files changed, 70 insertions(+), 45 deletions(-) > > diff --git a/Documentation/devicetree/bindings/iio/gyroscope/invensense,mpu3050.txt b/Documentation/devicetree/bindings/iio/gyroscope/invensense,mpu3050.txt > deleted file mode 100644 > index 233fe207aded..000000000000 > --- a/Documentation/devicetree/bindings/iio/gyroscope/invensense,mpu3050.txt > +++ /dev/null > @@ -1,45 +0,0 @@ > -Invensense MPU-3050 Gyroscope device tree bindings > - > -Required properties: > - - compatible : should be "invensense,mpu3050" > - - reg : the I2C address of the sensor > - > -Optional properties: > - - interrupts : interrupt mapping for the trigger interrupt from the > - internal oscillator. The following IRQ modes are supported: > - IRQ_TYPE_EDGE_RISING, IRQ_TYPE_EDGE_FALLING, IRQ_TYPE_LEVEL_HIGH and > - IRQ_TYPE_LEVEL_LOW. The driver should detect and configure the hardware > - for the desired interrupt type. > - - vdd-supply : supply regulator for the main power voltage. > - - vlogic-supply : supply regulator for the signal voltage. > - - mount-matrix : see iio/mount-matrix.txt > - > -Optional subnodes: > - - The MPU-3050 will pass through and forward the I2C signals from the > - incoming I2C bus, alternatively drive traffic to a slave device (usually > - an accelerometer) on its own initiative. Therefore is supports a subnode > - i2c gate node. For details see: i2c/i2c-gate.txt > - > -Example: > - > -mpu3050@68 { > - compatible = "invensense,mpu3050"; > - reg = <0x68>; > - interrupt-parent = <&foo>; > - interrupts = <12 IRQ_TYPE_EDGE_FALLING>; > - vdd-supply = <&bar>; > - vlogic-supply = <&baz>; > - > - /* External I2C interface */ > - i2c-gate { > - #address-cells = <1>; > - #size-cells = <0>; > - > - fnord@18 { > - compatible = "fnord"; > - reg = <0x18>; > - interrupt-parent = <&foo>; > - interrupts = <13 IRQ_TYPE_EDGE_FALLING>; > - }; > - }; > -}; > diff --git a/Documentation/devicetree/bindings/iio/gyroscope/invensense,mpu3050.yaml b/Documentation/devicetree/bindings/iio/gyroscope/invensense,mpu3050.yaml > new file mode 100644 > index 000000000000..7e2accc3d5ce > --- /dev/null > +++ b/Documentation/devicetree/bindings/iio/gyroscope/invensense,mpu3050.yaml > @@ -0,0 +1,70 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/iio/gyroscope/invensense,mpu3050.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Invensense MPU-3050 Gyroscope > + > +maintainers: > + - Linus Walleij > + > +properties: > + compatible: > + const: invensense,mpu3050 > + > + reg: > + maxItems: 1 > + > + vdd-supply: true > + > + vlogic-supply: true > + > + interrupts: > + minItems: 1 > + description: > + Interrupt mapping for the trigger interrupt from the internal oscillator. > + > + mount-matrix: true > + > + i2c-gate: > + $ref: /schemas/i2c/i2c-controller.yaml > + unevaluatedProperties: false > + description: | > + The MPU-3050 will pass through and forward the I2C signals from the > + incoming I2C bus, alternatively drive traffic to a slave device (usually > + an accelerometer) on its own initiative. Therefore is supports an > + i2c-gate subnode. > + > +required: > + - compatible > + - reg > + > +additionalProperties: false > + > +examples: > + - | > + #include > + i2c { > + #address-cells = <1>; > + #size-cells = <0>; > + gyroscope@68 { > + compatible = "invensense,mpu3050"; > + reg = <0x68>; > + interrupt-parent = <&foo>; > + interrupts = <12 IRQ_TYPE_EDGE_FALLING>; > + vdd-supply = <&bar>; > + vlogic-supply = <&baz>; > + > + i2c-gate { > + #address-cells = <1>; > + #size-cells = <0>; > + > + magnetometer@c { > + compatible = "ak,ak8975"; > + reg = <0x0c>; > + }; > + }; > + }; > + }; > +...