Hi Mike, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on iio/togreg] [also build test WARNING on v5.11-rc4 next-20210120] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Mike-Looijmans/dt-bindings-iio-accel-Add-bmi088-accelerometer-bindings/20210120-152728 base: https://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio.git togreg config: m68k-allmodconfig (attached as .config) compiler: m68k-linux-gcc (GCC) 9.3.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/0day-ci/linux/commit/f17da22f54858ae666a714de19463d6c29dbdfc6 git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Mike-Looijmans/dt-bindings-iio-accel-Add-bmi088-accelerometer-bindings/20210120-152728 git checkout f17da22f54858ae666a714de19463d6c29dbdfc6 # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=m68k If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot All warnings (new ones prefixed by >>): In file included from include/linux/kernel.h:10, from include/linux/list.h:9, from include/linux/module.h:12, from drivers/iio/accel/bmi088-accel-spi.c:9: include/linux/scatterlist.h: In function 'sg_set_buf': arch/m68k/include/asm/page_mm.h:174:49: warning: ordered comparison of pointer with null pointer [-Wextra] 174 | #define virt_addr_valid(kaddr) ((void *)(kaddr) >= (void *)PAGE_OFFSET && (void *)(kaddr) < high_memory) | ^~ include/linux/compiler.h:78:42: note: in definition of macro 'unlikely' 78 | # define unlikely(x) __builtin_expect(!!(x), 0) | ^ include/linux/scatterlist.h:137:2: note: in expansion of macro 'BUG_ON' 137 | BUG_ON(!virt_addr_valid(buf)); | ^~~~~~ include/linux/scatterlist.h:137:10: note: in expansion of macro 'virt_addr_valid' 137 | BUG_ON(!virt_addr_valid(buf)); | ^~~~~~~~~~~~~~~ drivers/iio/accel/bmi088-accel-spi.c: At top level: >> drivers/iio/accel/bmi088-accel-spi.c:16:5: warning: no previous prototype for 'bmi088_regmap_spi_write' [-Wmissing-prototypes] 16 | int bmi088_regmap_spi_write(void *context, const void *data, size_t count) | ^~~~~~~~~~~~~~~~~~~~~~~ >> drivers/iio/accel/bmi088-accel-spi.c:24:5: warning: no previous prototype for 'bmi088_regmap_spi_read' [-Wmissing-prototypes] 24 | int bmi088_regmap_spi_read(void *context, const void *reg, | ^~~~~~~~~~~~~~~~~~~~~~ vim +/bmi088_regmap_spi_write +16 drivers/iio/accel/bmi088-accel-spi.c 15 > 16 int bmi088_regmap_spi_write(void *context, const void *data, size_t count) 17 { 18 struct spi_device *spi = context; 19 20 /* Write register is same as generic SPI */ 21 return spi_write(spi, data, count); 22 } 23 > 24 int bmi088_regmap_spi_read(void *context, const void *reg, 25 size_t reg_size, void *val, size_t val_size) 26 { 27 struct spi_device *spi = context; 28 u8 addr[2]; 29 30 addr[0] = *(u8 *)reg; 31 addr[0] |= BIT(7); /* Set RW = '1' */ 32 addr[1] = 0; /* Read requires a dummy byte transfer */ 33 34 return spi_write_then_read(spi, addr, sizeof(addr), val, val_size); 35 } 36 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org