From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9FEC3C433B4 for ; Wed, 12 May 2021 13:38:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 54AA1613DE for ; Wed, 12 May 2021 13:38:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230217AbhELNjL (ORCPT ); Wed, 12 May 2021 09:39:11 -0400 Received: from mail.kernel.org ([198.145.29.99]:47756 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230211AbhELNjL (ORCPT ); Wed, 12 May 2021 09:39:11 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 7EE4D61396; Wed, 12 May 2021 13:38:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1620826683; bh=1lksl1eacnjBQtDjg/GE+NvHJ8CroAsZSUZAvHuOXGo=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=o9q4gTNrgsLJmPaFcXAviTPJF8MWeifK3POcW3BFMcUFkX50Pj4U2I7I95/i5QTQg y3aY0ToN4fT8yaSHklLynB41mGH8KhEjh9qOzsGd6xTa65yj5WAFW8B7fhluR92qvO V5/XxpMaVPUWa2fwCXXtFiNXoW5583gL+cziWaFcJKvuQobHiLo5+KTWRyxQxpzJRB iriKlnqLzHw9Q+sdCi3mIRSIatiXDVhfNUkaYvg2pfO5DecWhl/LI2T1x9YIqw71VT 1C8ckLAlGyGHZTuDrNSKh2Mdd/hpH17jfzWtNgWjrOIHYdLr8shwcEMJTg6/qw0nt2 ZUaUEuwGSblyg== Date: Wed, 12 May 2021 15:37:57 +0200 From: Mauro Carvalho Chehab To: Jonathan Cameron Cc: linux-iio@vger.kernel.org, Julia Lawall , "Rafael J . Wysocki" , Jonathan Cameron Subject: Re: [PATCH 06/28] iio: accel: mma9551/3: Balance untime pm + use pm_runtime_resume_and_get() Message-ID: <20210512153757.22938ffb@coco.lan> In-Reply-To: <20210509113354.660190-7-jic23@kernel.org> References: <20210509113354.660190-1-jic23@kernel.org> <20210509113354.660190-7-jic23@kernel.org> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org Em Sun, 9 May 2021 12:33:32 +0100 Jonathan Cameron escreveu: > From: Jonathan Cameron > > Both these drivers call pm_runtime_put_no_idle() when the reference > count should already be zero as there is no matching get() > > Whilst here use pm_runtime_resume_and_get() rather than open coding. LGTM. Reviewed-by: Mauro Carvalho Chehab > Signed-off-by: Jonathan Cameron > --- > drivers/iio/accel/mma9551.c | 1 - > drivers/iio/accel/mma9551_core.c | 4 +--- > drivers/iio/accel/mma9553.c | 1 - > 3 files changed, 1 insertion(+), 5 deletions(-) > > diff --git a/drivers/iio/accel/mma9551.c b/drivers/iio/accel/mma9551.c > index 08a2303cc9df..4c359fb05480 100644 > --- a/drivers/iio/accel/mma9551.c > +++ b/drivers/iio/accel/mma9551.c > @@ -515,7 +515,6 @@ static int mma9551_remove(struct i2c_client *client) > > pm_runtime_disable(&client->dev); > pm_runtime_set_suspended(&client->dev); > - pm_runtime_put_noidle(&client->dev); > > mutex_lock(&data->mutex); > mma9551_set_device_state(data->client, false); > diff --git a/drivers/iio/accel/mma9551_core.c b/drivers/iio/accel/mma9551_core.c > index 666e7a04a7d7..fbf2e2c45678 100644 > --- a/drivers/iio/accel/mma9551_core.c > +++ b/drivers/iio/accel/mma9551_core.c > @@ -664,7 +664,7 @@ int mma9551_set_power_state(struct i2c_client *client, bool on) > int ret; > > if (on) > - ret = pm_runtime_get_sync(&client->dev); > + ret = pm_runtime_resume_and_get(&client->dev); > else { > pm_runtime_mark_last_busy(&client->dev); > ret = pm_runtime_put_autosuspend(&client->dev); > @@ -673,8 +673,6 @@ int mma9551_set_power_state(struct i2c_client *client, bool on) > if (ret < 0) { > dev_err(&client->dev, > "failed to change power state to %d\n", on); > - if (on) > - pm_runtime_put_noidle(&client->dev); > > return ret; > } > diff --git a/drivers/iio/accel/mma9553.c b/drivers/iio/accel/mma9553.c > index c15908faa381..ba3ecb3b57dc 100644 > --- a/drivers/iio/accel/mma9553.c > +++ b/drivers/iio/accel/mma9553.c > @@ -1154,7 +1154,6 @@ static int mma9553_remove(struct i2c_client *client) > > pm_runtime_disable(&client->dev); > pm_runtime_set_suspended(&client->dev); > - pm_runtime_put_noidle(&client->dev); > > mutex_lock(&data->mutex); > mma9551_set_device_state(data->client, false); Thanks, Mauro