From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CE899C433B4 for ; Wed, 12 May 2021 13:51:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8E072611CC for ; Wed, 12 May 2021 13:51:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231127AbhELNwx (ORCPT ); Wed, 12 May 2021 09:52:53 -0400 Received: from mail.kernel.org ([198.145.29.99]:53646 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230369AbhELNww (ORCPT ); Wed, 12 May 2021 09:52:52 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id CBABE611AD; Wed, 12 May 2021 13:51:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1620827504; bh=Y3GbUEKmpkP08nxm8oqVXxrSbb3YrIFDPj2GOmc1tB4=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=lSE8p94fHkaX+AgxE29SENiN9uJmf7gBQooxY7xMFp5sEVkcJNcFROY9EeEJJtxM4 6l4+bhiuvKJnv+xU+AubL5lbgypvDvrCU+1w2hYKBho1AarzzuUqX2FTiSIAhrEtqM 0WriEOL5YY7gta1yxzFb3wdI0jkfSZlZQE8Ut/kDd0qTswjgOYvNJfWXNUWM2mRfid 4dMe3qeQpr2vHiZicAKRmNasdwWhK/3kE9NpRhgWA3H6RTXfUoAQx5SFK/gZkebdWb ynBMRegYBInhFOvjJo1plcUnh9qH02LwiUU+X2r1FWSqAseDl1h3BFwuRcSHedhr1g At/PlriLJD7gg== Date: Wed, 12 May 2021 15:51:39 +0200 From: Mauro Carvalho Chehab To: Jonathan Cameron Cc: linux-iio@vger.kernel.org, Julia Lawall , "Rafael J . Wysocki" , Jonathan Cameron , Mike Looijmans Subject: Re: [PATCH 12/28] iio: accel: bmi088: Balance runtime pm + use pm_runtime_resume_and_get() Message-ID: <20210512155139.70a23906@coco.lan> In-Reply-To: <20210509113354.660190-13-jic23@kernel.org> References: <20210509113354.660190-1-jic23@kernel.org> <20210509113354.660190-13-jic23@kernel.org> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org Em Sun, 9 May 2021 12:33:38 +0100 Jonathan Cameron escreveu: > From: Jonathan Cameron > > The call to pm_runtime_put_noidle() in remove() is not balanced by a get so > drop it. > > Using pm_runtime_resume_and_get() allows for simple introduction of > error handling to allow for runtime resume failing. > > Signed-off-by: Jonathan Cameron > Cc: Mike Looijmans LGTM. Reviewed-by: Mauro Carvalho Chehab > --- > drivers/iio/accel/bmi088-accel-core.c | 26 ++++++++++++++++++++------ > 1 file changed, 20 insertions(+), 6 deletions(-) > > diff --git a/drivers/iio/accel/bmi088-accel-core.c b/drivers/iio/accel/bmi088-accel-core.c > index 61aaaf48c040..a06dae5c971d 100644 > --- a/drivers/iio/accel/bmi088-accel-core.c > +++ b/drivers/iio/accel/bmi088-accel-core.c > @@ -285,11 +285,17 @@ static int bmi088_accel_read_raw(struct iio_dev *indio_dev, > case IIO_CHAN_INFO_RAW: > switch (chan->type) { > case IIO_TEMP: > - pm_runtime_get_sync(dev); > + ret = pm_runtime_resume_and_get(dev); > + if (ret) > + return ret; > + > ret = bmi088_accel_get_temp(data, val); > goto out_read_raw_pm_put; > case IIO_ACCEL: > - pm_runtime_get_sync(dev); > + ret = pm_runtime_resume_and_get(dev); > + if (ret) > + return ret; > + > ret = iio_device_claim_direct_mode(indio_dev); > if (ret) > goto out_read_raw_pm_put; > @@ -319,7 +325,10 @@ static int bmi088_accel_read_raw(struct iio_dev *indio_dev, > *val = BMI088_ACCEL_TEMP_UNIT; > return IIO_VAL_INT; > case IIO_ACCEL: > - pm_runtime_get_sync(dev); > + ret = pm_runtime_resume_and_get(dev); > + if (ret) > + return ret; > + > ret = regmap_read(data->regmap, > BMI088_ACCEL_REG_ACC_RANGE, val); > if (ret) > @@ -334,7 +343,10 @@ static int bmi088_accel_read_raw(struct iio_dev *indio_dev, > return -EINVAL; > } > case IIO_CHAN_INFO_SAMP_FREQ: > - pm_runtime_get_sync(dev); > + ret = pm_runtime_resume_and_get(dev); > + if (ret) > + return ret; > + > ret = bmi088_accel_get_sample_freq(data, val, val2); > goto out_read_raw_pm_put; > default: > @@ -376,7 +388,10 @@ static int bmi088_accel_write_raw(struct iio_dev *indio_dev, > > switch (mask) { > case IIO_CHAN_INFO_SAMP_FREQ: > - pm_runtime_get_sync(dev); > + ret = pm_runtime_resume_and_get(dev); > + if (ret) > + return ret; > + > ret = bmi088_accel_set_sample_freq(data, val); > pm_runtime_mark_last_busy(dev); > pm_runtime_put_autosuspend(dev); > @@ -530,7 +545,6 @@ int bmi088_accel_core_remove(struct device *dev) > > pm_runtime_disable(dev); > pm_runtime_set_suspended(dev); > - pm_runtime_put_noidle(dev); > bmi088_accel_power_down(data); > > return 0; Thanks, Mauro