From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0AEB0C433B4 for ; Wed, 12 May 2021 14:19:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C9580613E6 for ; Wed, 12 May 2021 14:19:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230329AbhELOUd (ORCPT ); Wed, 12 May 2021 10:20:33 -0400 Received: from mail.kernel.org ([198.145.29.99]:47250 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230259AbhELOUc (ORCPT ); Wed, 12 May 2021 10:20:32 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 2B5E8611BE; Wed, 12 May 2021 14:19:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1620829164; bh=vrgO5y/1+UQCGdRb32dc7Ds63m0NMnwUoQlDMhELXlc=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=RQtatVDk+E+LVd7nkqFnUvr3slWwGzjPzOagwQlBpk2lozUlFHfZ4R/rWpXJqbty+ MqGx71lNUA53kenf7gNZEZSSknZ8AnaEImxXTacLiRX4nqIwcgZ+2DWpC/iAe1xytw WR3AjCdE2cEdO6MStCg6atDc0F4B/GCxc75ISrGG2EWEhCoPhA+PuwoKxEwiPAWPw7 WlEDTs0jKMfRX0n8zN/zEsazJ1Va9ctljokr3pBlJiyBvMgPv3ViBZNGUg+pD23P4z 1duVUOlq4o6q+LiD1wpX+ZoIFrm4bS7c+9oV0S+LRQ2TN3aTj466zzNOpOCdPZYZif zsvIeEMA6MH5w== Date: Wed, 12 May 2021 16:19:19 +0200 From: Mauro Carvalho Chehab To: Jonathan Cameron Cc: linux-iio@vger.kernel.org, Julia Lawall , "Rafael J . Wysocki" , Jonathan Cameron , Fabrice Gasnier Subject: Re: [PATCH 15/28] iio: adc: stm32-dfsdm: Use pm_runtime_resume_and_get() to replace open coding. Message-ID: <20210512161919.1a38419f@coco.lan> In-Reply-To: <20210509113354.660190-16-jic23@kernel.org> References: <20210509113354.660190-1-jic23@kernel.org> <20210509113354.660190-16-jic23@kernel.org> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org Em Sun, 9 May 2021 12:33:41 +0100 Jonathan Cameron escreveu: > From: Jonathan Cameron > > Found using coccicheck script under review at: > https://lore.kernel.org/lkml/20210427141946.2478411-1-Julia.Lawall@inria.fr/ > > This is a prequel to taking a closer look at the runtime pm in IIO drivers > in general. > > Signed-off-by: Jonathan Cameron > Cc: Fabrice Gasnier LGTM. Reviewed-by: Mauro Carvalho Chehab > --- > drivers/iio/adc/stm32-dfsdm-core.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/iio/adc/stm32-dfsdm-core.c b/drivers/iio/adc/stm32-dfsdm-core.c > index bb925a11c8ae..a627af9a825e 100644 > --- a/drivers/iio/adc/stm32-dfsdm-core.c > +++ b/drivers/iio/adc/stm32-dfsdm-core.c > @@ -135,11 +135,9 @@ int stm32_dfsdm_start_dfsdm(struct stm32_dfsdm *dfsdm) > int ret; > > if (atomic_inc_return(&priv->n_active_ch) == 1) { > - ret = pm_runtime_get_sync(dev); > - if (ret < 0) { > - pm_runtime_put_noidle(dev); > + ret = pm_runtime_resume_and_get(dev); > + if (ret < 0) > goto error_ret; > - } > > /* select clock source, e.g. 0 for "dfsdm" or 1 for "audio" */ > clk_src = priv->aclk ? 1 : 0; Thanks, Mauro