From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0F559C433B4 for ; Wed, 12 May 2021 14:20:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B640E611BE for ; Wed, 12 May 2021 14:20:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230329AbhELOVl (ORCPT ); Wed, 12 May 2021 10:21:41 -0400 Received: from mail.kernel.org ([198.145.29.99]:48608 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230284AbhELOVk (ORCPT ); Wed, 12 May 2021 10:21:40 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 0E55F613E6; Wed, 12 May 2021 14:20:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1620829232; bh=aNg98fVIvI1br03FboWK0cd/28T/jtxECuUI2R4liYk=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=GlwixM+GeO/nQApD8HvvFgVSIchL+5339d5+HA1iXXiKABbnEm1Myhq0b17M4g+5F a3U+fELjesLZddOkzLUj0uXbRSo6vxtJuFa8kGH7msiKsReLAkCty+dIL1FW960Ykm FBAFaQmumUgqnIdfXCWYhM+iMStO+cBdpsQD80yU8zX3BOHam7pxgEDl+yZiYqd08v MuKZ8o8GyDM8fYA4nBkiEJVgGYuX7vrCyzXqMcUvPizl2iHjakwuvHZh4GPL0PqGZ7 rysEQXqt/0xcYgwGeohDErTMOmVo4oLh17KB3agB5mQp3KG9PS+Mh4xxkqMPhB+lY8 hNgp6QumGixfQ== Date: Wed, 12 May 2021 16:20:26 +0200 From: Mauro Carvalho Chehab To: Jonathan Cameron Cc: linux-iio@vger.kernel.org, Julia Lawall , "Rafael J . Wysocki" , Jonathan Cameron , Fabrice Gasnier Subject: Re: [PATCH 16/28] iio: dac: stm32-dac: Use pm_runtime_resume_and_get() to replace open coding. Message-ID: <20210512162026.22e8bb3e@coco.lan> In-Reply-To: <20210509113354.660190-17-jic23@kernel.org> References: <20210509113354.660190-1-jic23@kernel.org> <20210509113354.660190-17-jic23@kernel.org> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org Em Sun, 9 May 2021 12:33:42 +0100 Jonathan Cameron escreveu: > From: Jonathan Cameron > > Found using coccicheck script under review at: > https://lore.kernel.org/lkml/20210427141946.2478411-1-Julia.Lawall@inria.fr/ > > This is a prequel to taking a closer look at the runtime pm in IIO drivers > in general > > Signed-off-by: Jonathan Cameron > Cc: Fabrice Gasnier LGTM. Reviewed-by: Mauro Carvalho Chehab > --- > drivers/iio/dac/stm32-dac.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/iio/dac/stm32-dac.c b/drivers/iio/dac/stm32-dac.c > index a5b0a52bf86e..dd2e306824e7 100644 > --- a/drivers/iio/dac/stm32-dac.c > +++ b/drivers/iio/dac/stm32-dac.c > @@ -69,9 +69,8 @@ static int stm32_dac_set_enable_state(struct iio_dev *indio_dev, int ch, > } > > if (enable) { > - ret = pm_runtime_get_sync(dev); > + ret = pm_runtime_resume_and_get(dev); > if (ret < 0) { > - pm_runtime_put_noidle(dev); > mutex_unlock(&dac->lock); > return ret; > } Thanks, Mauro