From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AD030C433B4 for ; Wed, 12 May 2021 14:22:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 797D7613E9 for ; Wed, 12 May 2021 14:22:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230247AbhELOXd (ORCPT ); Wed, 12 May 2021 10:23:33 -0400 Received: from mail.kernel.org ([198.145.29.99]:49874 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230452AbhELOXZ (ORCPT ); Wed, 12 May 2021 10:23:25 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 845F9613E9; Wed, 12 May 2021 14:22:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1620829337; bh=bHScGVAGjtJYrUi8KXsuGU1B59RWKc9rr2I4BYXmgkQ=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=RrCF8YcVd1pUm9ul2lCyhYD4b3vq/2c/Iv2O9M1Qr1ewCSwND28nlpFedEf0y9P0Z kLZoQ/a6GXrEhJkMKrUuiHaLV8IJ056nBMVti2UhKBpDMaFO83W3ZVrXcWlDoTizEX 6SqbOA06t+jbZY4HL/K/LKfCdHNmKAET/gNwaJKc3wsWnuq3o8ODlrBjznn58UGi8Y /IbdC9ak1RB5WCgxf6GnmnMjd3lnYxQBHPNRuIxD+w5WVW7Yq0RQ7U/RFl37k1Q6Ra Q6iGjcdPqccFSMrRZoznAiQmyiW8DY5hX1i8hG3/zKHANoFFw1YPk/oXphpotmSFLv KxP1MXk8j+M1Q== Date: Wed, 12 May 2021 16:22:12 +0200 From: Mauro Carvalho Chehab To: Jonathan Cameron Cc: linux-iio@vger.kernel.org, Julia Lawall , "Rafael J . Wysocki" , Jonathan Cameron Subject: Re: [PATCH 17/28] iio: adc: ads1015: Use pm_runtime_resume_and_get() to replace open coding. Message-ID: <20210512162212.7f56f0c7@coco.lan> In-Reply-To: <20210509113354.660190-18-jic23@kernel.org> References: <20210509113354.660190-1-jic23@kernel.org> <20210509113354.660190-18-jic23@kernel.org> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org Em Sun, 9 May 2021 12:33:43 +0100 Jonathan Cameron escreveu: > From: Jonathan Cameron > > Found using coccicheck script under review at: > https://lore.kernel.org/lkml/20210427141946.2478411-1-Julia.Lawall@inria.fr/ > > This is a prequel to taking a closer look at the runtime pm in IIO drivers > in general. > > Signed-off-by: Jonathan Cameron This driver has an extra (unbalanced?) call to pm_runtime_put_noidle() at ads1015_remove(). > --- > drivers/iio/adc/ti-ads1015.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/iio/adc/ti-ads1015.c b/drivers/iio/adc/ti-ads1015.c > index 9fef39bcf997..4b61ee3d2501 100644 > --- a/drivers/iio/adc/ti-ads1015.c > +++ b/drivers/iio/adc/ti-ads1015.c > @@ -323,9 +323,7 @@ static int ads1015_set_power_state(struct ads1015_data *data, bool on) > struct device *dev = regmap_get_device(data->regmap); > > if (on) { > - ret = pm_runtime_get_sync(dev); > - if (ret < 0) > - pm_runtime_put_noidle(dev); > + ret = pm_runtime_resume_and_get(dev); > } else { > pm_runtime_mark_last_busy(dev); > ret = pm_runtime_put_autosuspend(dev); Thanks, Mauro