From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 97008C433ED for ; Wed, 12 May 2021 14:36:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5C73461075 for ; Wed, 12 May 2021 14:36:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230247AbhELOhu (ORCPT ); Wed, 12 May 2021 10:37:50 -0400 Received: from mail.kernel.org ([198.145.29.99]:58896 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230202AbhELOhu (ORCPT ); Wed, 12 May 2021 10:37:50 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 1D0DF60FEF; Wed, 12 May 2021 14:36:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1620830202; bh=/ebaK6fTgqWgjsqS2iv3AmVEOg762ZZWqYsaZE9PlEw=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=BZfcdcBl9hf5Uon0nxN94JED79pFQzB6MR0WyLGZEXmeyI+5Jh+03lD7/zBFpnnG3 j9ycN0yPm0jaU6SKRm8pPenmA9LWnLhNPHhaVbZGjhBdUBYcxW3ZzFDxzBH68SpMyk 2yKo1Dk4F3imrRf2PB6mOJsbJWxHcmmj0VQ3y7s7puP/Xiw63GRlXiHYtq+0CF1XoU yCD4EdIOwQVqKiDzz+EYzJ7Xk8surIugu4nAKLUMxUr/2mYGCTgeH55kvhDKi/qILt XgH5GzLmXFG2pBj/V+3i7aqfyUQCbGgy/pdLr2bdrrrMjUzDqw3Qf/YNfpoZ4krG5O Mrl0+zHJtxPAA== Date: Wed, 12 May 2021 16:36:36 +0200 From: Mauro Carvalho Chehab To: Jonathan Cameron Cc: linux-iio@vger.kernel.org, Julia Lawall , "Rafael J . Wysocki" , Jonathan Cameron , Mathieu Othacehe Subject: Re: [PATCH 21/28] iio: light: vcnl4000: Use pm_runtime_resume_and_get() to replace open coding. Message-ID: <20210512163636.67a1ac15@coco.lan> In-Reply-To: <20210509113354.660190-22-jic23@kernel.org> References: <20210509113354.660190-1-jic23@kernel.org> <20210509113354.660190-22-jic23@kernel.org> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org Em Sun, 9 May 2021 12:33:47 +0100 Jonathan Cameron escreveu: > From: Jonathan Cameron > > Found using coccicheck script under review at: > https://lore.kernel.org/lkml/20210427141946.2478411-1-Julia.Lawall@inria.fr/ > > This is a prequel to taking a closer look at the runtime pm in IIO drivers > in general. > > Signed-off-by: Jonathan Cameron > Cc: Mathieu Othacehe LGTM. Reviewed-by: Mauro Carvalho Chehab > --- > drivers/iio/light/vcnl4000.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/iio/light/vcnl4000.c b/drivers/iio/light/vcnl4000.c > index 4a61865d01cd..01772327a947 100644 > --- a/drivers/iio/light/vcnl4000.c > +++ b/drivers/iio/light/vcnl4000.c > @@ -413,9 +413,7 @@ static int vcnl4000_set_pm_runtime_state(struct vcnl4000_data *data, bool on) > int ret; > > if (on) { > - ret = pm_runtime_get_sync(dev); > - if (ret < 0) > - pm_runtime_put_noidle(dev); > + ret = pm_runtime_resume_and_get(dev); > } else { > pm_runtime_mark_last_busy(dev); > ret = pm_runtime_put_autosuspend(dev); Thanks, Mauro