From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BB9A2C433B4 for ; Wed, 12 May 2021 14:52:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 737BF61418 for ; Wed, 12 May 2021 14:52:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230413AbhELOxK (ORCPT ); Wed, 12 May 2021 10:53:10 -0400 Received: from mail.kernel.org ([198.145.29.99]:41148 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230280AbhELOxK (ORCPT ); Wed, 12 May 2021 10:53:10 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 9CAC4613C7; Wed, 12 May 2021 14:52:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1620831122; bh=RVkWtMpUDeB2EnowKhU9w4Hr4bgpTFzhnPqcN016bB8=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=FWclKyyf6fPoEpKb3zflUNdODXu23UPnBPg5ngbJTvPpwCoGOzvn+FxoffiwN2cFK VKQPSfhXR4OWUlv/jp68+tuNnZtj20LpjCTtzRIB8qzHkGiXICZeD/+rPWVrCBpCCV xLykc53GGK6htauOuzvFLKycKOgiYRgbQXcdM3UX6YRS6qscfwJBf11HsS0dOrfrus 17zR76JZGVcNDukal5Uyb2DgAFekJg6QPnzQhEPatfq2Xk8wKGPrllC8ts8LOVDJIn TxH4phPf7Tiu4bFu3pwEFKFbw+Ld5dDfah1M/3xGDzXcVVC3peNC19zcwH398L2yhP keCtSmsMXShfA== Date: Wed, 12 May 2021 16:51:57 +0200 From: Mauro Carvalho Chehab To: Jonathan Cameron Cc: linux-iio@vger.kernel.org, Julia Lawall , "Rafael J . Wysocki" , Jonathan Cameron Subject: Re: [PATCH 24/28] iio: temp: mlx90614: Handle failure in pm_runtime_resume_and_get() Message-ID: <20210512165150.2250356e@coco.lan> In-Reply-To: <20210509113354.660190-25-jic23@kernel.org> References: <20210509113354.660190-1-jic23@kernel.org> <20210509113354.660190-25-jic23@kernel.org> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org Em Sun, 9 May 2021 12:33:50 +0100 Jonathan Cameron escreveu: > From: Jonathan Cameron > > Converts from using pm_runtime_get_sync() with no error handling over > to pm_runtime_resume_and_get() which will ensure we don't end up > holding a reference. Ensure this error return is then handled at > calls to mlx90614_power_get(). These are all direct returns. > > Signed-off-by: Jonathan Cameron LGTM. Reviewed-by: Mauro Carvalho Chehab > --- > drivers/iio/temperature/mlx90614.c | 25 ++++++++++++++++++++----- > 1 file changed, 20 insertions(+), 5 deletions(-) > > diff --git a/drivers/iio/temperature/mlx90614.c b/drivers/iio/temperature/mlx90614.c > index ef0fec94d269..afcb10ea7c44 100644 > --- a/drivers/iio/temperature/mlx90614.c > +++ b/drivers/iio/temperature/mlx90614.c > @@ -176,11 +176,14 @@ static inline s32 mlx90614_iir_search(const struct i2c_client *client, > static int mlx90614_power_get(struct mlx90614_data *data, bool startup) > { > unsigned long now; > + int ret; > > if (!data->wakeup_gpio) > return 0; > > - pm_runtime_get_sync(&data->client->dev); > + ret = pm_runtime_resume_and_get(&data->client->dev); > + if (ret < 0) > + return ret; > > if (startup) { > now = jiffies; > @@ -267,7 +270,10 @@ static int mlx90614_read_raw(struct iio_dev *indio_dev, > *val = MLX90614_CONST_SCALE; > return IIO_VAL_INT; > case IIO_CHAN_INFO_CALIBEMISSIVITY: /* 1/65535 / LSB */ > - mlx90614_power_get(data, false); > + ret = mlx90614_power_get(data, false); > + if (ret < 0) > + return ret; > + > mutex_lock(&data->lock); > ret = i2c_smbus_read_word_data(data->client, > MLX90614_EMISSIVITY); > @@ -287,7 +293,10 @@ static int mlx90614_read_raw(struct iio_dev *indio_dev, > return IIO_VAL_INT_PLUS_NANO; > case IIO_CHAN_INFO_LOW_PASS_FILTER_3DB_FREQUENCY: /* IIR setting with > FIR = 1024 */ > - mlx90614_power_get(data, false); > + ret = mlx90614_power_get(data, false); > + if (ret < 0) > + return ret; > + > mutex_lock(&data->lock); > ret = i2c_smbus_read_word_data(data->client, MLX90614_CONFIG); > mutex_unlock(&data->lock); > @@ -319,7 +328,10 @@ static int mlx90614_write_raw(struct iio_dev *indio_dev, > val = val * MLX90614_CONST_RAW_EMISSIVITY_MAX + > val2 / MLX90614_CONST_EMISSIVITY_RESOLUTION; > > - mlx90614_power_get(data, false); > + ret = mlx90614_power_get(data, false); > + if (ret < 0) > + return ret; > + > mutex_lock(&data->lock); > ret = mlx90614_write_word(data->client, MLX90614_EMISSIVITY, > val); > @@ -331,7 +343,10 @@ static int mlx90614_write_raw(struct iio_dev *indio_dev, > if (val < 0 || val2 < 0) > return -EINVAL; > > - mlx90614_power_get(data, false); > + ret = mlx90614_power_get(data, false); > + if (ret < 0) > + return ret; > + > mutex_lock(&data->lock); > ret = mlx90614_iir_search(data->client, > val * 100 + val2 / 10000); Thanks, Mauro