From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D097BC43462 for ; Wed, 12 May 2021 14:53:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9AD6761428 for ; Wed, 12 May 2021 14:53:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231849AbhELOy7 (ORCPT ); Wed, 12 May 2021 10:54:59 -0400 Received: from mail.kernel.org ([198.145.29.99]:43990 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231749AbhELOyk (ORCPT ); Wed, 12 May 2021 10:54:40 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 933916142E; Wed, 12 May 2021 14:53:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1620831212; bh=O23u1Yt8eJdl6se2oANx4PH3f+XT50RrnCm4Itvqvfk=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=JXHz2gLf+aULkuEbjqrGu+a1VFpAeNF2xjXHK1ZjlhPqLxyhB2CXv3OtQlB0uS8Me 5LXddvUnhyGX8tYo3h43CPpjPIahQ5to679P+yQcKooORRqNSdrCuj0LWrSY4PwxVu /ws9ckk1Enp1V34U2E0euiEMMcdo4SYVPoIUqgvoVPWz81fFzzpgXMUDl9LnCFLdqf deu4rsjeu3xxlS1ZKlE/eVwoaNfyQ7aSmjWbafi1+MJmOxFUObqHm7Rz/DBrw2Zxh3 CHKAEC6kdAW+vxkNg0TQNLn8Tfvf+LtVIg+XBhGrRkB+SlpctovZhYfGSPdlwfotX4 UupzMPY+u3U7Q== Date: Wed, 12 May 2021 16:53:26 +0200 From: Mauro Carvalho Chehab To: Jonathan Cameron Cc: linux-iio@vger.kernel.org, Julia Lawall , "Rafael J . Wysocki" , Jonathan Cameron , Andreas Klinger Subject: Re: [PATCH 25/28] iio: proximity: srf04: Use pm_runtime_resume_and_get() and handle error Message-ID: <20210512165326.12f26e74@coco.lan> In-Reply-To: <20210509113354.660190-26-jic23@kernel.org> References: <20210509113354.660190-1-jic23@kernel.org> <20210509113354.660190-26-jic23@kernel.org> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org Em Sun, 9 May 2021 12:33:51 +0100 Jonathan Cameron escreveu: > From: Jonathan Cameron > > Previously this driver used pm_runtime_sync_get() and did not handle any > errors that occurred. Moving to the new pm_runtime_resume_and_get() + > handle errors. > > Signed-off-by: Jonathan Cameron > Cc: Andreas Klinger LGTM. Reviewed-by: Mauro Carvalho Chehab > --- > drivers/iio/proximity/srf04.c | 8 +++++--- > 1 file changed, 5 insertions(+), 3 deletions(-) > > diff --git a/drivers/iio/proximity/srf04.c b/drivers/iio/proximity/srf04.c > index 420c37c72de4..fe88b2bb60bc 100644 > --- a/drivers/iio/proximity/srf04.c > +++ b/drivers/iio/proximity/srf04.c > @@ -100,9 +100,11 @@ static int srf04_read(struct srf04_data *data) > u64 dt_ns; > u32 time_ns, distance_mm; > > - if (data->gpiod_power) > - pm_runtime_get_sync(data->dev); > - > + if (data->gpiod_power) { > + ret = pm_runtime_resume_and_get(data->dev); > + if (ret < 0) > + return ret; > + } > /* > * just one read-echo-cycle can take place at a time > * ==> lock against concurrent reading calls Thanks, Mauro