From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.5 required=3.0 tests=BAYES_00,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 549C6C433B4 for ; Thu, 13 May 2021 16:53:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2E7096143B for ; Thu, 13 May 2021 16:53:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229480AbhEMQyt (ORCPT ); Thu, 13 May 2021 12:54:49 -0400 Received: from mail.kernel.org ([198.145.29.99]:41168 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229445AbhEMQyl (ORCPT ); Thu, 13 May 2021 12:54:41 -0400 Received: from jic23-huawei (cpc108967-cmbg20-2-0-cust86.5-4.cable.virginm.net [81.101.6.87]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 60EA1613CA; Thu, 13 May 2021 16:53:29 +0000 (UTC) Date: Thu, 13 May 2021 17:54:38 +0100 From: Jonathan Cameron To: Mauro Carvalho Chehab Cc: linux-iio@vger.kernel.org, Julia Lawall , "Rafael J . Wysocki" , Jonathan Cameron , Marek Vasut Subject: Re: [PATCH 28/28] iio: adc: rcar-gyroadc: Use pm_runtime_resume_and_get() and check in probe() Message-ID: <20210513175438.1a2fe2de@jic23-huawei> In-Reply-To: <20210512170140.0e79aa86@coco.lan> References: <20210509113354.660190-1-jic23@kernel.org> <20210509113354.660190-29-jic23@kernel.org> <20210512170140.0e79aa86@coco.lan> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org On Wed, 12 May 2021 17:01:40 +0200 Mauro Carvalho Chehab wrote: > Em Sun, 9 May 2021 12:33:54 +0100 > Jonathan Cameron escreveu: > > > From: Jonathan Cameron > > > > 1 instance found using coccicheck script under review at: > > https://lore.kernel.org/lkml/20210427141946.2478411-1-Julia.Lawall@inria.fr/ > > The other instance changed did not check for failure of the > > pm_runtime_get_sync() so that is added. > > > > Note the remaining pm_runtime_get_sync() call is left alone because it > > is not obvious what to do on failure to power up in remove() > > > > This is a prequel to taking a closer look at the runtime pm in IIO drivers > > in general. > > > > Signed-off-by: Jonathan Cameron > > Cc: Marek Vasut > > LGTM. > > Reviewed-by: Mauro Carvalho Chehab Applied. Thanks, Jonathan > > > --- > > drivers/iio/adc/rcar-gyroadc.c | 15 +++++++-------- > > 1 file changed, 7 insertions(+), 8 deletions(-) > > > > diff --git a/drivers/iio/adc/rcar-gyroadc.c b/drivers/iio/adc/rcar-gyroadc.c > > index 9f38cf3c7dc2..a48895046408 100644 > > --- a/drivers/iio/adc/rcar-gyroadc.c > > +++ b/drivers/iio/adc/rcar-gyroadc.c > > @@ -162,18 +162,13 @@ static const struct iio_chan_spec rcar_gyroadc_iio_channels_3[] = { > > static int rcar_gyroadc_set_power(struct rcar_gyroadc *priv, bool on) > > { > > struct device *dev = priv->dev; > > - int ret; > > > > if (on) { > > - ret = pm_runtime_get_sync(dev); > > - if (ret < 0) > > - pm_runtime_put_noidle(dev); > > + return pm_runtime_resume_and_get(dev); > > } else { > > pm_runtime_mark_last_busy(dev); > > - ret = pm_runtime_put_autosuspend(dev); > > + return pm_runtime_put_autosuspend(dev); > > } > > - > > - return ret; > > } > > > > static int rcar_gyroadc_read_raw(struct iio_dev *indio_dev, > > @@ -535,7 +530,10 @@ static int rcar_gyroadc_probe(struct platform_device *pdev) > > pm_runtime_use_autosuspend(dev); > > pm_runtime_enable(dev); > > > > - pm_runtime_get_sync(dev); > > + ret = pm_runtime_resume_and_get(dev); > > + if (ret) > > + goto err_power_up; > > + > > rcar_gyroadc_hw_init(priv); > > rcar_gyroadc_hw_start(priv); > > > > @@ -552,6 +550,7 @@ static int rcar_gyroadc_probe(struct platform_device *pdev) > > err_iio_device_register: > > rcar_gyroadc_hw_stop(priv); > > pm_runtime_put_sync(dev); > > +err_power_up: > > pm_runtime_disable(dev); > > pm_runtime_set_suspended(dev); > > clk_disable_unprepare(priv->clk); > > > > Thanks, > Mauro