From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.5 required=3.0 tests=BAYES_00,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1873AC433B4 for ; Thu, 13 May 2021 17:05:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DD69161354 for ; Thu, 13 May 2021 17:05:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229797AbhEMRGb (ORCPT ); Thu, 13 May 2021 13:06:31 -0400 Received: from mail.kernel.org ([198.145.29.99]:47022 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229717AbhEMRGa (ORCPT ); Thu, 13 May 2021 13:06:30 -0400 Received: from jic23-huawei (cpc108967-cmbg20-2-0-cust86.5-4.cable.virginm.net [81.101.6.87]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id E5BEC6143D; Thu, 13 May 2021 17:05:18 +0000 (UTC) Date: Thu, 13 May 2021 18:06:27 +0100 From: Jonathan Cameron To: Mauro Carvalho Chehab Cc: linux-iio@vger.kernel.org, Julia Lawall , "Rafael J . Wysocki" , Jonathan Cameron , Sean Nyekjaer Subject: Re: [PATCH 05/28] iio: accel: mma8452: Balance runtime pm + use pm_runtime_resume_and_get() Message-ID: <20210513180627.4370d489@jic23-huawei> In-Reply-To: <20210512153710.6d8957a2@coco.lan> References: <20210509113354.660190-1-jic23@kernel.org> <20210509113354.660190-6-jic23@kernel.org> <20210512153710.6d8957a2@coco.lan> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org On Wed, 12 May 2021 15:37:10 +0200 Mauro Carvalho Chehab wrote: > Em Sun, 9 May 2021 12:33:31 +0100 > Jonathan Cameron escreveu: > > > From: Jonathan Cameron > > > > Remove() callback calls pm_runtime_put_noidle() but there it is not > > balancing a get. No actual affect because the runtime pm core prevents > > the reference count going negative. > > > > Whilst here use pm_runtime_resume_and_get() rather than open coded version. > > Again, coccinelle script missed this one due to more complex code > > structure. > > > > Signed-off-by: Jonathan Cameron > > Cc: Sean Nyekjaer > > LGTM. > > Reviewed-by: Mauro Carvalho Chehab Applied to the togreg branch of iio.git and pushed out as testing for the autobuilders to play with it. Note additional reviews / tags are find for now as I'm happy to rebase this tree as needed until it goes out as togreg (when I try not to!) Thanks, Jonathan > > > --- > > drivers/iio/accel/mma8452.c | 5 +---- > > 1 file changed, 1 insertion(+), 4 deletions(-) > > > > diff --git a/drivers/iio/accel/mma8452.c b/drivers/iio/accel/mma8452.c > > index 464a6bfe6746..715b8138fb71 100644 > > --- a/drivers/iio/accel/mma8452.c > > +++ b/drivers/iio/accel/mma8452.c > > @@ -221,7 +221,7 @@ static int mma8452_set_runtime_pm_state(struct i2c_client *client, bool on) > > int ret; > > > > if (on) { > > - ret = pm_runtime_get_sync(&client->dev); > > + ret = pm_runtime_resume_and_get(&client->dev); > > } else { > > pm_runtime_mark_last_busy(&client->dev); > > ret = pm_runtime_put_autosuspend(&client->dev); > > @@ -230,8 +230,6 @@ static int mma8452_set_runtime_pm_state(struct i2c_client *client, bool on) > > if (ret < 0) { > > dev_err(&client->dev, > > "failed to change power state to %d\n", on); > > - if (on) > > - pm_runtime_put_noidle(&client->dev); > > > > return ret; > > } > > @@ -1711,7 +1709,6 @@ static int mma8452_remove(struct i2c_client *client) > > > > pm_runtime_disable(&client->dev); > > pm_runtime_set_suspended(&client->dev); > > - pm_runtime_put_noidle(&client->dev); > > > > iio_triggered_buffer_cleanup(indio_dev); > > mma8452_trigger_cleanup(indio_dev); > > > > Thanks, > Mauro