From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1A7F8C433F5 for ; Thu, 2 Sep 2021 22:17:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EF93860FDC for ; Thu, 2 Sep 2021 22:17:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242407AbhIBWSa convert rfc822-to-8bit (ORCPT ); Thu, 2 Sep 2021 18:18:30 -0400 Received: from relay6-d.mail.gandi.net ([217.70.183.198]:50135 "EHLO relay6-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236148AbhIBWS3 (ORCPT ); Thu, 2 Sep 2021 18:18:29 -0400 X-Greylist: delayed 35517 seconds by postgrey-1.27 at vger.kernel.org; Thu, 02 Sep 2021 18:18:28 EDT Received: (Authenticated sender: miquel.raynal@bootlin.com) by relay6-d.mail.gandi.net (Postfix) with ESMTPSA id 7C2B1C0005; Thu, 2 Sep 2021 22:17:26 +0000 (UTC) Date: Fri, 3 Sep 2021 00:17:25 +0200 From: Miquel Raynal To: Jonathan Cameron , Lars-Peter Clausen , Peter Meerwald-Stadler , Rob Herring , Dmitry Torokhov , Lee Jones , bcousson@baylibre.com, Tony Lindgren Cc: linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-input@vger.kernel.org, linux-omap@vger.kernel.org, Thomas Petazzoni , Vignesh Raghavendra , Lokesh Vutla , Tero Kristo , Ryan Barnett , Grygorii Strashko , Jason Reeder Subject: Re: [PATCH v2 45/46] ARM: dts: am43xx: Describe the magnetic reader/ADC1 hardware module Message-ID: <20210903001725.59833f05@xps13> In-Reply-To: <20210902215144.507243-46-miquel.raynal@bootlin.com> References: <20210902215144.507243-1-miquel.raynal@bootlin.com> <20210902215144.507243-46-miquel.raynal@bootlin.com> Organization: Bootlin X-Mailer: Claws Mail 3.17.7 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org Hello, Miquel Raynal wrote on Thu, 2 Sep 2021 23:51:43 +0200: > This hardware module is close to the am33xx ADC module but instead of > featuring a touchscreen it has a magnetic reader capability. > > Signed-off-by: Miquel Raynal > --- > arch/arm/boot/dts/am437x-l4.dtsi | 31 ++++++++++++++++++++++++++-- > arch/arm/boot/dts/am43xx-clocks.dtsi | 7 +++++++ > 2 files changed, 36 insertions(+), 2 deletions(-) > > diff --git a/arch/arm/boot/dts/am437x-l4.dtsi b/arch/arm/boot/dts/am437x-l4.dtsi > index 370c4e64676f..7a3dcfc7bfc9 100644 > --- a/arch/arm/boot/dts/am437x-l4.dtsi > +++ b/arch/arm/boot/dts/am437x-l4.dtsi > @@ -2350,11 +2350,38 @@ hdq: hdq@0 { > }; > > target-module@4c000 { /* 0x4834c000, ap 114 72.0 */ > - compatible = "ti,sysc"; > - status = "disabled"; > + compatible = "ti,sysc-omap4", "ti,sysc"; > + reg = <0x4c000 0x4>, > + <0x4c010 0x4>; > + reg-names = "rev", "sysc"; > + ti,sysc-sidle = , > + , > + ; > + clocks = <&l3s_clkctrl AM4_L3S_ADC1_CLKCTRL 0>; > + clock-names = "fck"; > #address-cells = <1>; > #size-cells = <1>; > ranges = <0x0 0x4c000 0x2000>; > + > + magadc: magadc@0 { > + compatible = "ti,am4372-magadc"; > + reg = <0x0 0x2000>; > + interrupts = ; > + clocks = <&adc_mag_fck>; > + clock-names = "fck"; > + dmas = <&edma 54 0>, <&edma 55 0>;; Small typo here, should have a single ';'. As the series is fairly long, we will see if there is a need to resend it or not. > + dma-names = "fifo0", "fifo1"; > + status = "disabled"; > + > + mag { > + compatible = "ti,am4372-mag"; > + }; > + > + adc { > + #io-channel-cells = <1>; > + compatible ="ti,am4372-adc"; > + }; > + }; > }; > > target-module@80000 { /* 0x48380000, ap 123 42.0 */ > diff --git a/arch/arm/boot/dts/am43xx-clocks.dtsi b/arch/arm/boot/dts/am43xx-clocks.dtsi > index c726cd8dbdf1..59b1f592a743 100644 > --- a/arch/arm/boot/dts/am43xx-clocks.dtsi > +++ b/arch/arm/boot/dts/am43xx-clocks.dtsi > @@ -444,6 +444,13 @@ wdt1_fck: wdt1_fck@422c { > reg = <0x422c>; > }; > > + adc_mag_fck: adc_mag_fck@424c { > + #clock-cells = <0>; > + compatible = "ti,mux-clock"; > + clocks = <&sys_clkin_ck>, <&dpll_per_m2_ck>; > + reg = <0x424c>; > + }; > + > l3_gclk: l3_gclk { > #clock-cells = <0>; > compatible = "fixed-factor-clock"; Thanks, Miquèl