From: Jonathan Cameron <jic23@kernel.org>
To: Miquel Raynal <miquel.raynal@bootlin.com>
Cc: linux-iio@vger.kernel.org, Lars-Peter Clausen <lars@metafoo.de>,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Subject: Re: [PATCH 01/10] iio: core: Fix the kernel doc regarding the currentmode iio_dev entry
Date: Sat, 15 Jan 2022 15:47:31 +0000 [thread overview]
Message-ID: <20220115154713.2f9f25fb@jic23-huawei> (raw)
In-Reply-To: <20211215151344.163036-2-miquel.raynal@bootlin.com>
On Wed, 15 Dec 2021 16:13:35 +0100
Miquel Raynal <miquel.raynal@bootlin.com> wrote:
Sorry for taking so long to get to these. I knew some of them were
likely to take some thinking so they kept falling at the end of
my review list and I kept running out of time / energy!
Anyhow, time to make some progress.
> This is an internal variable, which should be accessed in a very
> sporadic way and in no case changed by any device driver.
>
> Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
Hohum. Plenty of history around this one but I think you are right
that it now makes sense to mark it as INTERN (and when we can move it
over to the opaque structure).
Applied to the togreg branch of iio.git and pushed out as testing.
Thanks,
Jonathan
> ---
> include/linux/iio/iio.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/linux/iio/iio.h b/include/linux/iio/iio.h
> index 324561b7a5e8..06433c2c2968 100644
> --- a/include/linux/iio/iio.h
> +++ b/include/linux/iio/iio.h
> @@ -488,7 +488,7 @@ struct iio_buffer_setup_ops {
> /**
> * struct iio_dev - industrial I/O device
> * @modes: [DRIVER] operating modes supported by device
> - * @currentmode: [DRIVER] current operating mode
> + * @currentmode: [INTERN] current operating mode
> * @dev: [DRIVER] device structure, should be assigned a parent
> * and owner
> * @buffer: [DRIVER] any buffer present
next prev parent reply other threads:[~2022-01-15 15:41 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-15 15:13 [PATCH 00/10] Light core IIO enhancements Miquel Raynal
2021-12-15 15:13 ` [PATCH 01/10] iio: core: Fix the kernel doc regarding the currentmode iio_dev entry Miquel Raynal
2021-12-16 6:23 ` Alexandru Ardelean
2022-01-15 15:47 ` Jonathan Cameron [this message]
2021-12-15 15:13 ` [PATCH 02/10] iio: core: Enhance the kernel doc of modes and currentmodes iio_dev entries Miquel Raynal
2021-12-16 6:24 ` Alexandru Ardelean
2021-12-16 8:15 ` Miquel Raynal
2022-01-15 15:51 ` Jonathan Cameron
2022-01-28 14:56 ` Miquel Raynal
2021-12-15 15:13 ` [PATCH 03/10] iio: magnetometer: rm3100: Stop abusing the ->currentmode Miquel Raynal
2021-12-16 6:40 ` Alexandru Ardelean
2021-12-16 8:18 ` Miquel Raynal
2022-01-15 15:58 ` Jonathan Cameron
2022-01-28 15:00 ` Miquel Raynal
2021-12-15 15:13 ` [PATCH 04/10] iio: adc: stm32-dfsdm: Avoid dereferencing ->currentmode Miquel Raynal
2021-12-16 6:47 ` Alexandru Ardelean
2021-12-16 8:22 ` Miquel Raynal
2022-01-15 16:06 ` Jonathan Cameron
2022-01-28 15:04 ` Miquel Raynal
2022-02-01 8:41 ` Fabrice Gasnier
2022-02-02 9:33 ` Miquel Raynal
2021-12-15 15:13 ` [PATCH 05/10] iio: st_sensors: Use iio_device_claim/release_direct_mode() when relevant Miquel Raynal
2021-12-16 7:16 ` Alexandru Ardelean
2021-12-16 8:32 ` Miquel Raynal
2022-01-15 16:38 ` Jonathan Cameron
2021-12-15 15:13 ` [PATCH 06/10] iio: core: Hide read accesses to iio_dev->currentmode Miquel Raynal
2021-12-16 7:38 ` Alexandru Ardelean
2021-12-16 7:41 ` Alexandru Ardelean
2021-12-16 8:37 ` Miquel Raynal
2022-01-15 16:51 ` Jonathan Cameron
2021-12-15 15:13 ` [PATCH 07/10] iio: core: Hide write " Miquel Raynal
2022-01-15 16:56 ` Jonathan Cameron
2022-02-02 8:16 ` Miquel Raynal
2021-12-15 15:13 ` [PATCH 08/10] iio: core: Move iio_dev->currentmode to the opaque structure Miquel Raynal
2021-12-16 7:48 ` Alexandru Ardelean
2021-12-16 8:38 ` Miquel Raynal
2022-01-15 17:00 ` Jonathan Cameron
2021-12-15 15:13 ` [PATCH 09/10] iio: core: Simplify the registration of kfifo buffers Miquel Raynal
2021-12-16 7:52 ` Alexandru Ardelean
2022-01-15 17:12 ` Jonathan Cameron
2022-02-02 8:09 ` Miquel Raynal
2022-02-05 18:50 ` Jonathan Cameron
2021-12-15 15:13 ` [PATCH 10/10] iio: core: Clarify the modes Miquel Raynal
2022-01-15 17:30 ` Jonathan Cameron
2022-02-02 13:46 ` Miquel Raynal
2022-02-05 18:56 ` Jonathan Cameron
2022-02-06 13:21 ` Miquel Raynal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220115154713.2f9f25fb@jic23-huawei \
--to=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=miquel.raynal@bootlin.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).