From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Jonathan Cameron <jic23@kernel.org>
Cc: Lars-Peter Clausen <lars@metafoo.de>,
Paul Cercueil <paul@crapouillou.net>,
Hans de Goede <hdegoede@redhat.com>,
linux-iio@vger.kernel.org,
Andy Shevchenko <andy.shevchenko@gmail.com>,
Alexandru Ardelean <ardeleanalex@gmail.com>,
Gwendal Grignou <gwendal@chromium.org>,
Guenter Roeck <linux@roeck-us.net>,
Linus Walleij <linus.walleij@linaro.org>,
Mauro Carvalho Chehab <mchehab+huawei@kernel.org>,
Jiri Valek - 2N <valek@2n.cz>,
Colin Ian King <colin.king@intel.com>,
Brian Masney <masneyb@onstation.org>
Subject: [PATCH 0/9] iio: Remove duplicated error reporting in .remove()
Date: Sat, 30 Apr 2022 10:15:58 +0200 [thread overview]
Message-ID: <20220430081607.15078-1-u.kleine-koenig@pengutronix.de> (raw)
Hello,
this series adapts several i2c drivers that emit two error messages if
something in their remove function fails. The relevant issue is that the
i2c core emits an error message if the remove callback returns a
non-zero value but the drivers already emit a (better) message. So
these patches change the drivers to return 0 even after an error. Note
there is no further error handling in the i2c core, if a remove callback
returns an error code, the device is removed anyhow, so the only effect
of making the return value zero is that the error message is suppressed.
The motivation for this series is to eventually change the prototype of
the i2c remove callback to return void. As a preparation all remove
functions should return 0 such that changing the prototype doesn't
change behaviour of individual drivers.
Best regards
Uwe
Uwe Kleine-König (9):
iio:accel:mc3230: Remove duplicated error reporting in .remove()
iio:accel:stk8312: Remove duplicated error reporting in .remove()
iio:accel:stk8ba50: Remove duplicated error reporting in .remove()
iio:light:bh1780: Remove duplicated error reporting in .remove()
iio:light:isl29028: Remove duplicated error reporting in .remove()
iio:light:jsa1212: Remove duplicated error reporting in .remove()
iio:light:opt3001: Remove duplicated error reporting in .remove()
iio:light:stk3310: Remove duplicated error reporting in .remove()
iio:light:tsl2583: Remove duplicated error reporting in .remove()
drivers/iio/accel/mc3230.c | 4 +++-
drivers/iio/accel/stk8312.c | 4 +++-
drivers/iio/accel/stk8ba50.c | 4 +++-
drivers/iio/light/bh1780.c | 7 +++----
drivers/iio/light/isl29028.c | 4 +++-
drivers/iio/light/jsa1212.c | 4 +++-
drivers/iio/light/opt3001.c | 3 +--
drivers/iio/light/stk3310.c | 5 ++++-
drivers/iio/light/tsl2583.c | 4 +++-
9 files changed, 26 insertions(+), 13 deletions(-)
base-commit: 3123109284176b1532874591f7c81f3837bbdc17
--
2.35.1
next reply other threads:[~2022-04-30 8:16 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-30 8:15 Uwe Kleine-König [this message]
2022-04-30 8:15 ` [PATCH 1/9] iio:accel:mc3230: Remove duplicated error reporting in .remove() Uwe Kleine-König
2022-04-30 8:16 ` [PATCH 2/9] iio:accel:stk8312: " Uwe Kleine-König
2022-04-30 8:16 ` [PATCH 3/9] iio:accel:stk8ba50: " Uwe Kleine-König
2022-04-30 8:16 ` [PATCH 4/9] iio:light:bh1780: " Uwe Kleine-König
2022-05-01 20:59 ` Linus Walleij
2022-04-30 8:16 ` [PATCH 5/9] iio:light:isl29028: " Uwe Kleine-König
2022-04-30 8:16 ` [PATCH 6/9] iio:light:jsa1212: " Uwe Kleine-König
2022-04-30 8:16 ` [PATCH 7/9] iio:light:opt3001: " Uwe Kleine-König
2022-04-30 8:16 ` [PATCH 8/9] iio:light:stk3310: " Uwe Kleine-König
2022-05-02 7:37 ` Uwe Kleine-König
2022-05-04 20:58 ` Jonathan Cameron
2022-04-30 8:16 ` [PATCH 9/9] iio:light:tsl2583: " Uwe Kleine-König
2022-05-01 17:41 ` [PATCH 0/9] iio: " Jonathan Cameron
2022-05-01 17:51 ` Jonathan Cameron
2022-05-07 14:38 ` Jonathan Cameron
2022-05-13 7:24 ` Uwe Kleine-König
2022-05-14 13:31 ` Jonathan Cameron
2022-05-14 13:41 ` Uwe Kleine-König
2022-05-14 16:30 ` Jonathan Cameron
2022-05-02 6:31 ` Uwe Kleine-König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220430081607.15078-1-u.kleine-koenig@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=andy.shevchenko@gmail.com \
--cc=ardeleanalex@gmail.com \
--cc=colin.king@intel.com \
--cc=gwendal@chromium.org \
--cc=hdegoede@redhat.com \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linus.walleij@linaro.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=masneyb@onstation.org \
--cc=mchehab+huawei@kernel.org \
--cc=paul@crapouillou.net \
--cc=valek@2n.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).