From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 34F42C19F2A for ; Sun, 7 Aug 2022 13:36:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234403AbiHGNgg (ORCPT ); Sun, 7 Aug 2022 09:36:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48270 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234353AbiHGNgf (ORCPT ); Sun, 7 Aug 2022 09:36:35 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 200A825F for ; Sun, 7 Aug 2022 06:36:35 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id A6A9B60ECC for ; Sun, 7 Aug 2022 13:36:34 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7A9F2C433D6; Sun, 7 Aug 2022 13:36:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1659879393; bh=90eAnE8n5vXK1vhmnWzxBpFbu/50lHcOcRca37VbI+4=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=swgBl4SSkBr29Tua4tupnp6yzrjih+P6tz3+mos3RYRIJ5rZixb3/+3MnKyPiQsVv t4rmR15CsltzjssmIOwy63Os9vfrq2V53rMLwe5JejJnKc6NMSajOANe+9HTqwyxbr 1NZaa0S3k6nwJwvPv1T/dLTFz6G3ZcWOlKy3X8j1EC/K8BvnnnWRyreHbM7Dte/J76 r7PT8D0IcVUoLSQ5oHvBnpBR3L4phUDr2EktU/bRwB/xrLKP+kcEonjBXIUk14TXG9 Oz5Bzzj15LARIVepiyV4/MqlHWHp1fNFd6X1s4s//CAmQK4OC5ysxheCCDTy0iw/7O akZn/BTO5g19Q== Date: Sun, 7 Aug 2022 14:46:51 +0100 From: Jonathan Cameron To: Andy Shevchenko Cc: linux-iio , Peter Rosin , Michael Hennerich , Lars-Peter Clausen , Vincent Whitchurch , Jonathan Cameron Subject: Re: [PATCH v3 11/17] iio: core: Introduce _zeropoint for differential channels Message-ID: <20220807144652.46c35233@jic23-huawei> In-Reply-To: <20220718190235.6578113b@jic23-huawei> References: <20220626122938.582107-1-jic23@kernel.org> <20220626122938.582107-12-jic23@kernel.org> <20220718190235.6578113b@jic23-huawei> X-Mailer: Claws Mail 4.1.0 (GTK 3.24.34; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org On Mon, 18 Jul 2022 19:02:35 +0100 Jonathan Cameron wrote: > On Tue, 28 Jun 2022 14:17:33 +0200 > Andy Shevchenko wrote: > > > On Sun, Jun 26, 2022 at 2:20 PM Jonathan Cameron wrote: > > > > > > From: Jonathan Cameron > > > > > > Address an ABI gap for device where the offset of both lines in a > > > differential pair may be controlled so as to allow a wider range of > > > inputs, but without having any direct effect of the differential > > > measurement. > > > > > > _offset cannot be used as to remain in line with existing usage, > > > userspace would be expected to apply it as (_raw + _offset) * _scale > > > whereas _zeropoint is not. i.e. If we were computing the differential > > > in software it would be. > > > ((postive_raw + _zeropoint) - (negative_raw + zeropoint) + _offset) * _scale > > > = ((postive_raw - negative_raw) + _offset) * _scale > > > = (differential_raw + _offset) * _scale > > > > > > Similarly calibbias is expected to tweak the measurement seen, not > > > the adjust the two lines of the differential pair. > > > > > > Needed for in_capacitanceX-capacitanceY_zeropoint for the > > > AD7746 CDC driver. > > > > ... > > > > > +What: /sys/.../iio:deviceX/in_capacitanceY-capacitanceZ_zeropoint > > > +KernelVersion: 5.19 > > > > 5.20? > > :) Probably 5.21 as I'm not going to rush this in now, but good point none the less. 6.0 I guess :) Anyhow I've applied this with Andy's tag on the assumption that the below English quirk is fine by Andy. Jonathan > > > > > > +Contact: linux-iio@vger.kernel.org > > > +Description: > > > + For differential channels, this an offset that is applied > > > + equally to both inputs. As the reading is of the difference > > > + between the two inputs, this should not be applied to the _raw > > > + reading by userspace (unlike _offset) and unlike calibbias > > > + it does not affect the differential value measured because > > > + the effect of _zeropoint cancels out across the two inputs > > > + that make up the differential pair. It's purpose is to bring > > > > makes > > No. make is correct. > That's indeed an odd corner of English and honestly I'm not sure I could successfully > argue why it should be make :) > > > > > > + the individual signals, before the differential is measured, > > > + within the measurement range of the device. The naming is > > > + chosen because if the separate inputs that make the > > > + differential pair are drawn on a graph in their > > > + _raw units, this is the value that the zero point on the > > > + measurement axis represents. It is expressed with the > > > + same scaling as _raw. > > >