linux-iio.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Hans de Goede <hdegoede@redhat.com>
To: Jonathan Cameron <jic23@kernel.org>
Cc: Hans de Goede <hdegoede@redhat.com>,
	Lars-Peter Clausen <lars@metafoo.de>,
	Christian Oder <me@myself5.de>,
	Nikita Mikhailevich <ermyril@gmail.com>,
	linux-iio@vger.kernel.org
Subject: [RFC 0/2] iio: accel: mxc4005: IRQ fixes + reset chip on probe()
Date: Tue, 26 Mar 2024 12:36:58 +0100	[thread overview]
Message-ID: <20240326113700.56725-1-hdegoede@redhat.com> (raw)

Hi All,

As reported here:
https://bugzilla.kernel.org/show_bug.cgi?id=218578

The MXC6655 found on several Chuwi tablets models works sometimes instead
of all the time. The problem seems to be that the power-sequencing done
on the board causes the chip to not reliably reset leaving it in a random
state at boot (and after suspend/resume).

The second patch in this set fixes this by using the sw-reset feature to
explicitly reset the chip on probe() and resume().

While working on this I also noticed an issue with the interrupt mask
handling, this is fixed in the first patch of the set.

This is marked as a RFC for now because this is untested atm. I'll
provide a test kernel to the reporter of:
https://bugzilla.kernel.org/show_bug.cgi?id=218578
so that this can be tested.

Regards,

Hans


Hans de Goede (2):
  iio: accel: mxc4005: Interrupt handling fixes
  iio: accel: mxc4005: Reset chip on probe() and resume()

 drivers/iio/accel/mxc4005.c | 82 +++++++++++++++++++++++++++++++++----
 1 file changed, 75 insertions(+), 7 deletions(-)

-- 
2.44.0


             reply	other threads:[~2024-03-26 11:37 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-26 11:36 Hans de Goede [this message]
2024-03-26 11:36 ` [RFC 1/2] iio: accel: mxc4005: Interrupt handling fixes Hans de Goede
2024-03-26 11:37 ` [RFC 2/2] iio: accel: mxc4005: Reset chip on probe() and resume() Hans de Goede
2024-03-28 13:05   ` Jonathan Cameron
2024-03-27 11:02 ` [RFC 0/2] iio: accel: mxc4005: IRQ fixes + reset chip on probe() Hans de Goede

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240326113700.56725-1-hdegoede@redhat.com \
    --to=hdegoede@redhat.com \
    --cc=ermyril@gmail.com \
    --cc=jic23@kernel.org \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=me@myself5.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).