From: "Ardelean, Alexandru" <alexandru.Ardelean@analog.com>
To: "jic23@kernel.org" <jic23@kernel.org>,
"denis.ciocca@st.com" <denis.ciocca@st.com>,
"linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>
Subject: Re: [PATCH 5/5] iio:pressure: do not allocate/de-allocate buffer here but link setup_ops to st_sensors_buffer
Date: Thu, 1 Aug 2019 08:25:29 +0000 [thread overview]
Message-ID: <2a5c4a21fa2e2e9f2e2ba635bc4aa691e119b106.camel@analog.com> (raw)
In-Reply-To: <20190731215250.16403-6-denis.ciocca@st.com>
On Wed, 2019-07-31 at 14:52 -0700, Denis Ciocca wrote:
> [External]
>
> Setup buffer_setup_ops pre/post enable/disable to use
> st_sensor_buffers functions for memory allocation/de-allocation.
>
Reviewed-by: Alexandru Ardelean <alexandru.ardelean@analog.com>
> Signed-off-by: Denis Ciocca <denis.ciocca@st.com>
> ---
> drivers/iio/pressure/st_pressure_buffer.c | 14 +++-----------
> 1 file changed, 3 insertions(+), 11 deletions(-)
>
> diff --git a/drivers/iio/pressure/st_pressure_buffer.c b/drivers/iio/pressure/st_pressure_buffer.c
> index 77cb2d862f19..4306541953d0 100644
> --- a/drivers/iio/pressure/st_pressure_buffer.c
> +++ b/drivers/iio/pressure/st_pressure_buffer.c
> @@ -31,17 +31,11 @@ int st_press_trig_set_state(struct iio_trigger *trig, bool state)
>
> static int st_press_buffer_postenable(struct iio_dev *indio_dev)
> {
> - struct st_sensor_data *press_data = iio_priv(indio_dev);
> int err;
>
> - press_data->buffer_data = kmalloc(indio_dev->scan_bytes,
> - GFP_DMA | GFP_KERNEL);
> - if (!press_data->buffer_data)
> - return -ENOMEM;
> -
> err = iio_triggered_buffer_postenable(indio_dev);
> if (err < 0)
> - goto st_press_free_buffer;
> + return err;
>
> err = st_sensors_set_enable(indio_dev, true);
> if (err < 0)
> @@ -51,14 +45,11 @@ static int st_press_buffer_postenable(struct iio_dev *indio_dev)
>
> st_press_buffer_predisable:
> iio_triggered_buffer_predisable(indio_dev);
> -st_press_free_buffer:
> - kfree(press_data->buffer_data);
> return err;
> }
>
> static int st_press_buffer_predisable(struct iio_dev *indio_dev)
> {
> - struct st_sensor_data *press_data = iio_priv(indio_dev);
> int err, err2;
>
> err = st_sensors_set_enable(indio_dev, false);
> @@ -67,13 +58,14 @@ static int st_press_buffer_predisable(struct iio_dev *indio_dev)
> if (!err)
> err = err2;
>
> - kfree(press_data->buffer_data);
> return err;
> }
>
> static const struct iio_buffer_setup_ops st_press_buffer_setup_ops = {
> + .preenable = &st_sensors_buffer_preenable,
> .postenable = &st_press_buffer_postenable,
> .predisable = &st_press_buffer_predisable,
> + .postdisable = &st_sensors_buffer_postdisable,
> };
>
> int st_press_allocate_ring(struct iio_dev *indio_dev)
next prev parent reply other threads:[~2019-08-01 8:25 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-31 21:52 [PATCH 0/5] move buffer allocation into st_sensors_buffer Denis Ciocca
2019-07-31 21:52 ` [PATCH 1/5] iio:common: introduce st_sensors_buffer_preenable/predisable functions Denis Ciocca
2019-08-01 8:24 ` Ardelean, Alexandru
2019-08-05 15:21 ` Jonathan Cameron
2019-08-05 15:35 ` Jonathan Cameron
2019-08-05 17:18 ` Denis CIOCCA
2019-08-05 17:40 ` Denis CIOCCA
2019-07-31 21:52 ` [PATCH 2/5] iio:accel: do not allocate/de-allocate buffer here but link setup_ops to st_sensors_buffer Denis Ciocca
2019-08-01 8:24 ` Ardelean, Alexandru
2019-07-31 21:52 ` [PATCH 3/5] iio:gyro: " Denis Ciocca
2019-08-01 8:25 ` Ardelean, Alexandru
2019-07-31 21:52 ` [PATCH 4/5] iio:magn: " Denis Ciocca
2019-08-01 8:25 ` Ardelean, Alexandru
2019-07-31 21:52 ` [PATCH 5/5] iio:pressure: " Denis Ciocca
2019-08-01 8:25 ` Ardelean, Alexandru [this message]
2019-08-01 8:23 ` [PATCH 0/5] move buffer allocation into st_sensors_buffer Ardelean, Alexandru
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2a5c4a21fa2e2e9f2e2ba635bc4aa691e119b106.camel@analog.com \
--to=alexandru.ardelean@analog.com \
--cc=denis.ciocca@st.com \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).