From: Lars-Peter Clausen <lars@metafoo.de>
To: "Sa, Nuno" <Nuno.Sa@analog.com>, Jonathan Cameron <jic23@kernel.org>
Cc: Hartmut Knaack <knaack.h@gmx.de>,
Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
"Ardelean, Alexandru" <alexandru.Ardelean@analog.com>,
"linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>
Subject: Re: [PATCH] iio: dma-buffer: Cleanup buffer.h/buffer_impl.h includes
Date: Wed, 25 Mar 2020 10:01:04 +0100 [thread overview]
Message-ID: <30ae9871-509d-031e-a01e-16bc511c8b99@metafoo.de> (raw)
In-Reply-To: <BN6PR03MB33471B79BA11923CE08971B199CE0@BN6PR03MB3347.namprd03.prod.outlook.com>
On 3/25/20 9:26 AM, Sa, Nuno wrote:
> I also came across with this in ADI internal tree. Did you considered to also split buffer_dma.h into a public
> and an impl header? Hence, users of buffer_dma do not get access to the internals of buffer.h? That was the
> approach I suggested in our tree since the split of buffer and buffer_impl is exactly for users not to
> know about the internals...
>
> Or do you think that it's not
At the moment I think there are no users of buffer-dma.h that are not
implementations of a buffer. At least in upstream.
There are a few drivers in the ADI tree, which include buffer-dma.h. But
this is because they provide their own overloaded implementation for
some of the callbacks. In a sense that makes them a buffer
implementation. Most of them use the same simple implementation for the
overloaded operations. It should be possible to factor this out and use
it as a default. Then the include to buffer_dma.h can be removed.
- Lars
prev parent reply other threads:[~2020-03-25 9:01 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-24 14:16 [PATCH] iio: dma-buffer: Cleanup buffer.h/buffer_impl.h includes Lars-Peter Clausen
2020-03-24 14:36 ` Ardelean, Alexandru
2020-03-28 16:43 ` Jonathan Cameron
2020-03-29 10:08 ` Jonathan Cameron
2020-03-25 8:26 ` Sa, Nuno
2020-03-25 9:01 ` Lars-Peter Clausen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=30ae9871-509d-031e-a01e-16bc511c8b99@metafoo.de \
--to=lars@metafoo.de \
--cc=Nuno.Sa@analog.com \
--cc=alexandru.Ardelean@analog.com \
--cc=jic23@kernel.org \
--cc=knaack.h@gmx.de \
--cc=linux-iio@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).