From: "Ardelean, Alexandru" <alexandru.Ardelean@analog.com>
To: "jic23@kernel.org" <jic23@kernel.org>,
"linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>
Cc: "Jonathan.Cameron@huawei.com" <Jonathan.Cameron@huawei.com>,
"contact@artur-rojek.eu" <contact@artur-rojek.eu>
Subject: Re: [PATCH] iio: adc: ingenic: Use devm_platform_ioremap_resource
Date: Mon, 4 Nov 2019 15:16:14 +0000 [thread overview]
Message-ID: <30c84014f09f22ed2cdfe2d5785eb60adff8b2a7.camel@analog.com> (raw)
In-Reply-To: <20191013152716.1830911-1-jic23@kernel.org>
On Sun, 2019-10-13 at 16:27 +0100, jic23@kernel.org wrote:
> From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
>
> Replaces local boilerplate. Identified by coccinelle.
> CHECK drivers/iio/adc/ingenic-adc.c
> drivers/iio/adc/ingenic-adc.c:449:1-10: WARNING: Use
> devm_platform_ioremap_resource for adc -> base
>
Reviewed-by: Alexandru Ardelean <alexandru.ardelean@analog.com>
> Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> Cc: Artur Rojek <contact@artur-rojek.eu>
> ---
> drivers/iio/adc/ingenic-adc.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/iio/adc/ingenic-adc.c b/drivers/iio/adc/ingenic-
> adc.c
> index 7a53c2f8d438..39c0a609fc94 100644
> --- a/drivers/iio/adc/ingenic-adc.c
> +++ b/drivers/iio/adc/ingenic-adc.c
> @@ -428,7 +428,6 @@ static int ingenic_adc_probe(struct platform_device
> *pdev)
> struct device *dev = &pdev->dev;
> struct iio_dev *iio_dev;
> struct ingenic_adc *adc;
> - struct resource *mem_base;
> const struct ingenic_adc_soc_data *soc_data;
> int ret;
>
> @@ -445,8 +444,7 @@ static int ingenic_adc_probe(struct platform_device
> *pdev)
> mutex_init(&adc->aux_lock);
> adc->soc_data = soc_data;
>
> - mem_base = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - adc->base = devm_ioremap_resource(dev, mem_base);
> + adc->base = devm_platform_ioremap_resource(pdev, 0);
> if (IS_ERR(adc->base))
> return PTR_ERR(adc->base);
>
next prev parent reply other threads:[~2019-11-04 15:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-13 15:27 [PATCH] iio: adc: ingenic: Use devm_platform_ioremap_resource jic23
2019-11-04 15:16 ` Ardelean, Alexandru [this message]
2019-11-09 12:20 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=30c84014f09f22ed2cdfe2d5785eb60adff8b2a7.camel@analog.com \
--to=alexandru.ardelean@analog.com \
--cc=Jonathan.Cameron@huawei.com \
--cc=contact@artur-rojek.eu \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).