* [PATCH] iio: adc: lpc18xx: use devm_platform_ioremap_resource
@ 2019-10-13 15:32 jic23
2019-11-04 15:19 ` Ardelean, Alexandru
0 siblings, 1 reply; 3+ messages in thread
From: jic23 @ 2019-10-13 15:32 UTC (permalink / raw)
To: linux-iio; +Cc: Jonathan Cameron, Joachim Eastwood
From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Avoid local boilerplate.
Identified by coccinelle
CHECK drivers/iio/adc/lpc18xx_adc.c
drivers/iio/adc/lpc18xx_adc.c:137:1-10: WARNING: Use devm_platform_ioremap_resource for adc -> base
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Cc: Joachim Eastwood <manabian@gmail.com>
---
drivers/iio/adc/lpc18xx_adc.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/iio/adc/lpc18xx_adc.c b/drivers/iio/adc/lpc18xx_adc.c
index e400a95f553d..4c6ac6644dc0 100644
--- a/drivers/iio/adc/lpc18xx_adc.c
+++ b/drivers/iio/adc/lpc18xx_adc.c
@@ -119,7 +119,6 @@ static int lpc18xx_adc_probe(struct platform_device *pdev)
{
struct iio_dev *indio_dev;
struct lpc18xx_adc *adc;
- struct resource *res;
unsigned int clkdiv;
unsigned long rate;
int ret;
@@ -133,8 +132,7 @@ static int lpc18xx_adc_probe(struct platform_device *pdev)
adc->dev = &pdev->dev;
mutex_init(&adc->lock);
- res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
- adc->base = devm_ioremap_resource(&pdev->dev, res);
+ adc->base = devm_platform_ioremap_resource(pdev, 0);
if (IS_ERR(adc->base))
return PTR_ERR(adc->base);
--
2.23.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] iio: adc: lpc18xx: use devm_platform_ioremap_resource
2019-10-13 15:32 [PATCH] iio: adc: lpc18xx: use devm_platform_ioremap_resource jic23
@ 2019-11-04 15:19 ` Ardelean, Alexandru
2019-11-09 12:21 ` Jonathan Cameron
0 siblings, 1 reply; 3+ messages in thread
From: Ardelean, Alexandru @ 2019-11-04 15:19 UTC (permalink / raw)
To: jic23, linux-iio; +Cc: manabian, Jonathan.Cameron
On Sun, 2019-10-13 at 16:32 +0100, jic23@kernel.org wrote:
> From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
>
> Avoid local boilerplate.
> Identified by coccinelle
>
> CHECK drivers/iio/adc/lpc18xx_adc.c
> drivers/iio/adc/lpc18xx_adc.c:137:1-10: WARNING: Use
> devm_platform_ioremap_resource for adc -> base
Reviewed-by: Alexandru Ardelean <alexandru.ardelean@analog.com>
>
> Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> Cc: Joachim Eastwood <manabian@gmail.com>
> ---
> drivers/iio/adc/lpc18xx_adc.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/iio/adc/lpc18xx_adc.c
> b/drivers/iio/adc/lpc18xx_adc.c
> index e400a95f553d..4c6ac6644dc0 100644
> --- a/drivers/iio/adc/lpc18xx_adc.c
> +++ b/drivers/iio/adc/lpc18xx_adc.c
> @@ -119,7 +119,6 @@ static int lpc18xx_adc_probe(struct platform_device
> *pdev)
> {
> struct iio_dev *indio_dev;
> struct lpc18xx_adc *adc;
> - struct resource *res;
> unsigned int clkdiv;
> unsigned long rate;
> int ret;
> @@ -133,8 +132,7 @@ static int lpc18xx_adc_probe(struct platform_device
> *pdev)
> adc->dev = &pdev->dev;
> mutex_init(&adc->lock);
>
> - res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - adc->base = devm_ioremap_resource(&pdev->dev, res);
> + adc->base = devm_platform_ioremap_resource(pdev, 0);
> if (IS_ERR(adc->base))
> return PTR_ERR(adc->base);
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] iio: adc: lpc18xx: use devm_platform_ioremap_resource
2019-11-04 15:19 ` Ardelean, Alexandru
@ 2019-11-09 12:21 ` Jonathan Cameron
0 siblings, 0 replies; 3+ messages in thread
From: Jonathan Cameron @ 2019-11-09 12:21 UTC (permalink / raw)
To: Ardelean, Alexandru; +Cc: linux-iio, manabian, Jonathan.Cameron
On Mon, 4 Nov 2019 15:19:33 +0000
"Ardelean, Alexandru" <alexandru.Ardelean@analog.com> wrote:
> On Sun, 2019-10-13 at 16:32 +0100, jic23@kernel.org wrote:
> > From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> >
> > Avoid local boilerplate.
> > Identified by coccinelle
> >
> > CHECK drivers/iio/adc/lpc18xx_adc.c
> > drivers/iio/adc/lpc18xx_adc.c:137:1-10: WARNING: Use
> > devm_platform_ioremap_resource for adc -> base
>
> Reviewed-by: Alexandru Ardelean <alexandru.ardelean@analog.com>
Applied,
Thanks,
Jonathan
>
> >
> > Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> > Cc: Joachim Eastwood <manabian@gmail.com>
> > ---
> > drivers/iio/adc/lpc18xx_adc.c | 4 +---
> > 1 file changed, 1 insertion(+), 3 deletions(-)
> >
> > diff --git a/drivers/iio/adc/lpc18xx_adc.c
> > b/drivers/iio/adc/lpc18xx_adc.c
> > index e400a95f553d..4c6ac6644dc0 100644
> > --- a/drivers/iio/adc/lpc18xx_adc.c
> > +++ b/drivers/iio/adc/lpc18xx_adc.c
> > @@ -119,7 +119,6 @@ static int lpc18xx_adc_probe(struct platform_device
> > *pdev)
> > {
> > struct iio_dev *indio_dev;
> > struct lpc18xx_adc *adc;
> > - struct resource *res;
> > unsigned int clkdiv;
> > unsigned long rate;
> > int ret;
> > @@ -133,8 +132,7 @@ static int lpc18xx_adc_probe(struct platform_device
> > *pdev)
> > adc->dev = &pdev->dev;
> > mutex_init(&adc->lock);
> >
> > - res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> > - adc->base = devm_ioremap_resource(&pdev->dev, res);
> > + adc->base = devm_platform_ioremap_resource(pdev, 0);
> > if (IS_ERR(adc->base))
> > return PTR_ERR(adc->base);
> >
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-11-09 12:21 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-13 15:32 [PATCH] iio: adc: lpc18xx: use devm_platform_ioremap_resource jic23
2019-11-04 15:19 ` Ardelean, Alexandru
2019-11-09 12:21 ` Jonathan Cameron
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).