From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,MSGID_FROM_MTA_HEADER,NICE_REPLY_A,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 190AEC433E7 for ; Fri, 28 Aug 2020 06:58:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D29D520C56 for ; Fri, 28 Aug 2020 06:58:17 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=axentia.se header.i=@axentia.se header.b="nXXE/Qfp" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726834AbgH1G6N (ORCPT ); Fri, 28 Aug 2020 02:58:13 -0400 Received: from mail-eopbgr140092.outbound.protection.outlook.com ([40.107.14.92]:52291 "EHLO EUR01-VE1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725858AbgH1G6N (ORCPT ); Fri, 28 Aug 2020 02:58:13 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IIz7Fu+yZ3b5THFZsuUsfMDAsayXJa8BaU+11On0HFrTppBKncKviTdk+NLXrK1zpKbu75YM0aC5QINjpxwKNy3EtOG9tT/TufIJXrOkteY3pOw8hrYbivtsEB2Dtauij8o4BZusBOysECwRCRrILcYSgsjRdUPs6sn7ymVf+Iy10JO5qVyAejqt3tp4nMdHblSTV45lCtrrO16Gf1RRKYBY04xUxNoqhod9kPRzi5GSuGW0KJsojEAiUSiPY50+IcuLGjph0fsJujC1sN1GKHR9d3yr+bLzV8Vdgc4ZopqGVaeIuUuwktXwW0gjU5cdbUBrvjXHfHnR2hU5fk1DNQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9KRb96wl2T4hMJBzukUzjnRhfzg3OSt8Ap2LJZs9XCM=; b=gjIg3iYEdWUqIcsWMokxZsUW90iLI9igzqAPaK8AcPfVuSsr19ZoHZhl5Qa89gjWvivmDuhM4kJ+amqTiHMauO3SV+l2bfrejXHUXrjf/GTpmrEtipCT6qKAxbQ9cIP7Xj10YGe0pLTnFxX8/mTlvUaEIc4rtOtPLaw23Xa4wNLREgN/el7UUajv9/g5TLCJpjU0V8DYw5xXrQQq4+4U96miUNBqAupBI9JVhYLthVjA2wtCqJQQkTWLMb1IJrNrKRgWdwqGE4MA/3PAkC3EAn0R6ALnT5XoDpfrKhKXLVPh5vu+LLtm9EHT0e6vx2R60vddwRSYL6rfFJV50xayhg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=axentia.se; dmarc=pass action=none header.from=axentia.se; dkim=pass header.d=axentia.se; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=axentia.se; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9KRb96wl2T4hMJBzukUzjnRhfzg3OSt8Ap2LJZs9XCM=; b=nXXE/QfpFZgnR1PBJpvspzMOW7GnRbXk1/jkH2kNLmes+5O/WoWSHMHh06RtN1gTGmaV1Dhi6vQ4KzmF/Z3Ij0Gnt2jCljkk8+7w/xCO+p5SX56SYf7/DWCnvoN9fGmRf3LFepEoDMTEeVHqh7vAAftK2/ZBh/asiqiV0munGpE= Authentication-Results: st-md-mailman.stormreply.com; dkim=none (message not signed) header.d=none;st-md-mailman.stormreply.com; dmarc=none action=none header.from=axentia.se; Received: from DB8PR02MB5482.eurprd02.prod.outlook.com (2603:10a6:10:eb::29) by DB6PR0202MB2920.eurprd02.prod.outlook.com (2603:10a6:4:ab::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3326.22; Fri, 28 Aug 2020 06:58:02 +0000 Received: from DB8PR02MB5482.eurprd02.prod.outlook.com ([fe80::3890:7b1:97a6:1e47]) by DB8PR02MB5482.eurprd02.prod.outlook.com ([fe80::3890:7b1:97a6:1e47%7]) with mapi id 15.20.3326.021; Fri, 28 Aug 2020 06:58:02 +0000 Subject: Re: [PATCH v2 09/18] iio: afe: iio-rescale: Simplify with dev_err_probe() To: Krzysztof Kozlowski Cc: Jonathan Cameron , Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald-Stadler , Kukjin Kim , Michael Hennerich , Kevin Hilman , Neil Armstrong , Jerome Brunet , Martin Blumenstingl , Marek Vasut , Maxime Coquelin , Alexandre Torgue , Beniamin Bia , Tomasz Duszynski , Linus Walleij , Andy Shevchenko , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com References: <20200827192642.1725-1-krzk@kernel.org> <20200827192642.1725-9-krzk@kernel.org> <20200828062443.GA17343@pi3> From: Peter Rosin Organization: Axentia Technologies AB Message-ID: <3a5cb59b-454e-2c3f-9f31-43147e843c66@axentia.se> Date: Fri, 28 Aug 2020 08:57:57 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 In-Reply-To: <20200828062443.GA17343@pi3> Content-Type: text/plain; charset=utf-8 Content-Language: sv-SE Content-Transfer-Encoding: 7bit X-ClientProxiedBy: HE1PR07CA0010.eurprd07.prod.outlook.com (2603:10a6:7:67::20) To DB8PR02MB5482.eurprd02.prod.outlook.com (2603:10a6:10:eb::29) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from [192.168.13.3] (85.226.217.78) by HE1PR07CA0010.eurprd07.prod.outlook.com (2603:10a6:7:67::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3348.5 via Frontend Transport; Fri, 28 Aug 2020 06:58:00 +0000 X-Originating-IP: [85.226.217.78] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 74471e62-3316-4233-cb5e-08d84b1fb4f7 X-MS-TrafficTypeDiagnostic: DB6PR0202MB2920: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:4502; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: rQRQ8du2p6sW+W6Q+QOIo01jR2+LFAIOZ1ql56tZwqr6doF7NjvdpwD8nBDGleQPPnBqFHUV/4hgOlAb90LjwbV/z6EKwtWfw0/9mrDcdfZNfqP0+46qmSaWKXx19Qjzz4MqHdIy3WAi99rCLD635F6pTgJskx27RNKn6YOOeRSmE9gs8KpP3zXfpskvG58p427vs9HXWsp2FO8kr3gonu4+ASf9bFLyjOSAzJfFvlgJ103bX5i9+YUHT2yrgHFb8xAG748aiXdQC3K2MKmwZ2x+VEYlTJENzaf2krIhJezhpId8DOy+T3lv88H1cv67uKBUJbmCfWehg4JOhovPdNnxteiF2GEhZ514E+p5lu/NO07Nahm4cTj4SoKBpOuG X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB8PR02MB5482.eurprd02.prod.outlook.com;PTR:;CAT:NONE;SFS:(346002)(136003)(366004)(376002)(39830400003)(396003)(2616005)(956004)(7416002)(6666004)(8936002)(8676002)(16576012)(6486002)(316002)(54906003)(16526019)(31696002)(2906002)(36916002)(52116002)(4326008)(5660300002)(26005)(478600001)(53546011)(66556008)(6916009)(66476007)(31686004)(86362001)(66946007)(36756003)(83380400001)(186003)(43740500002);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData: IrhIL4PVGKeLslVTvd2cUyagVkMhvCb6mY/wxoU3N250LxKeAVcrWrinNJGP5nc+6O06vdfwrqW9Caw6jbbRo5S/hNldGtjkKGRRoFGpzdk6wWXaa3O6ZqFTdTRrZ3dJtXqXvRsnbryKRShaa2n4/56sPn+FZ4kK6Gcessu6goX32+zJGK6reneibqN5C6R8LzmUJJ19vprxLtOCfh2rH0FVVFtXnaxiTf0xH5CczBNfDo5f27TnQUUyaxI/VVpoc+oeXWxnfQ+CxSfN39lR2t4jfoO0flW543cLVG0q46I5jfEnv8ZmQIIEEd3y/EiwCBFEG1dtKASDUlvRToYW86VdqOO3lP90CkBwVxtf/8vXxo7BTM3YDr4N3gYYtJJli8x4q5xW485+LEGFg3dLrjaMjIqJ6XabovwZSGgyKgrA3Ak5NEMB0Ql/hgYlNg6p0oSv02wXFzyMeZPHW8nfRyJMjJYXCSJkNiO/0iAvVtxGi3TUwRojNGrFZ5GHaWYksptCHrkjLLLfa4mfxOwhlm/XxjTTCcm35NyC8Mo+NAbF1x9nEgd+fDEGbSfOPt7Gxn0VziefMIEIBAlkXLh/qBbkuZoi8UzgUcMDFy898+ORrCugPz4LXu3TRJOSDPM+YaFbfmcQw+uK+LkU8GyOGA== X-OriginatorOrg: axentia.se X-MS-Exchange-CrossTenant-Network-Message-Id: 74471e62-3316-4233-cb5e-08d84b1fb4f7 X-MS-Exchange-CrossTenant-AuthSource: DB8PR02MB5482.eurprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Aug 2020 06:58:02.8181 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4ee68585-03e1-4785-942a-df9c1871a234 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 0YMwqatNergbB9BWksiekUOs6Xga7AOB63bDMUg3mcyBd3zZxUmPcuB8Tu1xZsHx X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0202MB2920 Sender: linux-iio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org On 2020-08-28 08:24, Krzysztof Kozlowski wrote: > On Thu, Aug 27, 2020 at 11:46:40PM +0200, Peter Rosin wrote: >> On 2020-08-27 21:26, Krzysztof Kozlowski wrote: >>> Common pattern of handling deferred probe can be simplified with >>> dev_err_probe(). Less code and also it prints the error value. >>> >>> Signed-off-by: Krzysztof Kozlowski >>> >>> --- >>> >>> Changes since v1: >>> 1. Wrap dev_err_probe() lines at 100 character >>> --- >>> drivers/iio/afe/iio-rescale.c | 7 ++----- >>> 1 file changed, 2 insertions(+), 5 deletions(-) >>> >>> diff --git a/drivers/iio/afe/iio-rescale.c b/drivers/iio/afe/iio-rescale.c >>> index 69c0f277ada0..8cd9645c50e8 100644 >>> --- a/drivers/iio/afe/iio-rescale.c >>> +++ b/drivers/iio/afe/iio-rescale.c >>> @@ -276,11 +276,8 @@ static int rescale_probe(struct platform_device *pdev) >>> int ret; >>> >>> source = devm_iio_channel_get(dev, NULL); >>> - if (IS_ERR(source)) { >>> - if (PTR_ERR(source) != -EPROBE_DEFER) >>> - dev_err(dev, "failed to get source channel\n"); >>> - return PTR_ERR(source); >>> - } >>> + if (IS_ERR(source)) >>> + return dev_err_probe(dev, PTR_ERR(source), "failed to get source channel\n"); >> >> Hi! >> >> Sorry to be a pain...but... >> >> I'm not a huge fan of adding *one* odd line breaking the 80 column >> recommendation to any file. I like to be able to fit multiple >> windows side by side in a meaningful way. Also, I don't like having >> a shitload of emptiness on my screen, which is what happens when some >> lines are longer and you want to see it all. I strongly believe that >> the 80 column rule/recommendation is still as valid as it ever was. >> It's just hard to read longish lines; there's a reason newspapers >> columns are quite narrow... >> >> Same comment for the envelope-detector (3/18). >> >> You will probably never look at these files again, but *I* might have >> to revisit them for one reason or another, and these long lines will >> annoy me when that happens. > > Initially I posted it with 80-characters wrap. Then I received a comment > - better to stick to the new 100, as checkpatch accepts it. > > Now you write, better to go back to 80. > > Maybe then someone else will write to me, better to go to 100. > > And another person will reply, no, coding style still mentions 80, so > keep it at 80. > > Sure guys, please first decide which one you prefer, then I will wrap it > accordingly. :) > > Otherwise I will just jump from one to another depending on one person's > personal preference. > > If there is no consensus among discussing people, I find this 100 line > more readable, already got review, checkpatch accepts it so if subsystem > maintainer likes it, I prefer to leave it like this. I'm not impressed by that argument. For the files I have mentioned, it does not matter very much to me if you and some random person think that 100 columns might *slightly* improve readability. Quoting coding-style Statements longer than 80 columns should be broken into sensible chunks, unless exceeding 80 columns significantly increases readability and does not hide information. Notice that word? *significantly* Why do I even have to speak up about this? WTF? For the patches that touch files that I originally wrote [1], my preference should be clear by now. Cheers, Peter [1] drivers/iio/adc/envelope-detector.c drivers/iio/afe/iio-rescale.c drivers/iio/dac/dpot-dac.c drivers/iio/multiplexer/iio-mux.c >> You did wrap the lines for dpot-dac (12/18) - which is excellent - but >> that makes me curious as to what the difference is? > > Didn't fit into limit of 100.