From: sebastien bourdelin <sebastien.bourdelin@gmail.com>
To: Jonathan Cameron <jic23@kernel.org>
Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
linux-iio@vger.kernel.org, himanshujha199640@gmail.com,
mark.rutland@arm.com, robh+dt@kernel.org, pmeerw@pmeerw.net,
lars@metafoo.de, knaack.h@gmx.de
Subject: Re: [PATCH v2 1/2] iio: chemical: bme680: Add device-tree support
Date: Mon, 14 Jan 2019 15:01:41 -0500 [thread overview]
Message-ID: <44dd6866-07fa-83cb-19d8-e35a5aa989a0@gmail.com> (raw)
In-Reply-To: <20190112182221.4765d287@archlinux>
Hi,
On 1/12/19 1:22 PM, Jonathan Cameron wrote:
> On Fri, 11 Jan 2019 15:53:58 -0500
> Sebastien Bourdelin <sebastien.bourdelin@gmail.com> wrote:
>
>> This commit allow the driver to work with device-tree.
>>
>> Signed-off-by: Sebastien Bourdelin <sebastien.bourdelin@gmail.com>
> Minor stuff inline.
>
> J
>> ---
>> v1 -> v2:
>> - add missing of.h header in bme680_spi.c
>> ---
>> drivers/iio/chemical/bme680_i2c.c | 7 +++++++
>> drivers/iio/chemical/bme680_spi.c | 9 +++++++++
>> 2 files changed, 16 insertions(+)
>>
>> diff --git a/drivers/iio/chemical/bme680_i2c.c b/drivers/iio/chemical/bme680_i2c.c
>> index 06d4be539d2e..94a36ebdf0b2 100644
>> --- a/drivers/iio/chemical/bme680_i2c.c
>> +++ b/drivers/iio/chemical/bme680_i2c.c
>> @@ -70,10 +70,17 @@ static const struct acpi_device_id bme680_acpi_match[] = {
>> };
>> MODULE_DEVICE_TABLE(acpi, bme680_acpi_match);
>>
>> +static const struct of_device_id bme680_of_i2c_match[] = {
>> + { .compatible = "bosch,bme680", },
>> + {},
>> +}
>> +MODULE_DEVICE_TABLE(of, bme680_of_i2c_match);
>> +
>> static struct i2c_driver bme680_i2c_driver = {
>> .driver = {
>> .name = "bme680_i2c",
>> .acpi_match_table = ACPI_PTR(bme680_acpi_match),
>> + .of_match_table = of_match_ptr(bme680_of_i2c_match),
> As below. just = bme680...
Got it, thanks!
>
>> },
>> .probe = bme680_i2c_probe,
>> .id_table = bme680_i2c_id,
>> diff --git a/drivers/iio/chemical/bme680_spi.c b/drivers/iio/chemical/bme680_spi.c
>> index c9fb05e8d0b9..caa57287a911 100644
>> --- a/drivers/iio/chemical/bme680_spi.c
>> +++ b/drivers/iio/chemical/bme680_spi.c
>> @@ -6,9 +6,11 @@
>> */
>> #include <linux/acpi.h>
>> #include <linux/module.h>
>> +#include <linux/of.h>
>> #include <linux/regmap.h>
>> #include <linux/spi/spi.h>
>>
>> +
> This white space change should not be here.
My bad.
>> #include "bme680.h"
>>
>> static int bme680_regmap_spi_write(void *context, const void *data,
>> @@ -110,10 +112,17 @@ static const struct acpi_device_id bme680_acpi_match[] = {
>> };
>> MODULE_DEVICE_TABLE(acpi, bme680_acpi_match);
>>
>> +static const struct of_device_id bme680_of_spi_match[] = {
>> + { .compatible = "bosch,bme680", },
>> + {},
>> +}
>> +MODULE_DEVICE_TABLE(of, bme680_of_spi_match);
>> +
>> static struct spi_driver bme680_spi_driver = {
>> .driver = {
>> .name = "bme680_spi",
>> .acpi_match_table = ACPI_PTR(bme680_acpi_match),
>> + .of_match_table = of_match_ptr(bme680_of_spi_match),
> Please don't use of_match_ptr. We actually want this entry to be there even
> if devicetree is not in use. This is because there is a magic ACPI hid
> that can use this table even from ACPI.
>
Sure.
>> },
>> .probe = bme680_spi_probe,
>> .id_table = bme680_spi_id,
prev parent reply other threads:[~2019-01-14 20:02 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-11 20:53 [PATCH v2 1/2] iio: chemical: bme680: Add device-tree support Sebastien Bourdelin
2019-01-11 20:53 ` [PATCH v2 2/2] dt-bindings: iio: chemical: Add bindings for bme680 Sebastien Bourdelin
2019-01-12 18:28 ` Jonathan Cameron
2019-01-14 20:17 ` sebastien bourdelin
2019-01-19 16:57 ` Jonathan Cameron
2019-01-21 21:43 ` sebastien bourdelin
2019-01-12 9:42 ` [PATCH v2 1/2] iio: chemical: bme680: Add device-tree support Himanshu Jha
2019-01-12 18:25 ` Jonathan Cameron
2019-01-14 20:00 ` sebastien bourdelin
2019-01-15 18:41 ` Himanshu Jha
2019-01-16 22:31 ` Sebastien Bourdelin
2019-01-12 18:22 ` Jonathan Cameron
2019-01-14 20:01 ` sebastien bourdelin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44dd6866-07fa-83cb-19d8-e35a5aa989a0@gmail.com \
--to=sebastien.bourdelin@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=himanshujha199640@gmail.com \
--cc=jic23@kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pmeerw@pmeerw.net \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).