From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BE591ECAAD8 for ; Wed, 21 Sep 2022 19:11:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229456AbiIUTL6 (ORCPT ); Wed, 21 Sep 2022 15:11:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52592 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229624AbiIUTL5 (ORCPT ); Wed, 21 Sep 2022 15:11:57 -0400 Received: from mail-lf1-x12b.google.com (mail-lf1-x12b.google.com [IPv6:2a00:1450:4864:20::12b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9917E71727 for ; Wed, 21 Sep 2022 12:11:55 -0700 (PDT) Received: by mail-lf1-x12b.google.com with SMTP id a2so10834119lfb.6 for ; Wed, 21 Sep 2022 12:11:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date; bh=DsL/1QAW5Bz74NZ7JK4PQf/yeBCXaXFI7fLPgzIIgJ4=; b=QTCIWf1sf8YYJTHRUCzPsvcipWx3NlPq4la99JrxuUSJ6+dCeA1P9nVQtc/kmAHl7Y DM9So4VlJzfCgzpKxBSGKyQPEZJyDkAgL1++XZY3kDeYKTJQCvVZl9TvlsqBZmvVhmb9 JLVBswq48TeMuQRgDGiiSiPGYeJ0jY7TkuAsNfZsqwjrn1eed2dr2ny0+VQIb78q9ie6 ANrQpu6eG1QRDEiC5tPQMyFgOBrZAa+ofcrIPPiSPo7N+Am4U+cc78FVwCBOBw1b3bqD b2r9+3mw4L0fe6hlSUyrxV4e0A670NyLbcuPfNh1menjQTxQ0xtOzRsV6yDB9j5A2Ce6 5v7g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date; bh=DsL/1QAW5Bz74NZ7JK4PQf/yeBCXaXFI7fLPgzIIgJ4=; b=n5yZMdfwBfmfc4WVROST+Z8OmyDs1sy1ozPaFWzHFvYEuqbRZhZKUnwGGLc15XGMqQ pM43WgVXriDOgUrfTlr05Or2nFv3Qk2KQ3gw7B0UwfKwKI2p5Qz1FSIuEU8pxURLit4+ zwFh7TVH4dkCGYa6xYEj8aaju/igfMfnh8/t2685N9PtZNVuCWkX3r77BzvJoCKk1jwM YmnHYzrKwbrPOHol9g79ILiVXbd67p3YwI8HNTrhOmxUjPGH/6c+MKeLIuWwJrbp9v3R e2I+w1W/SkFkuoEBmx2Ip/gdS/ykhboc1Vy7RVWDYtcMZyqCBMDwpgcklHeVXbczMLgo QYyQ== X-Gm-Message-State: ACrzQf1BOjKmTLPCRceMSG5q+kRqQBAnSYg34OuVcp5uCEZzzW35LiNR q+z7LgB1ZxnA98/uHid04SOUHA== X-Google-Smtp-Source: AMsMyM5JtXoqCMkS9rVMqv5o56OnDmtdacZs1FE4sReyzPtkUfqOz9nwTvu+zeti+lCGbtRNZmO3vQ== X-Received: by 2002:a05:6512:2006:b0:49f:6087:124a with SMTP id a6-20020a056512200600b0049f6087124amr9099091lfb.163.1663787513970; Wed, 21 Sep 2022 12:11:53 -0700 (PDT) Received: from [192.168.0.21] (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id k10-20020ac257ca000000b004998d9ccb62sm557803lfo.99.2022.09.21.12.11.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 21 Sep 2022 12:11:53 -0700 (PDT) Message-ID: <482c5a54-3d53-5760-fc8e-8aa3b9341707@linaro.org> Date: Wed, 21 Sep 2022 21:11:52 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: [RFC PATCH 3/5] dt-bindings: iio: Add KX022A accelerometer Content-Language: en-US To: Matti Vaittinen , Matti Vaittinen Cc: Jonathan Cameron , Lars-Peter Clausen , Rob Herring , Krzysztof Kozlowski , Andy Shevchenko , Nikita Yushchenko , Cosmin Tanislav , Jagath Jog J , linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org On 21/09/2022 13:45, Matti Vaittinen wrote: > KX022A is a 3-axis Accelerometer from ROHM/Kionix. The senor features > include variable ODRs, I2C and SPI control, FIFO/LIFO with watermark IRQ, Thank you for your patch. There is something to discuss/improve. > tap/motion detection, wake-up & back-to-sleep events, four acceleration > ranges (2, 4, 8 and 16g) and probably some other cool fatures. s/fatures/features/ > +$id: http://devicetree.org/schemas/iio/accel/kionix,kx022a.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: ROHM/Kionix KX022A Accelerometer bindings Drop "bindings" > + > +maintainers: > + - Matti Vaittinen > + > +description: | > + KX022A is a 3-axis accelerometer supporting +/- 2G, 4G, 8G and 16G ranges, > + output data-rates from 0.78Hz to 1600Hz and a hardware-fifo buffering. > + KX022A can be accessed either via I2C or SPI. > + > +properties: > + compatible: kionix,kx022a Missing const. I wonder how did it pass testing... > + > + reg: > + description: > + I2C slave address or SPI chip-select. Skip description, it's obvious. > + maxItems: 1 > + > + interrupts: > + maxItems: 1 > + > + vdd-supply: true > + io_vdd-supply: true No underscores, so io-vdd-supply > + > + mount-matrix: > + description: | > + an optional 3x3 mounting rotation matrix. > + > +required: > + - compatible > + - reg > + - interrupts > + > +additionalProperties: false > + > +examples: > + - | > + #include > + i2c { > + #address-cells = <1>; > + #size-cells = <0>; > + accel@1f { Messed up indentation. > + compatible = "kionix,kx022a"; > + reg = <0x1f>; Best regards, Krzysztof