From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CBCE4C4361A for ; Sat, 5 Dec 2020 21:06:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8E764230F9 for ; Sat, 5 Dec 2020 21:06:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726855AbgLEVGS (ORCPT ); Sat, 5 Dec 2020 16:06:18 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37938 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725270AbgLEVGR (ORCPT ); Sat, 5 Dec 2020 16:06:17 -0500 Received: from mail-lj1-x243.google.com (mail-lj1-x243.google.com [IPv6:2a00:1450:4864:20::243]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AA2EBC0613D4 for ; Sat, 5 Dec 2020 13:05:36 -0800 (PST) Received: by mail-lj1-x243.google.com with SMTP id y16so10707747ljk.1 for ; Sat, 05 Dec 2020 13:05:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=l7PcuRvH2lvNTCeViNhB8nA3QkFXJkV9Gl2IRDNWkAw=; b=VKbz9r/11ppxewhAL3MRcb/GtaNpPtPYglYTdQDNmV0TCXIFdrgcgMtkArIqGTjpK7 UejGaSzbAOJ2VsO+HniC52RRbh3zRcocpAwHidbbQL+lV4MhGXb21C5vgNi7NbjWhihv RKpFyCje/tVLzFokQhPrO3m7BfSWIMANQusS6nsfGqZkdfo5fF5ruIq5Yv8a4TDAJmx3 L9d1POmHfSKtCXYfWHc8XBxvBoLAJ+lvUQOVFOlYDR4146NiO5CIFUUI3FU/jTjV8AIF k5pBy0Z+4wbfCFxYZXA30GpXUXDLRZzyQ8kiqdL4kW9dfMHcc0gf9wvq7mEuMlxkjLN9 kSfg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=l7PcuRvH2lvNTCeViNhB8nA3QkFXJkV9Gl2IRDNWkAw=; b=V1F3BFNSTGLAjt6ANw+2dDathXGcpfC1vYxdaRigQHrBWm5GDXFDqD0JZOetq+quiT QjVMv0Nna0Vok23en/hql0cq3zPlAuChSkRc/TSqlxAam3E2I1yLTknNJW4nhMnm/pkn cvzB9dyhW03GOloFiHUArOXcz8MYjiQY+vcMfTNC+eEX9pXsgIyGvKXx/cBBdLi/Z2I4 Z6hKO+l/E9YEHJRvH2wvUY2o/v8L9ZknJg6KTwEz0kicg8AdOlFOLAhCIuBkBWhw6FP8 w1GwAxel15F0KWzFZjgKhoUtUkGjbUuxJPozW1ED1737kHtTdIdWcE3HKAw7uQZYvaNG novQ== X-Gm-Message-State: AOAM530l5ARCok7ltK/sTZCJMczt/L7dA0F9H+Pb2O+F8Cq5A4axtgQb DeYqYvKVm5L3G/AxQ2eBSyVQtg== X-Google-Smtp-Source: ABdhPJxUfR3PGDS+RKxcbacmYSpIPDJpurEtbRQcNlhGoXkpPQ40eJomWsVIVOXgu0j4y+sfskWZFw== X-Received: by 2002:a2e:720c:: with SMTP id n12mr6257982ljc.424.1607202333043; Sat, 05 Dec 2020 13:05:33 -0800 (PST) Received: from [192.168.0.150] ([94.25.229.141]) by smtp.gmail.com with ESMTPSA id j27sm146451lfm.178.2020.12.05.13.05.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 05 Dec 2020 13:05:32 -0800 (PST) Subject: Re: [PATCH v10 00/15] qcom: pm8150: add support for thermal monitoring To: Jonathan Cameron Cc: Andy Gross , Bjorn Andersson , Rob Herring , Zhang Rui , Daniel Lezcano , Amit Kucheria , Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald-Stadler , linux-arm-msm@vger.kernel.org, linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linux-iio@vger.kernel.org, Manivannan Sadhasivam , Jishnu Prakash References: <20201204025509.1075506-1-dmitry.baryshkov@linaro.org> <20201205170830.4d56ecb7@archlinux> From: Dmitry Baryshkov Message-ID: <4de94396-54c7-e741-b288-3a3868515f7b@linaro.org> Date: Sun, 6 Dec 2020 00:05:29 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.5.0 MIME-Version: 1.0 In-Reply-To: <20201205170830.4d56ecb7@archlinux> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org On 05/12/2020 20:08, Jonathan Cameron wrote: > On Fri, 4 Dec 2020 05:54:54 +0300 > Dmitry Baryshkov wrote: > >> This patch serie adds support for thermal monitoring block on Qualcomm's >> PMIC5 chips. PM8150{,b,l} and sm8250-mtp board device trees are extended >> to support thermal zones provided by this thermal monitoring block. >> Unlike the rest of PMIC thermal senses, these thermal zones describe >> particular thermistors, which differ between from board to board. > > I've just taken another look through the various IIO parts in here and > I think they are fine. > > My assumption is that given the timing this isn't going to make the merge > window now. Hence I'll be looking to do an immutable branch based on rc1 > once it's available (assuming everyone else is fine with this version). Thank you! Another option might be to merge all iio changes this cycle (if it's fine with you) and have all the rest go via respective trees in the next merge window. I'm fine with either of the options. > > Thanks, > > Jonathan > >> >> Changes since v9: >> - In patch 12 add comments to the code as requested by Daniel Lezcano. >> - Change copyright comment in qcom-spmi-adc-tm5.c to clearly note >> driver history. >> >> Changes since v8: >> - Simplified qcom_vadc_map_voltage_temp() code by removing ascending >> tables support >> - Simplified qcom-vadc-common volt/temp mapping code >> - Implement suggestions by Matthias Kaehlcke: message formatting, >> rewrite comments, remove unused variable initialization. >> >> Changes since v7: >> - Move qcom-vadc-common.h header to include/linux/iio/adc/ dir. >> - Use explicit sizeof(var) instead of hand-coding 1 when accessing >> adc-tm registers. >> - Remove buffer read from adc_tm5_init(). >> - Remove extra on-stack var from adc_tm5_get_temp(). >> - Minor formatting changes as suggested Daniel. >> >> Changes since v6: >> - Added include as noted by Jishnu Prakash. >> >> Changes since v5: >> - Reworked DT bindings: >> * Removed qcom,adc-channel, instead it is parsed from io-channels >> * Renamed qcom,hw-settle-time to include -us suffix >> - Re-added monitor enabling which got lost during refactored. Noted by >> Jishnu Prakash. >> - Use threaded IRQ handler as susggested by Jishnu. >> >> Changes since v4: >> - Added kernel-doc comments to ADC-TM structures >> - Used several sizeof(buf) instead of hand-conding register size >> >> Changes since v3: >> - Fix DT description to spell "thermal monitoring" instead of just TM >> - Fix warnings in DT example >> - Add EXPORT_SYMBOL_GPL(of_iio_channel_get_by_name) >> - Fixed whitespace chanes in qcom-vadc-common.c >> - Removed error message if IIO chanel get returns -EPROBE_DEFER >> >> Changes since v2: >> - IIO: export of_iio_channel_get_by_name() function >> - dt-bindings: move individual io-channels to each thermal monitoring >> channel rather than listing them all in device node >> - added fallback defaults to of_device_get_match_data calls in >> qcom-spmi-adc5 and qcom-spmi-adc-tm5 drivers >> - minor typo fixes >> >> Changes since v1: >> - Introduce fixp_linear_interpolate() by Craig Tatlor >> - Lots of syntax/whitespace changes >> - Cleaned up register definitions per Jonathan's suggestion >> - Implemented most of the suggestions from Bjorn's and Jonathan's >> review >> >> > -- With best wishes Dmitry