From: David Lechner <david@lechnology.com>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: linux-iio@vger.kernel.org, linux-omap@vger.kernel.org,
devicetree@vger.kernel.org, "Rob Herring" <robh+dt@kernel.org>,
"Mark Rutland" <mark.rutland@arm.com>,
"Benoît Cousson" <bcousson@baylibre.com>,
"Tony Lindgren" <tony@atomide.com>,
"William Breathitt Gray" <vilhelm.gray@gmail.com>,
"Thierry Reding" <thierry.reding@gmail.com>,
linux-kernel@vger.kernel.org, linux-pwm@vger.kernel.org
Subject: Re: [PATCH 2/4] counter: new TI eQEP driver
Date: Tue, 30 Jul 2019 10:28:10 -0500 [thread overview]
Message-ID: <58ef00df-4d99-f4f2-0eda-01db2afe5502@lechnology.com> (raw)
In-Reply-To: <20190730123523.cjtmr3tpttn6r3pt@pengutronix.de>
On 7/30/19 7:35 AM, Uwe Kleine-König wrote:
> On Mon, Jul 22, 2019 at 10:45:36AM -0500, David Lechner wrote:
>> This adds a new counter driver for the Texas Instruments Enhanced
>> Quadrature Encoder Pulse (eQEP) module.
>>
>> Only very basic functionality is currently implemented - only enough to
>> be able to read the position. The actual device has many more features
>> which can be added to the driver on an as-needed basis.
>>
>> Signed-off-by: David Lechner <david@lechnology.com>
>> ---
>> MAINTAINERS | 6 +
>> drivers/counter/Kconfig | 12 ++
>> drivers/counter/Makefile | 1 +
>> drivers/counter/ti-eqep.c | 381 ++++++++++++++++++++++++++++++++++++++
>> drivers/pwm/Kconfig | 2 +-
>
> It's not obvious why the change to drivers/pwm/Kconfig is needed. Can
> you please motivate that in the change log?
Will do. The short version is that it is needed for power management.
>
> Best regards
> Uwe
>
next prev parent reply other threads:[~2019-07-30 15:28 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-22 15:45 [PATCH 0/4] new driver for TI eQEP David Lechner
2019-07-22 15:45 ` [PATCH 1/4] dt-bindings: counter: new bindings " David Lechner
2019-07-27 19:48 ` Jonathan Cameron
2019-08-02 7:25 ` William Breathitt Gray
2019-08-02 13:34 ` Rob Herring
2019-08-02 13:58 ` William Breathitt Gray
2019-07-22 15:45 ` [PATCH 2/4] counter: new TI eQEP driver David Lechner
2019-07-30 12:35 ` Uwe Kleine-König
2019-07-30 15:28 ` David Lechner [this message]
2019-08-02 9:27 ` William Breathitt Gray
2019-08-02 16:09 ` David Lechner
2019-08-02 16:17 ` David Lechner
2019-08-02 16:40 ` William Breathitt Gray
2019-07-22 15:45 ` [PATCH 3/4] ARM: dts: am33xx: Add nodes for eQEP David Lechner
2019-07-23 8:42 ` Tony Lindgren
2019-07-23 14:45 ` David Lechner
2019-07-23 14:51 ` Tony Lindgren
2019-07-22 15:45 ` [PATCH 4/4] ARM: dts: am335x-boneblue: Enable eQEP David Lechner
2019-07-25 12:40 ` [PATCH 0/4] new driver for TI eQEP William Breathitt Gray
2019-07-25 22:52 ` David Lechner
2019-07-27 19:45 ` Jonathan Cameron
2019-07-30 4:45 ` William Breathitt Gray
2019-08-01 17:37 ` David Lechner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=58ef00df-4d99-f4f2-0eda-01db2afe5502@lechnology.com \
--to=david@lechnology.com \
--cc=bcousson@baylibre.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=thierry.reding@gmail.com \
--cc=tony@atomide.com \
--cc=u.kleine-koenig@pengutronix.de \
--cc=vilhelm.gray@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).