From: dinghao.liu@zju.edu.cn
To: "Linus Walleij" <linus.walleij@linaro.org>
Cc: "Kangjie Lu" <kjlu@umn.edu>,
"Jonathan Cameron" <jic23@kernel.org>,
"Hartmut Knaack" <knaack.h@gmx.de>,
"Lars-Peter Clausen" <lars@metafoo.de>,
"Peter Meerwald-Stadler" <pmeerw@pmeerw.net>,
linux-iio <linux-iio@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: Re: Re: [PATCH] iio: magnetometer: ak8974: Fix runtime PM imbalance on error
Date: Tue, 26 May 2020 18:05:49 +0800 (GMT+08:00) [thread overview]
Message-ID: <5ad23cba.d1763.172507207bb.Coremail.dinghao.liu@zju.edu.cn> (raw)
In-Reply-To: <CACRpkdYr7mprhK9rdWEfuuwb7hxxc5aS5LZqKf4x5OgMrvh4CQ@mail.gmail.com>
> What about just moving the pm_runtime_put() until the end
> of the initialization? Right before return 0;
> Then we can keep this nice goto exits as they are.
>
> Maybe move all these three:
>
> pm_runtime_set_autosuspend_delay(&i2c->dev,
> AK8974_AUTOSUSPEND_DELAY);
> pm_runtime_use_autosuspend(&i2c->dev);
> pm_runtime_put(&i2c->dev);
>
Good idea! Thank you for your advice and I will fix this
in the next version of patch.
Regards,
Dinghao
prev parent reply other threads:[~2020-05-26 10:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-24 2:51 [PATCH] iio: magnetometer: ak8974: Fix runtime PM imbalance on error Dinghao Liu
2020-05-25 12:08 ` Linus Walleij
2020-05-26 5:14 ` dinghao.liu
2020-05-26 9:31 ` Linus Walleij
2020-05-26 10:05 ` dinghao.liu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5ad23cba.d1763.172507207bb.Coremail.dinghao.liu@zju.edu.cn \
--to=dinghao.liu@zju.edu.cn \
--cc=jic23@kernel.org \
--cc=kjlu@umn.edu \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linus.walleij@linaro.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).