From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DB644C433ED for ; Sun, 25 Apr 2021 16:39:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B350E60232 for ; Sun, 25 Apr 2021 16:39:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230459AbhDYQjr (ORCPT ); Sun, 25 Apr 2021 12:39:47 -0400 Received: from www381.your-server.de ([78.46.137.84]:37298 "EHLO www381.your-server.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230359AbhDYQjr (ORCPT ); Sun, 25 Apr 2021 12:39:47 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=metafoo.de; s=default2002; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Subject:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID; bh=Gj39ngogjE+FQvOJAZ/GHerQf+5P+gRgb18qkF+HHm4=; b=EX6CfZfq9LxrWsivCQC/jvnxh6 rmFBe/yuQjvve1FptPBGbW9QF60IMpHv8a1/zrO/a5bXqKlrx3/5DI3z+buM4FiO+Op4Ir9Vap2tb u5lXfKEJIKtQXJqaZSJhZWag1CWyck/YGIswMQDV2pPFIIbWfY4FG79RoSUDyDhWyc1KFPTl0CUR2 +ELa65106e5VaegDgNeG+aQevwKhqFMzcjG+UlyOCEGqrRIvWpndEZrN8uZI0j9OpSQxpx+CJGiiW ZItk6nhhR7ix82pPId5oe1cGjxmWfdP2Z0jBg8+A4I5zJ+ITyh1WAoHwkbKcnmUWP3xPbQgXZMb40 WYRh6ZYQ==; Received: from sslproxy03.your-server.de ([88.198.220.132]) by www381.your-server.de with esmtpsa (TLSv1.3:TLS_AES_256_GCM_SHA384:256) (Exim 4.92.3) (envelope-from ) id 1lahmh-0002DP-JI; Sun, 25 Apr 2021 18:39:03 +0200 Received: from [2001:a61:2a42:9501:9e5c:8eff:fe01:8578] by sslproxy03.your-server.de with esmtpsa (TLSv1.3:TLS_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lahmh-000NHA-DA; Sun, 25 Apr 2021 18:39:03 +0200 Subject: Re: [PATCH v4 1/2] iio:adc:ad7476: Handle the different regulators used by various parts. To: Jonathan Cameron , linux-iio@vger.kernel.org, Rob Herring Cc: devicetree@vger.kernel.org, Jonathan Cameron , Michael Hennerich , kernel test robot References: <20210425163154.73209-1-jic23@kernel.org> <20210425163154.73209-2-jic23@kernel.org> From: Lars-Peter Clausen Message-ID: <662ed93c-7567-7acb-15c4-5526af80209e@metafoo.de> Date: Sun, 25 Apr 2021 18:39:03 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.0 MIME-Version: 1.0 In-Reply-To: <20210425163154.73209-2-jic23@kernel.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-Authenticated-Sender: lars@metafoo.de X-Virus-Scanned: Clear (ClamAV 0.103.2/26151/Sun Apr 25 13:05:06 2021) Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org On 4/25/21 6:31 PM, Jonathan Cameron wrote: > From: Jonathan Cameron > > Not all of the parts supported by this driver use single supply. > Hence we add chip_info fields to say what additional supplies exist > and in the case of vref, ensure that is used for the reference voltage > rather than vcc. > > One corner case is the ad7091r which has an internal reference that > can be over-driven by an external reference connected on the vref pin. > To handle that force_ext_vref is introduced and set if an optional > vref regulator is present. > > Tested using really simple QEMU model and some fixed regulators. > > The devm_add_action_or_reset() callback is changed to take the > regulator as it's parameter so we can use one callback for all the > different regulators without having to store pointers to them in > the iio_priv() structure. > > Signed-off-by: Jonathan Cameron > Cc: Michael Hennerich > Reported-by: kernel test robot Reviewed-by: Lars-Peter Clausen