linux-iio.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Sean Nyekjaer <sean@geanix.com>
To: Lorenzo Bianconi <lorenzo@kernel.org>
Cc: linux-iio@vger.kernel.org, jic23@kernel.org,
	lorenzo.bianconi83@gmail.com, denis.ciocca@st.com,
	mario.tesi@st.com, armando.visconti@st.com, martin@geanix.com
Subject: Re: [PATCH v7 3/5] iio: imu: st_lsm6dsx: add wakeup-source option
Date: Fri, 13 Sep 2019 10:43:50 +0200	[thread overview]
Message-ID: <66e35f99-780b-7063-37ad-3fb656a6dffc@geanix.com> (raw)
In-Reply-To: <20190913082701.GA2698@localhost.localdomain>



On 13/09/2019 10.27, Lorenzo Bianconi wrote:
>>
>>
>> On 12/09/2019 09.06, Sean Nyekjaer wrote:
>>> This add ways for the SoC to wake from accelerometer wake events.
>>>
>>> In the suspend function we skip disabling the sensor if wakeup-source
>>> and events are activated.
>>>
>>> Signed-off-by: Sean Nyekjaer <sean@geanix.com>
>>> ---
>>> Changes since v4:
>>>    * More devices supports wakeup
>>>
>>> Changes since v5:
>>>    * None
>>>
>>> Changes since v6:
>>>    * None
>>>
>>>    drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c | 14 ++++++++++++++
>>>    1 file changed, 14 insertions(+)
>>>
>>> diff --git a/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c b/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c
>>> index 4198ba263d03..f79978a2870f 100644
>>> --- a/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c
>>> +++ b/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c
>>> @@ -1858,6 +1858,9 @@ int st_lsm6dsx_probe(struct device *dev, int irq, int hw_id,
>>>    			return err;
>>>    	}
>>> +	if (dev->of_node && of_property_read_bool(dev->of_node, "wakeup-source"))
>>> +		device_init_wakeup(dev, true);
>>> +
>>>    	return 0;
>>>    }
>>>    EXPORT_SYMBOL(st_lsm6dsx_probe);
>>> @@ -1876,6 +1879,12 @@ static int __maybe_unused st_lsm6dsx_suspend(struct device *dev)
>>>    		if (!(hw->enable_mask & BIT(sensor->id)))
>>>    			continue;
>>> +		if (device_may_wakeup(dev) && i == ST_LSM6DSX_ID_ACC) {
>>> +			/* Enable wake from IRQ */
>>> +			enable_irq_wake(hw->irq);
>>> +			continue;
> 
> I guess here we need even to check hw->event_enable, don't we?
Good idea :)

> 
>>> +		}
>>> +
>>>    		if (sensor->id == ST_LSM6DSX_ID_EXT0 ||
>>>    		    sensor->id == ST_LSM6DSX_ID_EXT1 ||
>>>    		    sensor->id == ST_LSM6DSX_ID_EXT2)
>>> @@ -1908,6 +1917,11 @@ static int __maybe_unused st_lsm6dsx_resume(struct device *dev)
>>>    		if (!(hw->suspend_mask & BIT(sensor->id)))
>>>    			continue;
>>> +		if (device_may_wakeup(dev) && i == ST_LSM6DSX_ID_ACC) {
>>> +			disable_irq_wake(hw->irq);
>>> +			continue;
>>> +		}
>>> +
>> This section needs to move above:
> 
> agree, and we probably do not need 'continue'. Moreover I guess we should check
> hw->event_enable even here, right?

Correct we don't need the 'continue' here... The 'hw->suspend_mask' is 
not set as we skip it in the resume part.
I'll add the 'hw->enable_event' check here as well.

Is there more stuff that blocks this series from your point of view?

/Sean

  reply	other threads:[~2019-09-13  8:44 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-12  7:06 [PATCH v7 0/5] enable motion events for st_lsm6dsx Sean Nyekjaer
2019-09-12  7:06 ` [PATCH v7 1/5] iio: imu: st_lsm6dsx: move interrupt thread to core Sean Nyekjaer
2019-09-12  7:06 ` [PATCH v7 2/5] iio: imu: st_lsm6dsx: add motion events Sean Nyekjaer
2019-09-12  7:06 ` [PATCH v7 3/5] iio: imu: st_lsm6dsx: add wakeup-source option Sean Nyekjaer
2019-09-13  6:08   ` Sean Nyekjaer
2019-09-13  8:27     ` Lorenzo Bianconi
2019-09-13  8:43       ` Sean Nyekjaer [this message]
2019-09-13  8:58         ` Lorenzo Bianconi
2019-09-13  9:00           ` Sean Nyekjaer
2019-09-12  7:06 ` [PATCH v7 4/5] iio: imu: st_lsm6dsx: always enter interrupt thread Sean Nyekjaer
2019-09-12  7:06 ` [PATCH v7 5/5] iio: imu: st_lsm6dsx: add motion report function and call from interrupt Sean Nyekjaer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=66e35f99-780b-7063-37ad-3fb656a6dffc@geanix.com \
    --to=sean@geanix.com \
    --cc=armando.visconti@st.com \
    --cc=denis.ciocca@st.com \
    --cc=jic23@kernel.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=lorenzo.bianconi83@gmail.com \
    --cc=lorenzo@kernel.org \
    --cc=mario.tesi@st.com \
    --cc=martin@geanix.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).