From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6E0F6C6FD1F for ; Sun, 19 Mar 2023 12:41:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229697AbjCSMk7 (ORCPT ); Sun, 19 Mar 2023 08:40:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35098 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229488AbjCSMk6 (ORCPT ); Sun, 19 Mar 2023 08:40:58 -0400 Received: from mail-ed1-x52f.google.com (mail-ed1-x52f.google.com [IPv6:2a00:1450:4864:20::52f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A95B4CD for ; Sun, 19 Mar 2023 05:40:52 -0700 (PDT) Received: by mail-ed1-x52f.google.com with SMTP id x3so36892974edb.10 for ; Sun, 19 Mar 2023 05:40:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1679229651; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=oolnoui9bwD72saRuWz2eUL7PghL9zZD0Mg8CNmPTv8=; b=TU4fToK9xe5RwL9b/rKxUGlthV1NWIQ7hzk1PZnj0tao9+WMFpR0JmIU36YK0ECFK2 GeR1qwIQI5eWG+OlHulbySE96Q9h3EcUUD5+TYc6NgCMu0G7ZkH3CAh6hwYXDERGtBAq Eb/275avjh10RRenfGcJZrR7mq0L2V1ix0oONTR+CliZ1/ZomY0lToOcTsPvzZYP6G9I sogM+TaTXZd1ODii5kGR6C/tk5RfHV5dBf8tpmcUNLm1WDTKUOGF5REN8Xk+HVHq1/fH dW3A41ot2SpKd0T/W50dYuL+Vhq4Vhl4g0kKImCvxixBgiWEglqWy6+CGHYECic3020U iQLg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679229651; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=oolnoui9bwD72saRuWz2eUL7PghL9zZD0Mg8CNmPTv8=; b=wtcgCKqNwTAtifQyjOcCU9MxjSuVCjgM8Eth21d9CCJYumcfE5JboIF5uN1ASgJxk/ OzCjda3/xmytG2xIblsNXDUCqhobVUGj/qmWzRPBtjwI5k5jYtnGqB4+M011GQRuPcnG 4Jsngph5YAlx0XA2IcKXzx7aTlwRpSJq75FitEfJvnfz2VD96b5yuYTmoU0G0PjNzXJf gnkBF3SmpU9gYkYxlbmMfR9GZOfda+9BPg9ETGNraKwYV7KGg8a6L8bf1yunbPbMkDXX QMS4u+fmokhxCsq4/BZSjxusVGG7b/p8t+kF31KEinp8t/oRLA/yFkrbWwFyC3xgaakN BGsA== X-Gm-Message-State: AO0yUKWeehS4GZIGoCC9uDalBDbbpuAcssyxVTjsuoRvXd/P8gmSvAuh HwAH0K3RLwksza8AiOYi3MFwxGuhPG2zlMCiWSI= X-Google-Smtp-Source: AK7set8no1xdwXSt61q0acLXah4PhkPn/qpNih1kHxFoOM8Dm3h51+p3tGWlnneauNyuCVN/2xpqkQ== X-Received: by 2002:aa7:cac8:0:b0:500:4c0e:cb8d with SMTP id l8-20020aa7cac8000000b005004c0ecb8dmr6412475edt.5.1679229651181; Sun, 19 Mar 2023 05:40:51 -0700 (PDT) Received: from ?IPV6:2a02:810d:15c0:828:5b5f:f22b:a0b:559d? ([2a02:810d:15c0:828:5b5f:f22b:a0b:559d]) by smtp.gmail.com with ESMTPSA id u4-20020a17090626c400b00924916f9c21sm3182394ejc.87.2023.03.19.05.40.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 19 Mar 2023 05:40:50 -0700 (PDT) Message-ID: <708b63c9-d2b6-c65f-0112-8f50173c0bca@linaro.org> Date: Sun, 19 Mar 2023 13:40:49 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [PATCH V2 4/8] dt-bindings: iio: st-sensors: Add IIS328DQ accelerometer To: Jonathan Cameron , Stefan Wahren Cc: Rob Herring , Krzysztof Kozlowski , Lars-Peter Clausen , Arnd Bergmann , Olof Johansson , Evgeniy Polyakov , Shawn Guo , Sascha Hauer , Fabio Estevam , linux-imx@nxp.com, Li Yang , Denis Ciocca , soc@kernel.org, linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, stefan.wahren@i2se.com References: <20230317103323.7741-1-stefan.wahren@chargebyte.com> <20230317103323.7741-5-stefan.wahren@chargebyte.com> <20230318155534.16b47583@jic23-huawei> Content-Language: en-US From: Krzysztof Kozlowski In-Reply-To: <20230318155534.16b47583@jic23-huawei> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org On 18/03/2023 16:55, Jonathan Cameron wrote: > On Fri, 17 Mar 2023 11:33:19 +0100 > Stefan Wahren wrote: > >> The ST IIS328DQ is an accelerometer sensor, which is compatible with >> the already supported ST H3LIS331DL. So add the new compatible >> with a fallback to the ST sensor binding. >> >> Link: https://lore.kernel.org/linux-iio/2bac9ecf-9d2e-967e-9020-1c950487d781@i2se.com/ >> Suggested-by: Jonathan Cameron >> Signed-off-by: Stefan Wahren >> --- >> Documentation/devicetree/bindings/iio/st,st-sensors.yaml | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/iio/st,st-sensors.yaml b/Documentation/devicetree/bindings/iio/st,st-sensors.yaml >> index c6201976378f..5eb71b24a7cb 100644 >> --- a/Documentation/devicetree/bindings/iio/st,st-sensors.yaml >> +++ b/Documentation/devicetree/bindings/iio/st,st-sensors.yaml >> @@ -48,6 +48,9 @@ properties: >> - st,lsm330d-accel >> - st,lsm330dl-accel >> - st,lsm330dlc-accel >> + - items: >> + - const: st,iis328dq >> + - const: st,h3lis331dl-accel > > Hmm. So this separates the particular 'oneOf' group from the description > associated with the ST accelerometers. > > DT experts, is there a better way to do this? Ideally we'd also associate > other similar groups going forwards so it might become less and less obvious > how the groupings work. (bit late for the many groups that exist > already in that list above this point). If by "grouping" you mean how the oneOf items are organized with descriptions, I wouldn't put too much attention to it. You can add some '#' comments to separate the groups, but for me this is still readable. Acked-by: Krzysztof Kozlowski Best regards, Krzysztof