Re: [PATCH 13/13] dt-bindings: iio: adc: ti,tlc4541 binding conversion

[Phil Reid <preid@electromag.com.au>]

On 9/08/2020 19:17, Jonathan Cameron wrote:
> From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> 
> Simple binding so easy to convert.
> Dropped the stated value of maximum spi bus frequency as it does
> not seem to correspond to the datasheet.  The value of 200kHz
> is the max sampling frequency of the ADC, not the clock frequency of
> the SPI bus.
> 
> Added #io-channel-cells to allow use as a provider of channels to
> other devices via the consumer binding.
> 
> Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> Cc: Phil Reid <preid@electromag.com.au>

Yes, the spi frequency can be higher.
Thanks.

Reviewed-By: Phil Reid <preid@electromag.com.au>

> ---
>   .../bindings/iio/adc/ti,tlc4541.yaml          | 52 +++++++++++++++++++
>   .../bindings/iio/adc/ti-tlc4541.txt           | 17 ------
>   2 files changed, 52 insertions(+), 17 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/iio/adc/ti,tlc4541.yaml b/Documentation/devicetree/bindings/iio/adc/ti,tlc4541.yaml
> new file mode 100644
> index 000000000000..6c2539b3d707
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/adc/ti,tlc4541.yaml
> @@ -0,0 +1,52 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/iio/adc/ti,tlc4541.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Texas Instruments TLC4541 and similar ADCs
> +
> +maintainers:
> +  - Phil Reid <preid@electromag.com.au>
> +
> +description: |
> +  14/16bit single channel ADC with SPI interface.
> +
> +properties:
> +  compatible:
> +    enum:
> +      - ti,tlc3541
> +      - ti,tlc4541
> +
> +  reg:
> +    maxItems: 1
> +
> +  spi-max-frequency: true
> +
> +  vref-supply: true
> +
> +  "#io-channel-cells":
> +    const: 1
> +
> +required:
> +  - compatible
> +  - reg
> +  - vref-supply
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    spi {
> +        #address-cells = <1>;
> +        #size-cells = <0>;
> +
> +        adc@0 {
> +            compatible = "ti,tlc4541";
> +            reg = <0>;
> +            vref-supply = <&vdd_supply>;
> +            spi-max-frequency = <200000>;
> +            #io-channel-cells = <1>;
> +        };
> +    };
> +...
> diff --git a/Documentation/devicetree/bindings/iio/adc/ti-tlc4541.txt b/Documentation/devicetree/bindings/iio/adc/ti-tlc4541.txt
> deleted file mode 100644
> index 6b2692723a04..000000000000
> --- a/Documentation/devicetree/bindings/iio/adc/ti-tlc4541.txt
> +++ /dev/null
> @@ -1,17 +0,0 @@
> -* Texas Instruments' TLC4541
> -
> -Required properties:
> - - compatible: Should be one of
> -	* "ti,tlc4541"
> -	* "ti,tlc3541"
> -	- reg: SPI chip select number for the device
> - - vref-supply: The regulator supply for ADC reference voltage
> - - spi-max-frequency: Max SPI frequency to use (<= 200000)
> -
> -Example:
> -adc@0 {
> -	compatible = "ti,tlc4541";
> -	reg = <0>;
> -	vref-supply = <&vdd_supply>;
> -	spi-max-frequency = <200000>;
> -};
> 


-- 
Regards
Phil Reid