* [PATCH] iio: adc: rcar-gyroadc: use devm_platform_ioremap_resource
@ 2019-10-13 15:48 jic23
2019-11-04 15:17 ` Ardelean, Alexandru
0 siblings, 1 reply; 3+ messages in thread
From: jic23 @ 2019-10-13 15:48 UTC (permalink / raw)
To: linux-iio; +Cc: Jonathan Cameron, Marek Vasut
From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Avoids some local boilerplate.
Suggested by coccinelle.
CHECK drivers/iio/adc/rcar-gyroadc.c
drivers/iio/adc/rcar-gyroadc.c:495:1-11: WARNING: Use devm_platform_ioremap_resource for priv -> regs
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Cc: Marek Vasut <marek.vasut+renesas@gmail.com>
---
drivers/iio/adc/rcar-gyroadc.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/iio/adc/rcar-gyroadc.c b/drivers/iio/adc/rcar-gyroadc.c
index c37f201294b2..63ce743ee7af 100644
--- a/drivers/iio/adc/rcar-gyroadc.c
+++ b/drivers/iio/adc/rcar-gyroadc.c
@@ -481,7 +481,6 @@ static int rcar_gyroadc_probe(struct platform_device *pdev)
struct device *dev = &pdev->dev;
struct rcar_gyroadc *priv;
struct iio_dev *indio_dev;
- struct resource *mem;
int ret;
indio_dev = devm_iio_device_alloc(dev, sizeof(*priv));
@@ -491,8 +490,7 @@ static int rcar_gyroadc_probe(struct platform_device *pdev)
priv = iio_priv(indio_dev);
priv->dev = dev;
- mem = platform_get_resource(pdev, IORESOURCE_MEM, 0);
- priv->regs = devm_ioremap_resource(dev, mem);
+ priv->regs = devm_platform_ioremap_resource(pdev, 0);
if (IS_ERR(priv->regs))
return PTR_ERR(priv->regs);
--
2.23.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] iio: adc: rcar-gyroadc: use devm_platform_ioremap_resource
2019-10-13 15:48 [PATCH] iio: adc: rcar-gyroadc: use devm_platform_ioremap_resource jic23
@ 2019-11-04 15:17 ` Ardelean, Alexandru
2019-11-09 12:25 ` Jonathan Cameron
0 siblings, 1 reply; 3+ messages in thread
From: Ardelean, Alexandru @ 2019-11-04 15:17 UTC (permalink / raw)
To: jic23, linux-iio; +Cc: marek.vasut+renesas, Jonathan.Cameron
On Sun, 2019-10-13 at 16:48 +0100, jic23@kernel.org wrote:
> From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
>
> Avoids some local boilerplate.
> Suggested by coccinelle.
>
> CHECK drivers/iio/adc/rcar-gyroadc.c
> drivers/iio/adc/rcar-gyroadc.c:495:1-11: WARNING: Use
> devm_platform_ioremap_resource for priv -> regs
>
Reviewed-by: Alexandru Ardelean <alexandru.ardelean@analog.com>
> Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> Cc: Marek Vasut <marek.vasut+renesas@gmail.com>
> ---
> drivers/iio/adc/rcar-gyroadc.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/iio/adc/rcar-gyroadc.c b/drivers/iio/adc/rcar-
> gyroadc.c
> index c37f201294b2..63ce743ee7af 100644
> --- a/drivers/iio/adc/rcar-gyroadc.c
> +++ b/drivers/iio/adc/rcar-gyroadc.c
> @@ -481,7 +481,6 @@ static int rcar_gyroadc_probe(struct platform_device
> *pdev)
> struct device *dev = &pdev->dev;
> struct rcar_gyroadc *priv;
> struct iio_dev *indio_dev;
> - struct resource *mem;
> int ret;
>
> indio_dev = devm_iio_device_alloc(dev, sizeof(*priv));
> @@ -491,8 +490,7 @@ static int rcar_gyroadc_probe(struct platform_device
> *pdev)
> priv = iio_priv(indio_dev);
> priv->dev = dev;
>
> - mem = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - priv->regs = devm_ioremap_resource(dev, mem);
> + priv->regs = devm_platform_ioremap_resource(pdev, 0);
> if (IS_ERR(priv->regs))
> return PTR_ERR(priv->regs);
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] iio: adc: rcar-gyroadc: use devm_platform_ioremap_resource
2019-11-04 15:17 ` Ardelean, Alexandru
@ 2019-11-09 12:25 ` Jonathan Cameron
0 siblings, 0 replies; 3+ messages in thread
From: Jonathan Cameron @ 2019-11-09 12:25 UTC (permalink / raw)
To: Ardelean, Alexandru; +Cc: linux-iio, marek.vasut+renesas, Jonathan.Cameron
On Mon, 4 Nov 2019 15:17:28 +0000
"Ardelean, Alexandru" <alexandru.Ardelean@analog.com> wrote:
> On Sun, 2019-10-13 at 16:48 +0100, jic23@kernel.org wrote:
> > From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> >
> > Avoids some local boilerplate.
> > Suggested by coccinelle.
> >
> > CHECK drivers/iio/adc/rcar-gyroadc.c
> > drivers/iio/adc/rcar-gyroadc.c:495:1-11: WARNING: Use
> > devm_platform_ioremap_resource for priv -> regs
> >
>
> Reviewed-by: Alexandru Ardelean <alexandru.ardelean@analog.com>
Applied,
Thanks,
Jonathan
>
> > Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> > Cc: Marek Vasut <marek.vasut+renesas@gmail.com>
> > ---
> > drivers/iio/adc/rcar-gyroadc.c | 4 +---
> > 1 file changed, 1 insertion(+), 3 deletions(-)
> >
> > diff --git a/drivers/iio/adc/rcar-gyroadc.c b/drivers/iio/adc/rcar-
> > gyroadc.c
> > index c37f201294b2..63ce743ee7af 100644
> > --- a/drivers/iio/adc/rcar-gyroadc.c
> > +++ b/drivers/iio/adc/rcar-gyroadc.c
> > @@ -481,7 +481,6 @@ static int rcar_gyroadc_probe(struct platform_device
> > *pdev)
> > struct device *dev = &pdev->dev;
> > struct rcar_gyroadc *priv;
> > struct iio_dev *indio_dev;
> > - struct resource *mem;
> > int ret;
> >
> > indio_dev = devm_iio_device_alloc(dev, sizeof(*priv));
> > @@ -491,8 +490,7 @@ static int rcar_gyroadc_probe(struct platform_device
> > *pdev)
> > priv = iio_priv(indio_dev);
> > priv->dev = dev;
> >
> > - mem = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> > - priv->regs = devm_ioremap_resource(dev, mem);
> > + priv->regs = devm_platform_ioremap_resource(pdev, 0);
> > if (IS_ERR(priv->regs))
> > return PTR_ERR(priv->regs);
> >
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-11-09 12:25 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-13 15:48 [PATCH] iio: adc: rcar-gyroadc: use devm_platform_ioremap_resource jic23
2019-11-04 15:17 ` Ardelean, Alexandru
2019-11-09 12:25 ` Jonathan Cameron
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).