From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 766C3C433E1 for ; Tue, 28 Jul 2020 18:33:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5FD9E2074F for ; Tue, 28 Jul 2020 18:33:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732458AbgG1SdO (ORCPT ); Tue, 28 Jul 2020 14:33:14 -0400 Received: from smtprelay0013.hostedemail.com ([216.40.44.13]:37338 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1732457AbgG1SdO (ORCPT ); Tue, 28 Jul 2020 14:33:14 -0400 X-Greylist: delayed 534 seconds by postgrey-1.27 at vger.kernel.org; Tue, 28 Jul 2020 14:33:14 EDT Received: from smtprelay.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by smtpgrave01.hostedemail.com (Postfix) with ESMTP id D2EDB1801D006 for ; Tue, 28 Jul 2020 18:24:20 +0000 (UTC) Received: from filter.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay08.hostedemail.com (Postfix) with ESMTP id 3DBF1182CF689; Tue, 28 Jul 2020 18:24:19 +0000 (UTC) X-Session-Marker: 6A6F6540706572636865732E636F6D X-HE-Tag: copy85_0111d2226f6c X-Filterd-Recvd-Size: 4570 Received: from XPS-9350 (unknown [172.58.27.230]) (Authenticated sender: joe@perches.com) by omf16.hostedemail.com (Postfix) with ESMTPA; Tue, 28 Jul 2020 18:24:15 +0000 (UTC) Message-ID: <855ea08a4c41bc107f88699230309675bd9075b0.camel@perches.com> Subject: Re: [PATCH 13/15] iio: sx9310: Add newlines to printks From: Joe Perches To: Andy Shevchenko , Daniel Campello Cc: LKML , LKML , Jonathan Cameron , Stephen Boyd , Douglas Anderson , Enrico Granata , Gwendal Grignou , Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald-Stadler , linux-iio Date: Tue, 28 Jul 2020 11:24:07 -0700 In-Reply-To: References: <20200724183954.1.I2e29ae25368ba8a72a9e44121cfbc36ead8ecc6b@changeid> <20200728151258.1222876-1-campello@chromium.org> <20200728091057.13.I14600506d0f725bf800c8da4ef89fdb3c3fb45cd@changeid> Content-Type: text/plain; charset="ISO-8859-1" User-Agent: Evolution 3.36.3-0ubuntu1 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-iio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org On Tue, 2020-07-28 at 21:19 +0300, Andy Shevchenko wrote: > On Tue, Jul 28, 2020 at 6:14 PM Daniel Campello wrote: > > From: Stephen Boyd > > > > Printks in the kernel have newlines at the end. Add them to the few > > Printk()s > > > printks in this driver. > > printk()s Random kernel pedantry. This patch should not need to be respun for any of these. > > Reviewed-by: Daniel Campello > > Reviewed-by: Douglas Anderson > > Fixes: 72ad02b15d63 ("iio: Add SEMTECH SX9310/9311 sensor driver") > > Signed-off-by: Stephen Boyd > > Signed-off-by: Daniel Campello > > It has ordering issues > Should be > > Fixes: > SoB: Stephen > Rb: Douglas > Rb: Daniel > SoB: Daniel > > > > --- > > > > drivers/iio/proximity/sx9310.c | 8 ++++---- > > 1 file changed, 4 insertions(+), 4 deletions(-) > > > > diff --git a/drivers/iio/proximity/sx9310.c b/drivers/iio/proximity/sx9310.c > > index 3f981d28ee4056..4553ee83a016a3 100644 > > --- a/drivers/iio/proximity/sx9310.c > > +++ b/drivers/iio/proximity/sx9310.c > > @@ -809,7 +809,7 @@ static int sx9310_init_compensation(struct iio_dev *indio_dev) > > if (ret) { > > if (ret == -ETIMEDOUT) > > dev_err(&data->client->dev, > > - "0x02 << 3l compensation timed out: 0x%02x", > > + "0x02 << 3l compensation timed out: 0x%02x\n", > > Looks like ping-pong style in the series, i.e. you may fix this when > you introduced this line. > > Check the rest (and not only printk()s) for the similar style and > avoid the latter. > > > val); > > return ret; > > } > > @@ -855,7 +855,7 @@ static int sx9310_set_indio_dev_name(struct device *dev, > > > > ddata = (uintptr_t)device_get_match_data(dev); > > if (ddata != whoami) { > > - dev_err(dev, "WHOAMI does not match device data: %u", whoami); > > + dev_err(dev, "WHOAMI does not match device data: %u\n", whoami); > > return -ENODEV; > > } > > > > @@ -867,7 +867,7 @@ static int sx9310_set_indio_dev_name(struct device *dev, > > indio_dev->name = "sx9311"; > > break; > > default: > > - dev_err(dev, "unexpected WHOAMI response: %u", whoami); > > + dev_err(dev, "unexpected WHOAMI response: %u\n", whoami); > > return -ENODEV; > > } > > > > @@ -896,7 +896,7 @@ static int sx9310_probe(struct i2c_client *client) > > > > ret = regmap_read(data->regmap, SX9310_REG_WHOAMI, &data->whoami); > > if (ret) { > > - dev_err(dev, "error in reading WHOAMI register: %d", ret); > > + dev_err(dev, "error in reading WHOAMI register: %d\n", ret); > > return ret; > > } > > > > -- > > 2.28.0.rc0.142.g3c755180ce-goog > > > >