From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6A4DBC4CEC7 for ; Sun, 15 Sep 2019 13:23:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2D8C4214C6 for ; Sun, 15 Sep 2019 13:23:14 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=geanix.com header.i=@geanix.com header.b="Q7vo34eK" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727741AbfIONXN (ORCPT ); Sun, 15 Sep 2019 09:23:13 -0400 Received: from first.geanix.com ([116.203.34.67]:46682 "EHLO first.geanix.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726268AbfIONXN (ORCPT ); Sun, 15 Sep 2019 09:23:13 -0400 Received: from [192.168.100.95] (unknown [95.138.208.137]) by first.geanix.com (Postfix) with ESMTPSA id CE8D4EEE; Sun, 15 Sep 2019 13:22:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=geanix.com; s=first; t=1568553735; bh=1kxu69aJJZJdJUfidmTHcCVbpQRGUZ4lI2ATDv9BIm8=; h=Subject:To:Cc:References:From:Date:In-Reply-To; b=Q7vo34eKU+6P+ULVekidLP2eOJlYYnzf6ZXBID5uZqw8FORHAGq2aczAPjFTgZAW/ twFjX2mJHLCz287dlY1FDSoCs5YAbwpYnLNm8Il+5oqI9dwnsnGWHWVKz/nh8UAGTh fZWBN0Hqgs2fcg4K/gN+dncP3l+olgTjvYXCSnYUqXmELKKeda66XL+8CSALFWzpkd 6lc5WSrdNEEGlgNklJUcvzwr2kwEM0vmTXk8dWBhSp2aDKZw28zTC4kRt5CPnUBNKN MwM4hUmz5w9yCDHnv01YsZOQ2QE8WNiVYgpcNULe+wSZ8YkGFkeAqSm2Yr3YNWUaeM zofM3JS87sSvQ== Subject: Re: [PATCH v8 5/5] iio: imu: st_lsm6dsx: add motion report function and call from interrupt To: Jonathan Cameron , Lorenzo Bianconi Cc: linux-iio@vger.kernel.org, lorenzo.bianconi83@gmail.com, denis.ciocca@st.com, mario.tesi@st.com, armando.visconti@st.com, martin@geanix.com References: <20190913090708.1442057-1-sean@geanix.com> <20190913090708.1442057-6-sean@geanix.com> <20190915133040.0953ef1a@archlinux> <20190915130508.GB15634@lore-desk-wlan.lan> <20190915141808.6ca04f0f@archlinux> From: Sean Nyekjaer Message-ID: <85c144b0-1e73-9fcf-853a-820a71d86b1a@geanix.com> Date: Sun, 15 Sep 2019 15:22:44 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.1.0 MIME-Version: 1.0 In-Reply-To: <20190915141808.6ca04f0f@archlinux> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US-large Content-Transfer-Encoding: 7bit Sender: linux-iio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org On 15/09/2019 15.18, Jonathan Cameron wrote: > On Sun, 15 Sep 2019 15:05:08 +0200 > Lorenzo Bianconi wrote: > >>> On Fri, 13 Sep 2019 11:07:08 +0200 >>> Sean Nyekjaer wrote: >>> >>>> Report iio motion events to iio subsystem >>>> >>>> Signed-off-by: Sean Nyekjaer >>> I got to the earlier thread rather late so hadn't replied to your >>> question on filtering events that haven't been enabled. >> >> IIUC, how is possible to filter events? it seems not currently supported in >> hw, right? > Filter them in software on their way to userspace. So you'll get an interrupt > either way, but no need to tell userspace about event's it's not interested > in. Fine by me, will submit a V9. Which one is preferred: in_accel_thresh_(x,y,z)_en -> in_accel_thresh_both_en or keep in_accel_thresh_(x,y,z)_en and filter them in the driver? We would wake on all events either way /Sean >> >>> >>> Hence I think it's just that change outstanding >>> + I want to give Lorenzo time for a final look. >> >> Jonathan the series seems fine to me now, there are some leftover nitpicks we can >> cover with some follow-up patches. > > Acks/Reviewed-bys? Let's do this formally! > > Jonathan > >> >> Regards, >> Lorenzo >> >>> >>> Thanks, >>> >>> Jonathan >>> >>>> --- >>>> Changes since v4: >>>> * Updated bitmask as pr Jonathans comments >>>> >>>> Changes since v5: >>>> * None >>>> >>>> Changes since v6: >>>> * None >>>> >>>> Changes since v7: >>>> * None >>>> >>>> drivers/iio/imu/st_lsm6dsx/st_lsm6dsx.h | 5 ++ >>>> drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c | 70 ++++++++++++++++++++ >>>> 2 files changed, 75 insertions(+) >>>> >>>> diff --git a/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx.h b/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx.h >>>> index 449c2798f7ed..7c50fac7b85c 100644 >>>> --- a/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx.h >>>> +++ b/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx.h >>>> @@ -186,6 +186,11 @@ struct st_lsm6dsx_shub_settings { >>>> struct st_lsm6dsx_event_settings { >>>> struct st_lsm6dsx_reg enable_reg; >>>> struct st_lsm6dsx_reg wakeup_reg; >>>> + u8 wakeup_src_reg; >>>> + u8 wakeup_src_status_mask; >>>> + u8 wakeup_src_z_mask; >>>> + u8 wakeup_src_y_mask; >>>> + u8 wakeup_src_x_mask; >>>> }; >>>> >>>> enum st_lsm6dsx_ext_sensor_id { >>>> diff --git a/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c b/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c >>>> index 80a94335175f..66700c20920d 100644 >>>> --- a/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c >>>> +++ b/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c >>>> @@ -48,6 +48,7 @@ >>>> #include >>>> #include >>>> #include >>>> +#include >>>> #include >>>> #include >>>> #include >>>> @@ -287,6 +288,11 @@ static const struct st_lsm6dsx_settings st_lsm6dsx_sensor_settings[] = { >>>> .addr = 0x5B, >>>> .mask = GENMASK(5, 0), >>>> }, >>>> + .wakeup_src_reg = 0x1b, >>>> + .wakeup_src_status_mask = BIT(3), >>>> + .wakeup_src_z_mask = BIT(0), >>>> + .wakeup_src_y_mask = BIT(1), >>>> + .wakeup_src_x_mask = BIT(2), >>>> }, >>>> }, >>>> { >>>> @@ -412,6 +418,11 @@ static const struct st_lsm6dsx_settings st_lsm6dsx_sensor_settings[] = { >>>> .addr = 0x5B, >>>> .mask = GENMASK(5, 0), >>>> }, >>>> + .wakeup_src_reg = 0x1b, >>>> + .wakeup_src_status_mask = BIT(3), >>>> + .wakeup_src_z_mask = BIT(0), >>>> + .wakeup_src_y_mask = BIT(1), >>>> + .wakeup_src_x_mask = BIT(2), >>>> }, >>>> }, >>>> { >>>> @@ -550,6 +561,11 @@ static const struct st_lsm6dsx_settings st_lsm6dsx_sensor_settings[] = { >>>> .addr = 0x5B, >>>> .mask = GENMASK(5, 0), >>>> }, >>>> + .wakeup_src_reg = 0x1b, >>>> + .wakeup_src_status_mask = BIT(3), >>>> + .wakeup_src_z_mask = BIT(0), >>>> + .wakeup_src_y_mask = BIT(1), >>>> + .wakeup_src_x_mask = BIT(2), >>>> }, >>>> }, >>>> { >>>> @@ -816,6 +832,11 @@ static const struct st_lsm6dsx_settings st_lsm6dsx_sensor_settings[] = { >>>> .addr = 0x5B, >>>> .mask = GENMASK(5, 0), >>>> }, >>>> + .wakeup_src_reg = 0x1b, >>>> + .wakeup_src_status_mask = BIT(3), >>>> + .wakeup_src_z_mask = BIT(0), >>>> + .wakeup_src_y_mask = BIT(1), >>>> + .wakeup_src_x_mask = BIT(2), >>>> }, >>>> }, >>>> { >>>> @@ -970,6 +991,11 @@ static const struct st_lsm6dsx_settings st_lsm6dsx_sensor_settings[] = { >>>> .addr = 0x5B, >>>> .mask = GENMASK(5, 0), >>>> }, >>>> + .wakeup_src_reg = 0x1b, >>>> + .wakeup_src_status_mask = BIT(3), >>>> + .wakeup_src_z_mask = BIT(0), >>>> + .wakeup_src_y_mask = BIT(1), >>>> + .wakeup_src_x_mask = BIT(2), >>>> } >>>> }, >>>> }; >>>> @@ -1715,6 +1741,38 @@ static struct iio_dev *st_lsm6dsx_alloc_iiodev(struct st_lsm6dsx_hw *hw, >>>> return iio_dev; >>>> } >>>> >>>> +void st_lsm6dsx_report_motion_event(struct st_lsm6dsx_hw *hw, int data) >>>> +{ >>>> + s64 timestamp = iio_get_time_ns(hw->iio_devs[ST_LSM6DSX_ID_ACC]); >>>> + >>>> + if (data & hw->settings->event_settings.wakeup_src_z_mask) >>>> + iio_push_event(hw->iio_devs[ST_LSM6DSX_ID_ACC], >>>> + IIO_MOD_EVENT_CODE(IIO_ACCEL, >>>> + 0, >>>> + IIO_MOD_Z, >>>> + IIO_EV_TYPE_THRESH, >>>> + IIO_EV_DIR_EITHER), >>>> + timestamp); >>>> + >>>> + if (data & hw->settings->event_settings.wakeup_src_x_mask) >>>> + iio_push_event(hw->iio_devs[ST_LSM6DSX_ID_ACC], >>>> + IIO_MOD_EVENT_CODE(IIO_ACCEL, >>>> + 0, >>>> + IIO_MOD_Y, >>>> + IIO_EV_TYPE_THRESH, >>>> + IIO_EV_DIR_EITHER), >>>> + timestamp); >>>> + >>>> + if (data & hw->settings->event_settings.wakeup_src_x_mask) >>>> + iio_push_event(hw->iio_devs[ST_LSM6DSX_ID_ACC], >>>> + IIO_MOD_EVENT_CODE(IIO_ACCEL, >>>> + 0, >>>> + IIO_MOD_X, >>>> + IIO_EV_TYPE_THRESH, >>>> + IIO_EV_DIR_EITHER), >>>> + timestamp); >>>> +} >>>> + >>>> static irqreturn_t st_lsm6dsx_handler_irq(int irq, void *private) >>>> { >>>> return IRQ_WAKE_THREAD; >>>> @@ -1724,6 +1782,18 @@ static irqreturn_t st_lsm6dsx_handler_thread(int irq, void *private) >>>> { >>>> struct st_lsm6dsx_hw *hw = private; >>>> int count; >>>> + int data, err; >>>> + >>>> + if (hw->enable_event) { >>>> + err = regmap_read(hw->regmap, >>>> + hw->settings->event_settings.wakeup_src_reg, >>>> + &data); >>>> + if (err < 0) >>>> + return IRQ_NONE; >>>> + >>>> + if (data & hw->settings->event_settings.wakeup_src_status_mask) >>>> + st_lsm6dsx_report_motion_event(hw, data); >>>> + } >>>> >>>> mutex_lock(&hw->fifo_lock); >>>> count = hw->settings->fifo_ops.read_fifo(hw); >>> >