Linux-IIO Archive on lore.kernel.org
 help / color / Atom feed
From: "Ardelean, Alexandru" <alexandru.Ardelean@analog.com>
To: "Popa, Stefan Serban" <StefanSerban.Popa@analog.com>,
	"linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>,
	"jic23@kernel.org" <jic23@kernel.org>,
	"colin.king@canonical.com" <colin.king@canonical.com>,
	"Hennerich, Michael" <Michael.Hennerich@analog.com>,
	"lars@metafoo.de" <lars@metafoo.de>,
	"knaack.h@gmx.de" <knaack.h@gmx.de>,
	"pmeerw@pmeerw.net" <pmeerw@pmeerw.net>
Cc: "kernel-janitors@vger.kernel.org"
	<kernel-janitors@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] iio: dac: ad5380: fix incorrect assignment to val
Date: Fri, 16 Aug 2019 06:16:26 +0000
Message-ID: <876a4d5190828619f75365863cc6bf2cfea4ffea.camel@analog.com> (raw)
In-Reply-To: <20190815115846.21800-1-colin.king@canonical.com>

On Thu, 2019-08-15 at 12:58 +0100, Colin King wrote:
> [External]
> 

Reviewed-by: Alexandru Ardelean <alexandru.ardelean@analog.com>

> From: Colin Ian King <colin.king@canonical.com>
> 
> Currently the pointer val is being incorrectly incremented
> instead of the value pointed to by val. Fix this by adding
> in the missing * indirection operator.
> 
> Addresses-Coverity: ("Unused value")
> Fixes: c03f2c536818 ("staging:iio:dac: Add AD5380 driver")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>  drivers/iio/dac/ad5380.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/iio/dac/ad5380.c b/drivers/iio/dac/ad5380.c
> index 4335214800d2..2ebe08326048 100644
> --- a/drivers/iio/dac/ad5380.c
> +++ b/drivers/iio/dac/ad5380.c
> @@ -220,7 +220,7 @@ static int ad5380_read_raw(struct iio_dev *indio_dev,
>  		if (ret)
>  			return ret;
>  		*val >>= chan->scan_type.shift;
> -		val -= (1 << chan->scan_type.realbits) / 2;
> +		*val -= (1 << chan->scan_type.realbits) / 2;
>  		return IIO_VAL_INT;
>  	case IIO_CHAN_INFO_SCALE:
>  		*val = 2 * st->vref;

      reply index

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-15 11:58 Colin King
2019-08-16  6:16 ` Ardelean, Alexandru [this message]

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=876a4d5190828619f75365863cc6bf2cfea4ffea.camel@analog.com \
    --to=alexandru.ardelean@analog.com \
    --cc=Michael.Hennerich@analog.com \
    --cc=StefanSerban.Popa@analog.com \
    --cc=colin.king@canonical.com \
    --cc=jic23@kernel.org \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=knaack.h@gmx.de \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pmeerw@pmeerw.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-IIO Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-iio/0 linux-iio/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-iio linux-iio/ https://lore.kernel.org/linux-iio \
		linux-iio@vger.kernel.org linux-iio@archiver.kernel.org
	public-inbox-index linux-iio


Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-iio


AGPL code for this site: git clone https://public-inbox.org/ public-inbox