From: Alexandru Ardelean <ardeleanalex@gmail.com>
To: Jonathan Cameron <jic23@kernel.org>
Cc: "Bárbara Fernandes" <barbara.fernandes@usp.br>,
"Lars-Peter Clausen" <lars@metafoo.de>,
"Michael Hennerich" <Michael.Hennerich@analog.com>,
"Stefan Popa" <stefan.popa@analog.com>,
"Hartmut Knaack" <knaack.h@gmx.de>,
"Peter Meerwald-Stadler" <pmeerw@pmeerw.net>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
linux-iio@vger.kernel.org, devel@driverdev.osuosl.org,
LKML <linux-kernel@vger.kernel.org>,
"Wilson Sales" <spoonm@spoonm.org>,
"Alexandru Ardelean" <alexandru.ardelean@analog.com>
Subject: Re: [RESEND PATCH] staging: iio: ad7192: create of_device_id array
Date: Mon, 20 May 2019 13:22:02 +0300 [thread overview]
Message-ID: <CA+U=DspVbb7UoyThsEG5kqJ+9D2TJtUixF846TkQwFMdaqCpqw@mail.gmail.com> (raw)
In-Reply-To: <20190519114634.0e2a9389@archlinux>
On Sun, May 19, 2019 at 8:53 PM Jonathan Cameron <jic23@kernel.org> wrote:
>
> On Sat, 18 May 2019 19:44:35 -0300
> Bárbara Fernandes <barbara.fernandes@usp.br> wrote:
>
I don't have anything else on top of what Jonathan added.
Acked-by: Alexandru Ardelean <alexandru.ardelean@analog.com>
CC-ing my work-email
There are some issues with it and mailing lists; I'll hopefully sort
them out in the next weeks.
> > Create list of compatible device ids to be matched with those stated in
> > the device tree.
> >
> > Signed-off-by: Bárbara Fernandes <barbara.fernandes@usp.br>
> > Signed-off-by: Wilson Sales <spoonm@spoonm.org>
> > Co-developed by: Wilson Sales <spoonm@spoonm.org>
> Hi Bárbara, Wilson,
>
> One minor issue inline about code ordering.
> Actual content is fine.
>
> Thanks,
>
> Jonathan
>
> > ---
> > drivers/staging/iio/adc/ad7192.c | 12 ++++++++++++
> > 1 file changed, 12 insertions(+)
> >
> > diff --git a/drivers/staging/iio/adc/ad7192.c b/drivers/staging/iio/adc/ad7192.c
> > index 3d74da9d37e7..cc886f944dbf 100644
> > --- a/drivers/staging/iio/adc/ad7192.c
> > +++ b/drivers/staging/iio/adc/ad7192.c
> > @@ -810,11 +810,23 @@ static const struct spi_device_id ad7192_id[] = {
> > {"ad7195", ID_AD7195},
> > {}
> > };
> > +
> > +static const struct of_device_id ad7192_of_spi_match[] = {
> > + { .compatible = "adi,ad7190" },
> > + { .compatible = "adi,ad7192" },
> > + { .compatible = "adi,ad7193" },
> > + { .compatible = "adi,ad7195" },
> > + {}
> > +};
> > +
> > +MODULE_DEVICE_TABLE(of, ad7192_of_spi_match);
> > +
> Please keep the declaration of the table alongside the relevant
> MODULE_DEVICE_TABLE.
>
> In short, better to have your additions after this next line.
> > MODULE_DEVICE_TABLE(spi, ad7192_id);
> >
> > static struct spi_driver ad7192_driver = {
> > .driver = {
> > .name = "ad7192",
> > + .of_match_table = ad7192_of_spi_match,
> > },
> > .probe = ad7192_probe,
> > .remove = ad7192_remove,
>
prev parent reply other threads:[~2019-05-20 10:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-18 22:44 [RESEND PATCH] staging: iio: ad7192: create of_device_id array Bárbara Fernandes
2019-05-19 10:46 ` Jonathan Cameron
2019-05-20 10:22 ` Alexandru Ardelean [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CA+U=DspVbb7UoyThsEG5kqJ+9D2TJtUixF846TkQwFMdaqCpqw@mail.gmail.com' \
--to=ardeleanalex@gmail.com \
--cc=Michael.Hennerich@analog.com \
--cc=alexandru.ardelean@analog.com \
--cc=barbara.fernandes@usp.br \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=jic23@kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
--cc=spoonm@spoonm.org \
--cc=stefan.popa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).