From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 48136C433E6 for ; Tue, 5 Jan 2021 02:04:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 121E922955 for ; Tue, 5 Jan 2021 02:04:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726613AbhAECEd (ORCPT ); Mon, 4 Jan 2021 21:04:33 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54290 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726239AbhAECEd (ORCPT ); Mon, 4 Jan 2021 21:04:33 -0500 Received: from mail-oi1-x22d.google.com (mail-oi1-x22d.google.com [IPv6:2607:f8b0:4864:20::22d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BC96DC061795 for ; Mon, 4 Jan 2021 18:03:52 -0800 (PST) Received: by mail-oi1-x22d.google.com with SMTP id 15so34434982oix.8 for ; Mon, 04 Jan 2021 18:03:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=bAvFCM+Nwif6O5rB2lkK+etNk69rgmZatie3udkuWWk=; b=JEQGcbrEExUn23fbUObkvAsqFSmvjavNCW95udNjzmDUw+ZxJ3fnGwrfLxoKLcykHz OuKMNKC+aiZguWeo9jvT/aFaEoQ8j+w9iShHE5NFu5Hl6tVkGGPKvxQjmlphH80X9Ctl iUpSMGvZh8PVguEGHBTSnQPRj1YI59ZGUpP/51FfMIaYJpWyDghBuYrjD/M1DJVG2KkA +G9Z+GwZ4fXsQeWrqZMg2PYk5cbGMvDUJWUcuou5x+WwnNBuYXvJyvyR1iJ6v2QOSzpW upKtGURRTl/DboW6NK0xlQLn0eTLbZwWz6Nyb1ZoDqk0g9WH6+Zqt0PYrg69LufKneau RXLg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=bAvFCM+Nwif6O5rB2lkK+etNk69rgmZatie3udkuWWk=; b=n5qrOVte0KzLmqczJNXffRyEGLLIrMWXgSgtU88KoaFPQdDJEpaKhfuQiqI9+21SWg xZiwxtVU88RszlqwmaceW4+s6NrR9qmVCLiipwwdT1O1MAiLebEO3A4J5PVMP5VrnTYQ mxtYAYHyJo4mXSFNvFU6ndIPIeULPyCQjr1aqO6nAdxxvCRxO2pd+9oiJyah8B4ell/g 9MhGwEfEzcrOxQ9V4CJJQJU/7i3i3ayg0A22Uy6qphog60AGGeKn4Lht/rUcYvExzhh+ vBg6O7dAmZqTJrKI3GFulJXmU8/neUCb3lwdPBQj7TAUlwYv1VrMi65yXHslP7Kg4QWB rFDg== X-Gm-Message-State: AOAM532M9Rmo4u+K3c3g4s198p9NDR1E1e3KZCQD2nic8ihg8zFN+Yfm 2sCpQYtBNyQsr6IcCuYdXfXeaNGH7Fz58dXqmMV0gg== X-Google-Smtp-Source: ABdhPJwdorJTBMpB8iLRhXColNJZKPg+WmJhZQkbynEQO5a3WJG4d8wVpu0P7MWethLJaacAsXrMP+lj0wfEWFjIUFw= X-Received: by 2002:a05:6808:64d:: with SMTP id z13mr1233982oih.177.1609812231819; Mon, 04 Jan 2021 18:03:51 -0800 (PST) MIME-Version: 1.0 References: <20201204025509.1075506-1-dmitry.baryshkov@linaro.org> In-Reply-To: <20201204025509.1075506-1-dmitry.baryshkov@linaro.org> From: Dmitry Baryshkov Date: Tue, 5 Jan 2021 05:03:38 +0300 Message-ID: Subject: Re: [PATCH v10 00/15] qcom: pm8150: add support for thermal monitoring To: Andy Gross , Bjorn Andersson , Rob Herring , Zhang Rui , Daniel Lezcano , Amit Kucheria , Jonathan Cameron , Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald-Stadler Cc: "open list:DRM DRIVER FOR MSM ADRENO GPU" , linux-pm@vger.kernel.org, "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , linux-iio@vger.kernel.org, Manivannan Sadhasivam , Jishnu Prakash Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org Colleagues, On Fri, 4 Dec 2020 at 05:55, Dmitry Baryshkov wrote: > > This patch serie adds support for thermal monitoring block on Qualcomm's > PMIC5 chips. PM8150{,b,l} and sm8250-mtp board device trees are extended > to support thermal zones provided by this thermal monitoring block. > Unlike the rest of PMIC thermal senses, these thermal zones describe > particular thermistors, which differ between from board to board. > > Changes since v9: > - In patch 12 add comments to the code as requested by Daniel Lezcano. > - Change copyright comment in qcom-spmi-adc-tm5.c to clearly note > driver history. Gracious ping for this patch series. Daniel, do you have any comments? > > Changes since v8: > - Simplified qcom_vadc_map_voltage_temp() code by removing ascending > tables support > - Simplified qcom-vadc-common volt/temp mapping code > - Implement suggestions by Matthias Kaehlcke: message formatting, > rewrite comments, remove unused variable initialization. > > Changes since v7: > - Move qcom-vadc-common.h header to include/linux/iio/adc/ dir. > - Use explicit sizeof(var) instead of hand-coding 1 when accessing > adc-tm registers. > - Remove buffer read from adc_tm5_init(). > - Remove extra on-stack var from adc_tm5_get_temp(). > - Minor formatting changes as suggested Daniel. > > Changes since v6: > - Added include as noted by Jishnu Prakash. > > Changes since v5: > - Reworked DT bindings: > * Removed qcom,adc-channel, instead it is parsed from io-channels > * Renamed qcom,hw-settle-time to include -us suffix > - Re-added monitor enabling which got lost during refactored. Noted by > Jishnu Prakash. > - Use threaded IRQ handler as susggested by Jishnu. > > Changes since v4: > - Added kernel-doc comments to ADC-TM structures > - Used several sizeof(buf) instead of hand-conding register size > > Changes since v3: > - Fix DT description to spell "thermal monitoring" instead of just TM > - Fix warnings in DT example > - Add EXPORT_SYMBOL_GPL(of_iio_channel_get_by_name) > - Fixed whitespace chanes in qcom-vadc-common.c > - Removed error message if IIO chanel get returns -EPROBE_DEFER > > Changes since v2: > - IIO: export of_iio_channel_get_by_name() function > - dt-bindings: move individual io-channels to each thermal monitoring > channel rather than listing them all in device node > - added fallback defaults to of_device_get_match_data calls in > qcom-spmi-adc5 and qcom-spmi-adc-tm5 drivers > - minor typo fixes > > Changes since v1: > - Introduce fixp_linear_interpolate() by Craig Tatlor > - Lots of syntax/whitespace changes > - Cleaned up register definitions per Jonathan's suggestion > - Implemented most of the suggestions from Bjorn's and Jonathan's > review > > -- With best wishes Dmitry