From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.4 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 860A6C352BE for ; Tue, 14 Apr 2020 20:42:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 60FD720771 for ; Tue, 14 Apr 2020 20:42:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="UW03JANv" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729408AbgDNUl5 (ORCPT ); Tue, 14 Apr 2020 16:41:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42580 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1730053AbgDNUlz (ORCPT ); Tue, 14 Apr 2020 16:41:55 -0400 Received: from mail-wm1-x342.google.com (mail-wm1-x342.google.com [IPv6:2a00:1450:4864:20::342]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 32287C061A0F for ; Tue, 14 Apr 2020 13:41:54 -0700 (PDT) Received: by mail-wm1-x342.google.com with SMTP id x25so14652802wmc.0 for ; Tue, 14 Apr 2020 13:41:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=kRD6ER0kESZyvLzhCicmTVhbpnrsXVXBsNz/nRRqon0=; b=UW03JANvjlup8MIxgaN12OcWZzq7aMnlQ1ahjWwW0fKJ3LVfWDPay6E/5n+/DshVIF vsqX/H0BWReIctV3h6m0IbsfCf3/op3n9k9KqN/7abhhc6P7mSI12NkG8sfsIy9RRPvz OZ+JuhkoD38d75gQcIBDzbOwuCyJd5kABsk3la8pblyaMB+WmO56/XDeZHtO1dBSBWOp iDerYsJ+kySrEkSFs1CLjZY2Dh3PHscv752KQmzHpUOHnzZdNVPt7ya0qgqz4F2PXaSg yZCIOtDwCiMjVL7PwmSCpPEONHpMVxYK0//DDBb7tK5GrXc8KD5tIMFvCFHVJEJfB44T JEGg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=kRD6ER0kESZyvLzhCicmTVhbpnrsXVXBsNz/nRRqon0=; b=NJzLB9GaisWDKGY4LrlzjO145bWR/WecJIrg3QTs06LdGmVNjWKxmeIGaAdxFt0OBR TvYQhrcbPPAgEOtXATgJiwv/WLQLAIEZ+MXgvShCyvcgE3T7TthTs2mf3O3LAaZdAjAP ermjT12JQ1yazhiAm9RyuvmSCMOry6uatH2NRUUnlv8kcyOAi6Uyek7N424iARE0KmSj p66o1iZvwWOvGSnt3H5KuDMnmuktG2NEMGYWDTIW1MbGrrXYyHXFZRYd563qwru46yMy yj8/aAqznxwnA5/36hQSe3+gOTtIEU1HxyaL9P9UqECbS52lTr1UtyI1r7vIMtAohrvf nfug== X-Gm-Message-State: AGi0PubmwdD99weZqJPTfq3NgNGBll2kBgymg641dwhXiNhGQj8g8XLA VNGR5fMqQ62L0JEetb3K93+OG7GgwHVL7GbVK/ANzw== X-Google-Smtp-Source: APiQypJfqEPibYcj2k65XEXixEnNsItmQI+g5MjRJaCCFk2dep2r9dX3R/rTcIvaSElU3BOpks6akiiqS+ParjXVlXs= X-Received: by 2002:a1c:5ac4:: with SMTP id o187mr1719537wmb.79.1586896912367; Tue, 14 Apr 2020 13:41:52 -0700 (PDT) MIME-Version: 1.0 References: <20200408175058.2.I1f56fe698017f22d6e825c913c256d5afc2ad69f@changeid> In-Reply-To: From: Daniel Campello Date: Tue, 14 Apr 2020 14:41:16 -0600 Message-ID: Subject: Re: [PATCH 2/2 v8] iio: Add SEMTECH SX9310/9311 sensor driver To: Andy Shevchenko Cc: LKML , LKML , Jonathan Cameron , Gwendal Grignou , Enrico Granata , Andreas Klinger , Christophe JAILLET , Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald-Stadler , Thomas Gleixner , linux-iio Content-Type: text/plain; charset="UTF-8" Sender: linux-iio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org On Tue, Apr 14, 2020 at 3:11 AM Andy Shevchenko wrote: > > On Tue, Apr 14, 2020 at 1:56 AM Daniel Campello wrote: > > On Fri, Apr 10, 2020 at 4:52 AM Andy Shevchenko > > wrote: > > > On Thu, Apr 9, 2020 at 2:54 AM Daniel Campello wrote: > > As far I understand you agreed on the rest. > Correct? > Yes, sorry for not be explicit before. > ... > > > > > Signed-off-by: Gwendal Grignou > > > > Signed-off-by: Enrico Granata > > > > > > This is not understandable. Are they who helped you develop the code > > > (we have a special tag, i.e. Co-developed-by in addition to SoB), or > > > just people in the middle? Then the question is, how come author is > > > you and not Gwendal? > > > > > This patch was initially developed by Gwendal and Enrico (here: > > crrev.com/c/1089826). > > So, tags should include > SoB: Gwendal ... > Co-developed-by: Enrico ... > SoB: Enrico ... > Co-developed-by: yours (if you developed it) > SoB: yours > > and on top git commit --amend --author="Gwendal ..." I sent v10 with this metadata changed. Thanks! > > ... > > > > > +#define SX9310_REG_IRQ_MSK 0x03 > > > > > > Is MSK abbreviation in datasheet? Please spell it how it's in datasheet. > > Yes, they indead use MSK. > > Okay! > > > -- > With Best Regards, > Andy Shevchenko Regards, Daniel