From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Crt Mori <cmo@melexis.com>
Cc: Jonathan Cameron <jic23@kernel.org>,
linux-iio <linux-iio@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v5 2/5] iio:temperature:mlx90632: Add kerneldoc to the internal struct
Date: Thu, 13 Aug 2020 13:54:09 +0300 [thread overview]
Message-ID: <CAHp75Vc3_WkUQOaC86aKe9Fh88Zpip3brShyR64KjXJBt5rrng@mail.gmail.com> (raw)
In-Reply-To: <20200813075125.4949-3-cmo@melexis.com>
On Thu, Aug 13, 2020 at 10:53 AM Crt Mori <cmo@melexis.com> wrote:
>
> Document internal/private struct for mlx90632 device.
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
> Signed-off-by: Crt Mori <cmo@melexis.com>
> ---
> drivers/iio/temperature/mlx90632.c | 9 ++++++++-
> 1 file changed, 8 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/iio/temperature/mlx90632.c b/drivers/iio/temperature/mlx90632.c
> index c3de10ba5b1e..ce75f5a3486b 100644
> --- a/drivers/iio/temperature/mlx90632.c
> +++ b/drivers/iio/temperature/mlx90632.c
> @@ -89,9 +89,16 @@
> #define MLX90632_MAX_MEAS_NUM 31 /**< Maximum measurements in list */
> #define MLX90632_SLEEP_DELAY_MS 3000 /**< Autosleep delay */
>
> +/**
> + * struct mlx90632_data - private data for the MLX90632 device
> + * @client: I2C client of the device
> + * @lock: Internal mutex for multiple reads for single measurement
> + * @regmap: Regmap of the device
> + * @emissivity: Object emissivity from 0 to 1000 where 1000 = 1.
> + */
> struct mlx90632_data {
> struct i2c_client *client;
> - struct mutex lock; /* Multiple reads for single measurement */
> + struct mutex lock;
> struct regmap *regmap;
> u16 emissivity;
> };
> --
> 2.25.1
>
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2020-08-13 10:54 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-13 7:51 [PATCH v5 0/5] iio: temperature: mlx90632: Add extended calibration calculations Crt Mori
2020-08-13 7:51 ` [PATCH v5 1/5] iio:temperature:mlx90632: Reduce number of equal calulcations Crt Mori
2020-08-13 7:51 ` [PATCH v5 2/5] iio:temperature:mlx90632: Add kerneldoc to the internal struct Crt Mori
2020-08-13 10:54 ` Andy Shevchenko [this message]
2020-08-13 7:51 ` [PATCH v5 3/5] iio:temperature:mlx90632: Convert polling while loop to do-while Crt Mori
2020-08-13 11:03 ` Andy Shevchenko
2020-08-13 11:13 ` Crt Mori
2020-08-13 11:24 ` Andy Shevchenko
2020-08-13 13:03 ` Crt Mori
2020-08-13 19:40 ` Andy Shevchenko
2020-08-14 7:32 ` Crt Mori
2020-08-14 9:31 ` Andy Shevchenko
2020-08-14 9:42 ` Crt Mori
2020-08-14 12:11 ` Andy Shevchenko
2020-08-13 7:51 ` [PATCH v5 4/5] iio:temperature:mlx90632: Adding extended calibration option Crt Mori
2020-08-13 11:06 ` Andy Shevchenko
2020-08-13 7:51 ` [PATCH v5 5/5] iio:temperature:mlx90632: Some stylefixing leftovers Crt Mori
2020-08-13 11:01 ` Andy Shevchenko
2020-08-13 13:11 ` Crt Mori
2020-08-13 19:41 ` Andy Shevchenko
2020-08-16 8:38 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHp75Vc3_WkUQOaC86aKe9Fh88Zpip3brShyR64KjXJBt5rrng@mail.gmail.com \
--to=andy.shevchenko@gmail.com \
--cc=cmo@melexis.com \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).