From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: DEEPAK VARMA <mh12gx2825@gmail.com>
Cc: "Ardelean, Alexandru" <alexandru.Ardelean@analog.com>,
"sbrivio@redhat.com" <sbrivio@redhat.com>,
"Caprioru, Mircea" <Mircea.Caprioru@analog.com>,
"kieran.bingham@ideasonboard.com"
<kieran.bingham@ideasonboard.com>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>,
"jic23@kernel.org" <jic23@kernel.org>,
"outreachy-kernel@googlegroups.com"
<outreachy-kernel@googlegroups.com>,
"Hennerich, Michael" <Michael.Hennerich@analog.com>,
"lars@metafoo.de" <lars@metafoo.de>,
"daniel.baluta@gmail.com" <daniel.baluta@gmail.com>,
"pmeerw@pmeerw.net" <pmeerw@pmeerw.net>,
"knaack.h@gmx.de" <knaack.h@gmx.de>
Subject: Re: [Outreachy kernel] Re: [PATCH v3 3/4] staging: iio: adc: ad7192: get_filter_freq code optimization
Date: Wed, 25 Mar 2020 21:37:42 +0200 [thread overview]
Message-ID: <CAHp75VcLj8YLg=iBejQj+UGmhK2nTm1TxETASxt4qDhGOnN0WA@mail.gmail.com> (raw)
In-Reply-To: <20200325173815.GA28246@deeUbuntu>
On Wed, Mar 25, 2020 at 7:38 PM DEEPAK VARMA <mh12gx2825@gmail.com> wrote:
> On Tue, Mar 24, 2020 at 08:06:34AM +0000, Ardelean, Alexandru wrote:
> I further reviewed current and proposed implementation of the
> get_filter_freq() function[Thank you Stefano for your time]. We realised that I
> was wrong in swapping DIV_ROUND_CLOSEST calls with mixing
> multiplication in it. It is indeed incorrect to mix multiplication if we
> want to reorder the calls. Comparison of the results from current and
> proposed implementation proved it. In short, the patch I sent is wrong.
> My apologies for any trouble.
No problem, that's what community is for!
And everybody has been learning always something new.
> We have further improved the test program with a revised implementation
> [attached with this email] and found that this revision appears to
> provide more accurate results [I think].
>
> May I please request you to review the attached test program, verify the
> results and share your feedback.
Do you have GH account? I would highly recommend to use its Gist
facility for such small (one file) type of programs. It allows you to
update them and see versioning. Dunno if possible to comment, but
anyway more advantages.
Thank you!
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2020-03-25 19:37 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-22 19:53 [PATCH v3 0/4] staging: iio: adc: General code reformatting / cleanup patchset Deepak R Varma
2020-03-22 19:54 ` [PATCH v3 1/4] staging: iio: adc: ad7192: Re-indent enum labels Deepak R Varma
2020-03-24 7:18 ` Ardelean, Alexandru
2020-03-26 8:19 ` Ardelean, Alexandru
2020-03-26 8:22 ` Ardelean, Alexandru
2020-03-22 19:55 ` [PATCH v3 2/4] staging: iio: adc: ad7192: Correct macro names from SYNC to SINC Deepak R Varma
2020-03-22 23:40 ` Andy Shevchenko
2020-03-23 17:50 ` DEEPAK VARMA
2020-03-26 8:20 ` Ardelean, Alexandru
2020-03-22 19:56 ` [PATCH v3 3/4] staging: iio: adc: ad7192: get_filter_freq code optimization Deepak R Varma
2020-03-22 23:44 ` Andy Shevchenko
2020-03-23 0:49 ` [Outreachy kernel] " Stefano Brivio
2020-03-23 9:28 ` Andy Shevchenko
2020-03-23 12:15 ` Stefano Brivio
2020-03-23 17:52 ` DEEPAK VARMA
2020-03-24 8:06 ` Ardelean, Alexandru
2020-03-25 17:38 ` DEEPAK VARMA
2020-03-25 19:37 ` Andy Shevchenko [this message]
2020-03-25 19:59 ` Stefano Brivio
2020-03-26 8:15 ` Ardelean, Alexandru
2020-03-22 19:57 ` [PATCH v3 4/4] staging: iio: adc: ad7280a: Add comments to clarify stringified arguments Deepak R Varma
2020-03-24 8:07 ` Ardelean, Alexandru
2020-03-28 13:28 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHp75VcLj8YLg=iBejQj+UGmhK2nTm1TxETASxt4qDhGOnN0WA@mail.gmail.com' \
--to=andy.shevchenko@gmail.com \
--cc=Michael.Hennerich@analog.com \
--cc=Mircea.Caprioru@analog.com \
--cc=alexandru.Ardelean@analog.com \
--cc=daniel.baluta@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jic23@kernel.org \
--cc=kieran.bingham@ideasonboard.com \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=mh12gx2825@gmail.com \
--cc=outreachy-kernel@googlegroups.com \
--cc=pmeerw@pmeerw.net \
--cc=sbrivio@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).