[PATCH v3] iio: light: vcnl4035 add i2c_device_id

[PATCH v3] iio: light: vcnl4035 add i2c_device_id

[Vaishnav M A]

Add i2c_device_id table for the vl53l0x-i2c driver,
helps in device instantiation using i2c_new_client_device
or from userspace in cases where device-tree based description
is not possible now (Example: device on a gbphy i2c adapter
created by greybus)

Signed-off-by: Vaishnav M A <vaishnav@beagleboard.org>
---
 v3:
	-modify commit message for readability
	 as suggested by Jonathan Cameron
 v2:
	-fix commit message
 drivers/iio/light/vcnl4035.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/drivers/iio/light/vcnl4035.c b/drivers/iio/light/vcnl4035.c
index 765c44adac57..73a28e30dddc 100644
--- a/drivers/iio/light/vcnl4035.c
+++ b/drivers/iio/light/vcnl4035.c
@@ -652,6 +652,12 @@ static const struct dev_pm_ops vcnl4035_pm_ops = {
 			   vcnl4035_runtime_resume, NULL)
 };
 
+static const struct i2c_device_id vcnl4035_id[] = {
+	{ "vcnl4035", 0},
+	{ }
+};
+MODULE_DEVICE_TABLE(i2c, vcnl4035_id);
+
 static const struct of_device_id vcnl4035_of_match[] = {
 	{ .compatible = "vishay,vcnl4035", },
 	{ }
@@ -666,6 +672,7 @@ static struct i2c_driver vcnl4035_driver = {
 	},
 	.probe  = vcnl4035_probe,
 	.remove	= vcnl4035_remove,
+	.id_table = vcnl4035_id,
 };
 
 module_i2c_driver(vcnl4035_driver);
-- 
2.25.1

Re: [PATCH v3] iio: light: vcnl4035 add i2c_device_id

[Andy Shevchenko]

On Sun, Oct 18, 2020 at 6:47 PM Vaishnav M A <vaishnav@beagleboard.org> wrote:
>
> Add i2c_device_id table for the vl53l0x-i2c driver,
> helps in device instantiation using i2c_new_client_device

In all your patches please refer to the functions like function().
For example, here is i2c_new_client_device().

> or from userspace in cases where device-tree based description
> is not possible now (Example: device on a gbphy i2c adapter
> created by greybus)

Don't forget proper English punctuation, like periods at the end of sentences.

-- 
With Best Regards,
Andy Shevchenko

Re: [PATCH v3] iio: light: vcnl4035 add i2c_device_id

[Vaishnav M A]

On Sun, Oct 18, 2020 at 11:59 PM Andy Shevchenko
<andy.shevchenko@gmail.com> wrote:
>
> On Sun, Oct 18, 2020 at 6:47 PM Vaishnav M A <vaishnav@beagleboard.org> wrote:
> >
> > Add i2c_device_id table for the vl53l0x-i2c driver,
> > helps in device instantiation using i2c_new_client_device
>
> In all your patches please refer to the functions like function().
> For example, here is i2c_new_client_device().
>
> > or from userspace in cases where device-tree based description
> > is not possible now (Example: device on a gbphy i2c adapter
> > created by greybus)
>
> Don't forget proper English punctuation, like periods at the end of sentences.
>
> --
> With Best Regards,
> Andy Shevchenko

Thank you Andy for your review, I have updated v4 patch with your suggestions,
https://lore.kernel.org/patchwork/patch/1322219/ (sorry about the
incorrect driver
name in the first-line of the commit message in the v3 version). This is
also fixed in the v4 submission.

Thanks,
Vaishnav